All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bill Wendling <morbo@google.com>
To: isanbard@gmail.com
Cc: Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
	 Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	 Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,  "H. Peter Anvin" <hpa@zytor.com>,
	Phillip Potter <phil@philpotter.co.uk>,
	Arnd Bergmann <arnd@arndb.de>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Jan Kara <jack@suse.com>,
	 Andrew Morton <akpm@linux-foundation.org>,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	 Jozsef Kadlecsik <kadlec@netfilter.org>,
	Florian Westphal <fw@strlen.de>,
	 "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>, Jaroslav Kysela <perex@perex.cz>,
	 Takashi Iwai <tiwai@suse.com>,
	Nathan Chancellor <nathan@kernel.org>,
	 Nick Desaulniers <ndesaulniers@google.com>,
	Tom Rix <trix@redhat.com>,
	 Ross Philipson <ross.philipson@oracle.com>,
	Daniel Kiper <daniel.kiper@oracle.com>,
	 linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-acpi@vger.kernel.org, linux-mm@kvack.org,
	 netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	 netdev@vger.kernel.org, alsa-devel@alsa-project.org,
	llvm@lists.linux.dev
Subject: [PATCH 05/12] fs: quota: use correct format characters
Date: Thu,  9 Jun 2022 22:16:24 +0000	[thread overview]
Message-ID: <20220609221702.347522-6-morbo@google.com> (raw)
In-Reply-To: <20220609221702.347522-1-morbo@google.com>

From: Bill Wendling <isanbard@gmail.com>

When compiling with -Wformat, clang emits the following warnings:

fs/quota/dquot.c:206:22: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
                    request_module(module_names[qm].qm_mod_name))
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Use a string literal for the format string.

Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Bill Wendling <isanbard@gmail.com>
---
 fs/quota/dquot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index a74aef99bd3d..3b613de3b371 100644
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -203,7 +203,7 @@ static struct quota_format_type *find_quota_format(int id)
 			     module_names[qm].qm_fmt_id != id; qm++)
 			;
 		if (!module_names[qm].qm_fmt_id ||
-		    request_module(module_names[qm].qm_mod_name))
+		    request_module("%s", module_names[qm].qm_mod_name))
 			return NULL;
 
 		spin_lock(&dq_list_lock);
-- 
2.36.1.255.ge46751e96f-goog


WARNING: multiple messages have this Message-ID (diff)
From: Bill Wendling <morbo@google.com>
To: isanbard@gmail.com
Cc: alsa-devel@alsa-project.org, x86@kernel.org,
	Nick Desaulniers <ndesaulniers@google.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Phillip Potter <phil@philpotter.co.uk>,
	linux-mm@kvack.org, Eric Dumazet <edumazet@google.com>,
	netdev@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Daniel Kiper <daniel.kiper@oracle.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Jozsef Kadlecsik <kadlec@netfilter.org>,
	linux-acpi@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Tom Rix <trix@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	llvm@lists.linux.dev, coreteam@netfilter.org,
	Arnd Bergmann <arnd@arndb.de>,
	Ross Philipson <ross.philipson@oracle.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Borislav Petkov <bp@alien8.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-edac@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Florian Westphal <fw@strlen.de>, Takashi Iwai <tiwai@suse.com>,
	linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org,
	Jan Kara <jack@suse.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: [PATCH 05/12] fs: quota: use correct format characters
Date: Thu,  9 Jun 2022 22:16:24 +0000	[thread overview]
Message-ID: <20220609221702.347522-6-morbo@google.com> (raw)
In-Reply-To: <20220609221702.347522-1-morbo@google.com>

From: Bill Wendling <isanbard@gmail.com>

When compiling with -Wformat, clang emits the following warnings:

fs/quota/dquot.c:206:22: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
                    request_module(module_names[qm].qm_mod_name))
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Use a string literal for the format string.

Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Bill Wendling <isanbard@gmail.com>
---
 fs/quota/dquot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index a74aef99bd3d..3b613de3b371 100644
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -203,7 +203,7 @@ static struct quota_format_type *find_quota_format(int id)
 			     module_names[qm].qm_fmt_id != id; qm++)
 			;
 		if (!module_names[qm].qm_fmt_id ||
-		    request_module(module_names[qm].qm_mod_name))
+		    request_module("%s", module_names[qm].qm_mod_name))
 			return NULL;
 
 		spin_lock(&dq_list_lock);
-- 
2.36.1.255.ge46751e96f-goog


  parent reply	other threads:[~2022-06-09 22:19 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09 22:16 [PATCH 00/12] Clang -Wformat warning fixes Bill Wendling
2022-06-09 22:16 ` Bill Wendling
2022-06-09 22:16 ` [PATCH 01/12] x86/mce: use correct format characters Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-09 23:14   ` Randy Dunlap
2022-06-09 23:14     ` Randy Dunlap
2022-06-09 23:18     ` Bill Wendling
2022-06-09 23:18       ` Bill Wendling
2022-06-09 22:16 ` [PATCH 02/12] x86/CPU/AMD: " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-09 22:16 ` [PATCH 03/12] x86/e820: " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-09 22:16 ` [PATCH 04/12] blk-cgroup: " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-10  8:10   ` Christoph Hellwig
2022-06-10  8:10     ` Christoph Hellwig
2022-06-09 22:16 ` Bill Wendling [this message]
2022-06-09 22:16   ` [PATCH 05/12] fs: quota: " Bill Wendling
2022-06-09 22:16 ` [PATCH 06/12] PNP: " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-09 22:16 ` [PATCH 07/12] driver/char: " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-10  5:18   ` Greg Kroah-Hartman
2022-06-10  5:18     ` Greg Kroah-Hartman
2022-06-13 18:40     ` Bill Wendling
2022-06-13 18:40       ` Bill Wendling
2022-06-09 22:16 ` [PATCH 08/12] cdrom: " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-12 16:23   ` Phillip Potter
2022-06-12 16:23     ` Phillip Potter
2022-06-13 18:47     ` Bill Wendling
2022-06-13 18:47       ` Bill Wendling
2022-06-09 22:16 ` [PATCH 09/12] ALSA: seq: " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-09 22:16 ` [PATCH 10/12] " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-09 22:16 ` [PATCH 11/12] ALSA: control: " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-09 22:16 ` [PATCH 12/12] netfilter: conntrack: " Bill Wendling
2022-06-09 22:16   ` Bill Wendling
2022-06-20 14:44   ` Pablo Neira Ayuso
2022-07-11 14:35   ` Pablo Neira Ayuso
2022-07-11 14:35     ` Pablo Neira Ayuso
2022-06-09 22:25 ` [PATCH 00/12] Clang -Wformat warning fixes Andrew Morton
2022-06-09 22:25   ` Andrew Morton
2022-06-09 22:49   ` Bill Wendling
2022-06-09 22:49     ` Bill Wendling
2022-06-09 23:03     ` Jan Engelhardt
2022-06-09 23:03       ` Jan Engelhardt
2022-06-09 23:16       ` Bill Wendling
2022-06-09 23:16         ` Bill Wendling
2022-06-10  1:19         ` Andrew Morton
2022-06-10  1:19           ` Andrew Morton
2022-06-10  5:20         ` Greg Kroah-Hartman
2022-06-10  5:20           ` Greg Kroah-Hartman
2022-06-10 12:44           ` Joe Perches
2022-06-10 12:44             ` Joe Perches
2022-06-10  8:17     ` David Laight
2022-06-10  8:17       ` David Laight
2022-06-10  8:32       ` Jan Engelhardt
2022-06-10  8:32         ` Jan Engelhardt
2022-06-10  9:14         ` David Laight
2022-06-10  9:14           ` David Laight
2022-06-10  9:22           ` Jan Engelhardt
2022-06-10  9:22             ` Jan Engelhardt
2022-06-10  0:32   ` Nick Desaulniers
2022-06-10  0:32     ` Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220609221702.347522-6-morbo@google.com \
    --to=morbo@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=bp@alien8.de \
    --cc=coreteam@netfilter.org \
    --cc=daniel.kiper@oracle.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=isanbard@gmail.com \
    --cc=jack@suse.com \
    --cc=kadlec@netfilter.org \
    --cc=kuba@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=llvm@lists.linux.dev \
    --cc=mingo@redhat.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    --cc=perex@perex.cz \
    --cc=phil@philpotter.co.uk \
    --cc=rafael.j.wysocki@intel.com \
    --cc=ross.philipson@oracle.com \
    --cc=tglx@linutronix.de \
    --cc=tiwai@suse.com \
    --cc=tony.luck@intel.com \
    --cc=trix@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.