All of lore.kernel.org
 help / color / mirror / Atom feed
From: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
To: mpe@ellerman.id.au
Cc: kjain@linux.ibm.com, maddy@linux.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH V3 11/35] selftest/powerpc/pmu: Add selftest to check PERF_SAMPLE_REGS_INTR option will not crash on any platforms
Date: Fri, 10 Jun 2022 19:10:49 +0530	[thread overview]
Message-ID: <20220610134113.62991-12-atrajeev@linux.vnet.ibm.com> (raw)
In-Reply-To: <20220610134113.62991-1-atrajeev@linux.vnet.ibm.com>

With sampling, --intr-regs option is used for capturing
interrupt regs. When --intr-regs option is used, PMU code
uses is_sier_available() function which uses PMU flags in
the code. In environment where platform specific PMU is
not registered, PMU flags is not defined. A fix was added
in kernel to address crash while accessing is_sier_available()
function when pmu is not set. commit f75e7d73bdf7 ("powerpc/perf:
Fix crash with is_sier_available when pmu is not set").

Add perf sampling test to exercise this code and make sure
enabling intr_regs shouldn't crash in any platform. Testcase
uses software event cycles since software event will work even
in cases without PMU.

Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
---
 .../powerpc/pmu/sampling_tests/Makefile       |  2 +-
 .../intr_regs_no_crash_wo_pmu_test.c          | 57 +++++++++++++++++++
 2 files changed, 58 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/intr_regs_no_crash_wo_pmu_test.c

diff --git a/tools/testing/selftests/powerpc/pmu/sampling_tests/Makefile b/tools/testing/selftests/powerpc/pmu/sampling_tests/Makefile
index 8d4839cde013..8d4566dac440 100644
--- a/tools/testing/selftests/powerpc/pmu/sampling_tests/Makefile
+++ b/tools/testing/selftests/powerpc/pmu/sampling_tests/Makefile
@@ -6,7 +6,7 @@ TEST_GEN_PROGS := mmcr0_exceptionbits_test mmcr0_cc56run_test mmcr0_pmccext_test
 		   mmcr1_comb_test mmcr2_l2l3_test mmcr2_fcs_fch_test \
 		   mmcr3_src_test mmcra_thresh_marked_sample_test mmcra_thresh_cmp_test \
 		   mmcra_bhrb_ind_call_test mmcra_bhrb_any_test mmcra_bhrb_cond_test \
-		   mmcra_bhrb_disable_test bhrb_no_crash_wo_pmu_test
+		   mmcra_bhrb_disable_test bhrb_no_crash_wo_pmu_test intr_regs_no_crash_wo_pmu_test
 
 top_srcdir = ../../../../../..
 include ../../../lib.mk
diff --git a/tools/testing/selftests/powerpc/pmu/sampling_tests/intr_regs_no_crash_wo_pmu_test.c b/tools/testing/selftests/powerpc/pmu/sampling_tests/intr_regs_no_crash_wo_pmu_test.c
new file mode 100644
index 000000000000..839d2d225da0
--- /dev/null
+++ b/tools/testing/selftests/powerpc/pmu/sampling_tests/intr_regs_no_crash_wo_pmu_test.c
@@ -0,0 +1,57 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright 2022, Athira Rajeev, IBM Corp.
+ */
+
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "../event.h"
+#include "misc.h"
+#include "utils.h"
+
+/*
+ * A perf sampling test for making sure
+ * sampling with -intr-regs doesn't crash
+ * in any environment, say:
+ *  - With generic compat PMU
+ *  - without any PMU registered
+ *  - With platform specific PMU.
+ *  A fix for crash with intr_regs was
+ *  addressed in commit: f75e7d73bdf7 in kernel.
+ *
+ * This testcase exercises this code path by doing
+ * intr_regs using software event. Software event is
+ * used since s/w event will work even in platform
+ * without PMU.
+ */
+static int intr_regs_no_crash_wo_pmu_test(void)
+{
+	struct event event;
+
+	/*
+	 * Init the event for the sampling test.
+	 * This uses software event which works on
+	 * any platform.
+	 */
+	event_init_opts(&event, 0, PERF_TYPE_SOFTWARE, "cycles");
+
+	event.attr.sample_period = 1000;
+	event.attr.sample_type = PERF_SAMPLE_REGS_INTR;
+	event.attr.disabled = 1;
+
+	/*
+	 * Return code of event_open is not considered
+	 * since test just expects no crash from using
+	 * PERF_SAMPLE_REGS_INTR.
+	 */
+	event_open(&event);
+
+	event_close(&event);
+	return 0;
+}
+
+int main(void)
+{
+	return test_harness(intr_regs_no_crash_wo_pmu_test, "intr_regs_no_crash_wo_pmu_test");
+}
-- 
2.35.1


  parent reply	other threads:[~2022-06-10 13:49 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10 13:40 [PATCH V3 00/35] Add group constraints and event code test as part of selftest Athira Rajeev
2022-06-10 13:40 ` [PATCH V3 01/35] selftest/powerpc/pmu: Add mask/shift bits for extracting threshold compare field Athira Rajeev
2022-06-10 13:40 ` [PATCH V3 02/35] testing/selftests/powerpc: Add support to fetch "platform" and "base platform" from auxv to detect platform Athira Rajeev
2022-06-10 13:40 ` [PATCH V3 03/35] selftest/powerpc/pmu: Add interface test for mmcra_thresh_cmp fields Athira Rajeev
2022-06-10 13:40 ` [PATCH V3 04/35] selftest/powerpc/pmu: Add support for branch sampling in get_intr_regs function Athira Rajeev
2022-06-10 13:40 ` [PATCH V3 05/35] selftest/powerpc/pmu: Add interface test for mmcra_ifm field of indirect call type Athira Rajeev
2022-06-10 13:40 ` [PATCH V3 06/35] selftest/powerpc/pmu: Add interface test for mmcra_ifm field for any branch type Athira Rajeev
2022-06-10 13:40 ` [PATCH V3 07/35] selftest/powerpc/pmu: Add interface test for mmcra_ifm field for conditional " Athira Rajeev
2022-06-10 13:40 ` [PATCH V3 08/35] selftest/powerpc/pmu: Add interface test for bhrb disable field Athira Rajeev
2022-06-10 13:40 ` [PATCH V3 09/35] selftest/powerpc/pmu: Refactor the platform check and add macros to find array size/PVR Athira Rajeev
2022-06-10 13:40 ` [PATCH V3 10/35] selftest/powerpc/pmu: Add selftest to check branch stack enablement will not crash on any platforms Athira Rajeev
2022-06-10 13:40 ` Athira Rajeev [this message]
2022-06-10 13:40 ` [PATCH V3 12/35] selftest/powerpc/pmu: Add selftest for checking valid and invalid bhrb filter maps Athira Rajeev
2022-06-10 13:40 ` [PATCH V3 13/35] selftest/powerpc/pmu: Add selftest for mmcr1 pmcxsel/unit/cache fields Athira Rajeev
2022-06-10 13:40 ` [PATCH V3 14/35] selftest/powerpc/pmu: Add interface test for bhrb disable field for non-branch samples Athira Rajeev
2022-06-10 13:40 ` [PATCH V3 15/35] selftest/powerpc/pmu: Add support for perf event code tests Athira Rajeev
2022-06-10 13:40 ` [PATCH V3 16/35] selftest/powerpc/pmu: Add selftest for group constraint check for PMC5 and PMC6 Athira Rajeev
2022-06-10 13:40 ` [PATCH V3 17/35] selftest/powerpc/pmu: Add selftest to check PMC5/6 is excluded from some constraint checks Athira Rajeev
2022-06-10 13:40 ` [PATCH V3 18/35] selftest/powerpc/pmu: Add selftest to check constraint for number of counters in use Athira Rajeev
2022-06-10 13:40 ` [PATCH V3 19/35] selftest/powerpc/pmu: Add selftest for group constraint check when using same PMC Athira Rajeev
2022-06-10 13:40 ` [PATCH V3 20/35] selftest/powerpc/pmu: Add selftest for group constraint check for radix_scope_qual field Athira Rajeev
2022-06-10 13:40 ` [PATCH V3 21/35] selftest/powerpc/pmu: Add selftest for group constraint for MMCRA Sampling Mode field Athira Rajeev
2022-06-10 13:41 ` [PATCH V3 22/35] selftest/powerpc/pmu: Add selftest for group constraint check MMCRA sample bits Athira Rajeev
2022-06-10 13:41 ` [PATCH V3 23/35] selftest/powerpc/pmu: Add selftest for checking invalid bits in event code Athira Rajeev
2022-06-10 13:41 ` [PATCH V3 24/35] selftest/powerpc/pmu: Add selftest for reserved bit check for MMCRA thresh_ctl field Athira Rajeev
2022-06-10 13:41 ` [PATCH V3 25/35] selftest/powerpc/pmu: Add selftest for blacklist events check in power9 Athira Rajeev
2022-06-10 13:41 ` [PATCH V3 26/35] selftest/powerpc/pmu: Add selftest for event alternatives for power9 Athira Rajeev
2022-06-10 13:41 ` [PATCH V3 27/35] selftest/powerpc/pmu: Add selftest for event alternatives for power10 Athira Rajeev
2022-06-10 13:41 ` [PATCH V3 28/35] selftest/powerpc/pmu: Add selftest for PERF_TYPE_HARDWARE events valid check Athira Rajeev
2022-06-10 13:41 ` [PATCH V3 29/35] selftest/powerpc/pmu: Add selftest for group constraint check for MMCR0 l2l3_sel bits Athira Rajeev
2022-06-10 13:41 ` [PATCH V3 30/35] selftest/powerpc/pmu: Add selftest for group constraint check for MMCR1 cache bits Athira Rajeev
2022-06-10 13:41 ` [PATCH V3 31/35] selftest/powerpc/pmu: Add selftest for group constraint check for MMCRA thresh_cmp field Athira Rajeev
2022-06-10 13:41 ` [PATCH V3 32/35] selftest/powerpc/pmu: Add selftest for group constraint for unit and pmc field in p9 Athira Rajeev
2022-06-10 13:41 ` [PATCH V3 33/35] selftest/powerpc/pmu: Add selftest for group constraint check for MMCRA thresh_ctl field Athira Rajeev
2022-06-10 13:41 ` [PATCH V3 34/35] selftest/powerpc/pmu: Add selftest for group constraint check for MMCRA thresh_sel field Athira Rajeev
2022-06-10 13:41 ` [PATCH V3 35/35] selftest/powerpc/pmu: Add test for hardware cache events Athira Rajeev
2022-07-04 11:33 ` [PATCH V3 00/35] Add group constraints and event code test as part of selftest Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220610134113.62991-12-atrajeev@linux.vnet.ibm.com \
    --to=atrajeev@linux.vnet.ibm.com \
    --cc=kjain@linux.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.