All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org,
	aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com,
	crosa@redhat.com, richard.henderson@linaro.org,
	"Thomas Huth" <thuth@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>
Subject: [PATCH  v1 6/7] gitlab: compare CIRRUS_nn vars against 'null' not ""
Date: Mon, 13 Jun 2022 18:12:57 +0100	[thread overview]
Message-ID: <20220613171258.1905715-7-alex.bennee@linaro.org> (raw)
In-Reply-To: <20220613171258.1905715-1-alex.bennee@linaro.org>

From: Daniel P. Berrangé <berrange@redhat.com>

The GitLab variable comparisons don't have shell like semantics where
an unset variable compares equal to empty string. We need to explicitly
test against 'null' to detect an unset variable.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Tested-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220608160651.248781-1-berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .gitlab-ci.d/base.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.d/base.yml b/.gitlab-ci.d/base.yml
index f334f3ded7..69b36c148a 100644
--- a/.gitlab-ci.d/base.yml
+++ b/.gitlab-ci.d/base.yml
@@ -13,7 +13,7 @@
     #############################################################
 
     # Cirrus jobs can't run unless the creds / target repo are set
-    - if: '$QEMU_JOB_CIRRUS && ($CIRRUS_GITHUB_REPO == "" || $CIRRUS_API_TOKEN == "")'
+    - if: '$QEMU_JOB_CIRRUS && ($CIRRUS_GITHUB_REPO == null || $CIRRUS_API_TOKEN == null)'
       when: never
 
     # Publishing jobs should only run on the default branch in upstream
-- 
2.30.2



  parent reply	other threads:[~2022-06-13 17:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-13 17:12 [PATCH v1 0/7] testing/next pre-PR (docker, gitlab, tcg) Alex Bennée
2022-06-13 17:12 ` [PATCH v1 1/7] test/tcg/arm: Use -mfloat-abi=soft for test-armv6m-undef Alex Bennée
2022-06-13 17:12 ` [PATCH v1 2/7] tests/tcg/i386: Use explicit suffix on fist insns Alex Bennée
2022-06-13 17:12 ` [PATCH v1 3/7] gitlab-ci: Fix the build-cfi-aarch64 and build-cfi-ppc64-s390x jobs Alex Bennée
2022-06-13 21:46   ` Richard Henderson
2022-06-14  4:30     ` Thomas Huth
2022-06-14  8:29       ` Daniel P. Berrangé
2022-06-13 17:12 ` [PATCH v1 4/7] tests/docker: fix the IMAGE for build invocation Alex Bennée
2022-06-13 21:47   ` Richard Henderson
2022-06-13 17:12 ` [PATCH v1 5/7] tests/tcg: disable xtensa-linux-user again Alex Bennée
2022-06-13 21:47   ` Richard Henderson
2022-06-13 22:33   ` Philippe Mathieu-Daudé via
2022-06-13 17:12 ` Alex Bennée [this message]
2022-06-13 17:12 ` [PATCH v1 7/7] .gitlab: use less aggressive nproc on our aarch64/32 runners Alex Bennée
2022-06-13 21:48   ` Richard Henderson
2022-06-13 23:04   ` Philippe Mathieu-Daudé via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220613171258.1905715-7-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=bleal@redhat.com \
    --cc=crosa@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.