From: Eric Biggers <ebiggers@kernel.org> To: linux-fsdevel@vger.kernel.org Cc: linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-api@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Keith Busch <kbusch@kernel.org> Subject: [PATCH v3 2/8] vfs: support STATX_DIOALIGN on block devices Date: Thu, 16 Jun 2022 13:15:00 -0700 [thread overview] Message-ID: <20220616201506.124209-3-ebiggers@kernel.org> (raw) In-Reply-To: <20220616201506.124209-1-ebiggers@kernel.org> From: Eric Biggers <ebiggers@google.com> Add support for STATX_DIOALIGN to block devices, so that direct I/O alignment restrictions are exposed to userspace in a generic way. Note that this breaks the tradition of stat operating only on the block device node, not the block device itself. However, it was felt that doing this is preferable, in order to make the interface useful and avoid needing separate interfaces for regular files and block devices. Signed-off-by: Eric Biggers <ebiggers@google.com> --- fs/stat.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/fs/stat.c b/fs/stat.c index a7930d7444830..c1ce447c1a383 100644 --- a/fs/stat.c +++ b/fs/stat.c @@ -5,6 +5,7 @@ * Copyright (C) 1991, 1992 Linus Torvalds */ +#include <linux/blkdev.h> #include <linux/export.h> #include <linux/mm.h> #include <linux/errno.h> @@ -198,6 +199,35 @@ int getname_statx_lookup_flags(int flags) return lookup_flags; } +/* Handle STATX_DIOALIGN for block devices. */ +static inline void handle_bdev_dioalign(struct path *path, u32 request_mask, + struct kstat *stat) +{ +#ifdef CONFIG_BLOCK + struct inode *inode; + struct block_device *bdev; + unsigned int lbs; + + if (likely(!(request_mask & STATX_DIOALIGN))) + return; + + inode = d_backing_inode(path->dentry); + if (!S_ISBLK(inode->i_mode)) + return; + + bdev = blkdev_get_no_open(inode->i_rdev); + if (!bdev) + return; + + lbs = bdev_logical_block_size(bdev); + stat->dio_mem_align = lbs; + stat->dio_offset_align = lbs; + stat->result_mask |= STATX_DIOALIGN; + + blkdev_put_no_open(bdev); +#endif /* CONFIG_BLOCK */ +} + /** * vfs_statx - Get basic and extra attributes by filename * @dfd: A file descriptor representing the base dir for a relative filename @@ -230,11 +260,16 @@ static int vfs_statx(int dfd, struct filename *filename, int flags, goto out; error = vfs_getattr(&path, stat, request_mask, flags); + stat->mnt_id = real_mount(path.mnt)->mnt_id; stat->result_mask |= STATX_MNT_ID; + if (path.mnt->mnt_root == path.dentry) stat->attributes |= STATX_ATTR_MOUNT_ROOT; stat->attributes_mask |= STATX_ATTR_MOUNT_ROOT; + + handle_bdev_dioalign(&path, request_mask, stat); + path_put(&path); if (retry_estale(error, lookup_flags)) { lookup_flags |= LOOKUP_REVAL; -- 2.36.1
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org> To: linux-fsdevel@vger.kernel.org Cc: linux-block@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fscrypt@vger.kernel.org, Keith Busch <kbusch@kernel.org>, linux-ext4@vger.kernel.org Subject: [f2fs-dev] [PATCH v3 2/8] vfs: support STATX_DIOALIGN on block devices Date: Thu, 16 Jun 2022 13:15:00 -0700 [thread overview] Message-ID: <20220616201506.124209-3-ebiggers@kernel.org> (raw) In-Reply-To: <20220616201506.124209-1-ebiggers@kernel.org> From: Eric Biggers <ebiggers@google.com> Add support for STATX_DIOALIGN to block devices, so that direct I/O alignment restrictions are exposed to userspace in a generic way. Note that this breaks the tradition of stat operating only on the block device node, not the block device itself. However, it was felt that doing this is preferable, in order to make the interface useful and avoid needing separate interfaces for regular files and block devices. Signed-off-by: Eric Biggers <ebiggers@google.com> --- fs/stat.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/fs/stat.c b/fs/stat.c index a7930d7444830..c1ce447c1a383 100644 --- a/fs/stat.c +++ b/fs/stat.c @@ -5,6 +5,7 @@ * Copyright (C) 1991, 1992 Linus Torvalds */ +#include <linux/blkdev.h> #include <linux/export.h> #include <linux/mm.h> #include <linux/errno.h> @@ -198,6 +199,35 @@ int getname_statx_lookup_flags(int flags) return lookup_flags; } +/* Handle STATX_DIOALIGN for block devices. */ +static inline void handle_bdev_dioalign(struct path *path, u32 request_mask, + struct kstat *stat) +{ +#ifdef CONFIG_BLOCK + struct inode *inode; + struct block_device *bdev; + unsigned int lbs; + + if (likely(!(request_mask & STATX_DIOALIGN))) + return; + + inode = d_backing_inode(path->dentry); + if (!S_ISBLK(inode->i_mode)) + return; + + bdev = blkdev_get_no_open(inode->i_rdev); + if (!bdev) + return; + + lbs = bdev_logical_block_size(bdev); + stat->dio_mem_align = lbs; + stat->dio_offset_align = lbs; + stat->result_mask |= STATX_DIOALIGN; + + blkdev_put_no_open(bdev); +#endif /* CONFIG_BLOCK */ +} + /** * vfs_statx - Get basic and extra attributes by filename * @dfd: A file descriptor representing the base dir for a relative filename @@ -230,11 +260,16 @@ static int vfs_statx(int dfd, struct filename *filename, int flags, goto out; error = vfs_getattr(&path, stat, request_mask, flags); + stat->mnt_id = real_mount(path.mnt)->mnt_id; stat->result_mask |= STATX_MNT_ID; + if (path.mnt->mnt_root == path.dentry) stat->attributes |= STATX_ATTR_MOUNT_ROOT; stat->attributes_mask |= STATX_ATTR_MOUNT_ROOT; + + handle_bdev_dioalign(&path, request_mask, stat); + path_put(&path); if (retry_estale(error, lookup_flags)) { lookup_flags |= LOOKUP_REVAL; -- 2.36.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-06-16 20:18 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-16 20:14 [PATCH v3 0/8] make statx() return DIO alignment information Eric Biggers 2022-06-16 20:14 ` [f2fs-dev] " Eric Biggers 2022-06-16 20:14 ` [PATCH v3 1/8] statx: add direct I/O " Eric Biggers 2022-06-16 20:14 ` [f2fs-dev] " Eric Biggers 2022-06-19 11:30 ` Avi Kivity 2022-06-19 11:30 ` [f2fs-dev] " Avi Kivity 2022-06-26 7:44 ` Christoph Hellwig 2022-06-26 7:44 ` [f2fs-dev] " Christoph Hellwig 2022-06-26 10:20 ` Avi Kivity 2022-06-26 10:20 ` [f2fs-dev] " Avi Kivity via Linux-f2fs-devel 2022-06-23 15:58 ` Darrick J. Wong 2022-06-23 15:58 ` [f2fs-dev] " Darrick J. Wong 2022-06-23 17:23 ` Eric Biggers 2022-06-23 17:23 ` Eric Biggers 2022-06-23 18:58 ` [f2fs-dev] " Eric Biggers 2022-06-23 18:58 ` Eric Biggers 2022-06-26 8:02 ` Christoph Hellwig 2022-06-26 8:02 ` [f2fs-dev] " Christoph Hellwig 2022-06-26 7:44 ` Christoph Hellwig 2022-06-26 7:44 ` [f2fs-dev] " Christoph Hellwig 2022-06-16 20:15 ` Eric Biggers [this message] 2022-06-16 20:15 ` [f2fs-dev] [PATCH v3 2/8] vfs: support STATX_DIOALIGN on block devices Eric Biggers 2022-06-26 7:48 ` Christoph Hellwig 2022-06-26 7:48 ` [f2fs-dev] " Christoph Hellwig 2022-06-16 20:15 ` [PATCH v3 3/8] fscrypt: change fscrypt_dio_supported() to prepare for STATX_DIOALIGN Eric Biggers 2022-06-16 20:15 ` [f2fs-dev] " Eric Biggers 2022-06-16 20:15 ` [PATCH v3 4/8] ext4: support STATX_DIOALIGN Eric Biggers 2022-06-16 20:15 ` [f2fs-dev] " Eric Biggers 2022-06-16 20:15 ` [PATCH v3 5/8] f2fs: move f2fs_force_buffered_io() into file.c Eric Biggers 2022-06-16 20:15 ` [f2fs-dev] " Eric Biggers 2022-06-16 20:15 ` [PATCH v3 6/8] f2fs: don't allow DIO reads but not DIO writes Eric Biggers 2022-06-16 20:15 ` [f2fs-dev] " Eric Biggers 2022-06-16 20:15 ` [PATCH v3 7/8] f2fs: simplify f2fs_force_buffered_io() Eric Biggers 2022-06-16 20:15 ` [f2fs-dev] " Eric Biggers 2022-06-16 20:15 ` [PATCH v3 8/8] f2fs: support STATX_DIOALIGN Eric Biggers 2022-06-16 20:15 ` [f2fs-dev] " Eric Biggers 2022-07-20 5:03 ` [PATCH v3 0/8] make statx() return DIO alignment information Christoph Hellwig 2022-07-20 5:03 ` [f2fs-dev] " Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220616201506.124209-3-ebiggers@kernel.org \ --to=ebiggers@kernel.org \ --cc=kbusch@kernel.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fscrypt@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-xfs@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.