From: Mike Christie <michael.christie@oracle.com>
To: lduncan@suse.com, cleech@redhat.com, njavali@marvell.com,
mrangankar@marvell.com, GR-QLogic-Storage-Upstream@marvell.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
jejb@linux.ibm.com
Cc: Mike Christie <michael.christie@oracle.com>
Subject: [PATCH 1/6] scsi: iscsi: Fix HW conn removal use after free
Date: Thu, 16 Jun 2022 17:27:33 -0500 [thread overview]
Message-ID: <20220616222738.5722-2-michael.christie@oracle.com> (raw)
In-Reply-To: <20220616222738.5722-1-michael.christie@oracle.com>
If qla4xxx doesn't remove the connection before the session, the iSCSI
class tries to remove the connection for it. We were doing a
iscsi_put_conn() in the iter function which is not needed and will result
in a use after free because iscsi_remove_conn() will free the connection.
Reviewed-by: Lee Duncan <lduncan@suse.com>
Signed-off-by: Mike Christie <michael.christie@oracle.com>
---
drivers/scsi/scsi_transport_iscsi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index 2c0dd64159b0..e6084e158cc0 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -2138,8 +2138,6 @@ static int iscsi_iter_destroy_conn_fn(struct device *dev, void *data)
return 0;
iscsi_remove_conn(iscsi_dev_to_conn(dev));
- iscsi_put_conn(iscsi_dev_to_conn(dev));
-
return 0;
}
--
2.25.1
next prev parent reply other threads:[~2022-06-16 22:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 22:27 [PATCH 0/6] iscsi fixes for 5.19 or 5.20 Mike Christie
2022-06-16 22:27 ` Mike Christie [this message]
2022-06-16 22:27 ` [PATCH 2/6] scsi: iscsi: Allow iscsi_if_stop_conn to be called from kernel Mike Christie
2022-06-16 22:27 ` [PATCH 3/6] scsi: iscsi: Cleanup bound endpoints during shutdown Mike Christie
2022-06-16 22:27 ` [PATCH 4/6] scsi: iscsi: Add helper to remove a session from the kernel Mike Christie
2022-06-16 22:27 ` [PATCH 5/6] scsi: qedi: Use QEDI_MODE_NORMAL for error handling Mike Christie
2022-06-16 22:27 ` [PATCH 6/6] scsi: iscsi: Fix session removal on shutdown Mike Christie
2022-06-17 5:18 ` [EXT] [PATCH 0/6] iscsi fixes for 5.19 or 5.20 Nilesh Javali
2022-06-22 1:15 ` Martin K. Petersen
2022-06-28 3:24 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220616222738.5722-2-michael.christie@oracle.com \
--to=michael.christie@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=cleech@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=lduncan@suse.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mrangankar@marvell.com \
--cc=njavali@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.