All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tianfei Zhang <tianfei.zhang@intel.com>
To: yilun.xu@intel.com, lee.jones@linaro.org
Cc: hao.wu@intel.com, trix@redhat.com, linux-kernel@vger.kernel.org,
	linux-fpga@vger.kernel.org, russell.h.weight@intel.com,
	matthew.gerlach@linux.intel.com,
	Tianfei Zhang <tianfei.zhang@intel.com>
Subject: [PATCH v2 1/4] mfd: intel-m10-bmc: rename the local variables
Date: Thu, 16 Jun 2022 22:04:02 -0400	[thread overview]
Message-ID: <20220617020405.128352-2-tianfei.zhang@intel.com> (raw)
In-Reply-To: <20220617020405.128352-1-tianfei.zhang@intel.com>

It had better use ddata for local variables which
directly interacts with dev_get_drvdata()/dev_set_drvdata().

Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
---
 drivers/mfd/intel-m10-bmc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/mfd/intel-m10-bmc.c b/drivers/mfd/intel-m10-bmc.c
index 8db3bcf5fccc..7e521df29c72 100644
--- a/drivers/mfd/intel-m10-bmc.c
+++ b/drivers/mfd/intel-m10-bmc.c
@@ -86,15 +86,15 @@ static DEVICE_ATTR_RO(bmcfw_version);
 static ssize_t mac_address_show(struct device *dev,
 				struct device_attribute *attr, char *buf)
 {
-	struct intel_m10bmc *max10 = dev_get_drvdata(dev);
+	struct intel_m10bmc *ddata = dev_get_drvdata(dev);
 	unsigned int macaddr_low, macaddr_high;
 	int ret;
 
-	ret = m10bmc_sys_read(max10, M10BMC_MAC_LOW, &macaddr_low);
+	ret = m10bmc_sys_read(ddata, M10BMC_MAC_LOW, &macaddr_low);
 	if (ret)
 		return ret;
 
-	ret = m10bmc_sys_read(max10, M10BMC_MAC_HIGH, &macaddr_high);
+	ret = m10bmc_sys_read(ddata, M10BMC_MAC_HIGH, &macaddr_high);
 	if (ret)
 		return ret;
 
@@ -111,11 +111,11 @@ static DEVICE_ATTR_RO(mac_address);
 static ssize_t mac_count_show(struct device *dev,
 			      struct device_attribute *attr, char *buf)
 {
-	struct intel_m10bmc *max10 = dev_get_drvdata(dev);
+	struct intel_m10bmc *ddata = dev_get_drvdata(dev);
 	unsigned int macaddr_high;
 	int ret;
 
-	ret = m10bmc_sys_read(max10, M10BMC_MAC_HIGH, &macaddr_high);
+	ret = m10bmc_sys_read(ddata, M10BMC_MAC_HIGH, &macaddr_high);
 	if (ret)
 		return ret;
 
-- 
2.26.2


  reply	other threads:[~2022-06-17  2:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-17  2:04 [PATCH v2 0/4] add PMCI driver support Tianfei Zhang
2022-06-17  2:04 ` Tianfei Zhang [this message]
2022-06-27 13:49   ` [PATCH v2 1/4] mfd: intel-m10-bmc: rename the local variables Lee Jones
2022-06-17  2:04 ` [PATCH v2 2/4] mfd: intel-m10-bmc: split into core and spi Tianfei Zhang
2022-06-20  9:58   ` Xu Yilun
2022-06-21  0:56     ` Zhang, Tianfei
2022-06-17  2:04 ` [PATCH v2 3/4] mfd: intel-m10-bmc: add PMCI driver Tianfei Zhang
2022-06-20 11:55   ` Xu Yilun
2022-06-21  1:55     ` Zhang, Tianfei
2022-06-17  2:04 ` [PATCH v2 4/4] mfd: intel-m10-bmc: support multiple register layouts Tianfei Zhang
2022-06-20 14:19   ` Xu Yilun
2022-06-21  2:05     ` Zhang, Tianfei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220617020405.128352-2-tianfei.zhang@intel.com \
    --to=tianfei.zhang@intel.com \
    --cc=hao.wu@intel.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.gerlach@linux.intel.com \
    --cc=russell.h.weight@intel.com \
    --cc=trix@redhat.com \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.