From: Liang He <windhl@126.com>
To: ysato@users.sourceforge.jp, dalias@libc.org
Cc: windhl@126.com, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] sh: sh2: Fix refcount leak bug in smp-j2
Date: Fri, 17 Jun 2022 20:00:40 +0800 [thread overview]
Message-ID: <20220617120040.4047182-1-windhl@126.com> (raw)
In j2_prepare_cpus(), of_find_compatible_node() will return a
node pointer with refcount incremented. We should use of_node_put()
in fail path or when it is not used anymore.
Signed-off-by: Liang He <windhl@126.com>
---
arch/sh/kernel/cpu/sh2/smp-j2.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/sh/kernel/cpu/sh2/smp-j2.c b/arch/sh/kernel/cpu/sh2/smp-j2.c
index d0d5d81455ae..995fb5da6ff3 100644
--- a/arch/sh/kernel/cpu/sh2/smp-j2.c
+++ b/arch/sh/kernel/cpu/sh2/smp-j2.c
@@ -51,6 +51,7 @@ static void j2_prepare_cpus(unsigned int max_cpus)
j2_ipi_irq = irq_of_parse_and_map(np, 0);
j2_ipi_trigger = of_iomap(np, 0);
+ of_node_put(np);
if (!j2_ipi_irq || !j2_ipi_trigger)
goto out;
@@ -59,6 +60,7 @@ static void j2_prepare_cpus(unsigned int max_cpus)
goto out;
sh2_cpuid_addr = of_iomap(np, 0);
+ of_node_put(np);
if (!sh2_cpuid_addr)
goto out;
--
2.25.1
reply other threads:[~2022-06-17 12:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220617120040.4047182-1-windhl@126.com \
--to=windhl@126.com \
--cc=dalias@libc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.