From: Robert Beckett <bob.beckett@collabora.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: kernel@collabora.com,
"Robert Beckett" <bob.beckett@collabora.com>,
"Matthew Auld" <matthew.auld@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v6 04/10] drm/i915/gem: selftest should not attempt mmap of private regions
Date: Fri, 17 Jun 2022 19:05:10 +0000 [thread overview]
Message-ID: <20220617190516.2805572-5-bob.beckett@collabora.com> (raw)
In-Reply-To: <20220617190516.2805572-1-bob.beckett@collabora.com>
During testing make can_mmap consider whether the region is private.
Signed-off-by: Robert Beckett <bob.beckett@collabora.com>
---
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
index 5bc93a1ce3e3..76181e28c75e 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
@@ -869,6 +869,9 @@ static bool can_mmap(struct drm_i915_gem_object *obj, enum i915_mmap_type type)
struct drm_i915_private *i915 = to_i915(obj->base.dev);
bool no_map;
+ if (obj->mm.region && obj->mm.region->private)
+ return false;
+
if (obj->ops->mmap_offset)
return type == I915_MMAP_TYPE_FIXED;
else if (type == I915_MMAP_TYPE_FIXED)
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Robert Beckett <bob.beckett@collabora.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: "Robert Beckett" <bob.beckett@collabora.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
kernel@collabora.com, "Matthew Auld" <matthew.auld@intel.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v6 04/10] drm/i915/gem: selftest should not attempt mmap of private regions
Date: Fri, 17 Jun 2022 19:05:10 +0000 [thread overview]
Message-ID: <20220617190516.2805572-5-bob.beckett@collabora.com> (raw)
In-Reply-To: <20220617190516.2805572-1-bob.beckett@collabora.com>
During testing make can_mmap consider whether the region is private.
Signed-off-by: Robert Beckett <bob.beckett@collabora.com>
---
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
index 5bc93a1ce3e3..76181e28c75e 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
@@ -869,6 +869,9 @@ static bool can_mmap(struct drm_i915_gem_object *obj, enum i915_mmap_type type)
struct drm_i915_private *i915 = to_i915(obj->base.dev);
bool no_map;
+ if (obj->mm.region && obj->mm.region->private)
+ return false;
+
if (obj->ops->mmap_offset)
return type == I915_MMAP_TYPE_FIXED;
else if (type == I915_MMAP_TYPE_FIXED)
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Robert Beckett <bob.beckett@collabora.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
kernel@collabora.com, "Matthew Auld" <matthew.auld@intel.com>,
linux-kernel@vger.kernel.org
Subject: [Intel-gfx] [PATCH v6 04/10] drm/i915/gem: selftest should not attempt mmap of private regions
Date: Fri, 17 Jun 2022 19:05:10 +0000 [thread overview]
Message-ID: <20220617190516.2805572-5-bob.beckett@collabora.com> (raw)
In-Reply-To: <20220617190516.2805572-1-bob.beckett@collabora.com>
During testing make can_mmap consider whether the region is private.
Signed-off-by: Robert Beckett <bob.beckett@collabora.com>
---
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
index 5bc93a1ce3e3..76181e28c75e 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
@@ -869,6 +869,9 @@ static bool can_mmap(struct drm_i915_gem_object *obj, enum i915_mmap_type type)
struct drm_i915_private *i915 = to_i915(obj->base.dev);
bool no_map;
+ if (obj->mm.region && obj->mm.region->private)
+ return false;
+
if (obj->ops->mmap_offset)
return type == I915_MMAP_TYPE_FIXED;
else if (type == I915_MMAP_TYPE_FIXED)
--
2.25.1
next prev parent reply other threads:[~2022-06-17 19:05 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 19:05 [PATCH v6 00/10] drm/i915: ttm for stolen Robert Beckett
2022-06-17 19:05 ` [Intel-gfx] " Robert Beckett
2022-06-17 19:05 ` [PATCH v6 01/10] drm/i915/ttm: dont trample cache_level overrides during ttm move Robert Beckett
2022-06-17 19:05 ` [Intel-gfx] " Robert Beckett
2022-06-17 19:05 ` Robert Beckett
2022-06-17 19:05 ` [PATCH v6 02/10] drm/i915: limit ttm to dma32 for i965G[M] Robert Beckett
2022-06-17 19:05 ` [Intel-gfx] " Robert Beckett
2022-06-17 19:05 ` Robert Beckett
2022-06-17 19:05 ` [PATCH v6 03/10] drm/i915/ttm: only trust snooping for dgfx when deciding default cache_level Robert Beckett
2022-06-17 19:05 ` [Intel-gfx] " Robert Beckett
2022-06-17 19:05 ` Robert Beckett
2022-06-17 19:05 ` Robert Beckett [this message]
2022-06-17 19:05 ` [Intel-gfx] [PATCH v6 04/10] drm/i915/gem: selftest should not attempt mmap of private regions Robert Beckett
2022-06-17 19:05 ` Robert Beckett
2022-06-17 19:05 ` [PATCH v6 05/10] drm/i915: instantiate ttm ranger manager for stolen memory Robert Beckett
2022-06-17 19:05 ` [Intel-gfx] " Robert Beckett
2022-06-17 19:05 ` Robert Beckett
2022-06-17 19:05 ` [PATCH v6 06/10] drm/i915: sanitize mem_flags for stolen buffers Robert Beckett
2022-06-17 19:05 ` [Intel-gfx] " Robert Beckett
2022-06-17 19:05 ` Robert Beckett
2022-06-17 19:05 ` [PATCH v6 07/10] drm/i915: ttm move/clear logic fix Robert Beckett
2022-06-17 19:05 ` [Intel-gfx] " Robert Beckett
2022-06-17 19:05 ` Robert Beckett
2022-06-17 19:05 ` [PATCH v6 08/10] drm/i915: allow memory region creators to alloc and free the region Robert Beckett
2022-06-17 19:05 ` [Intel-gfx] " Robert Beckett
2022-06-17 19:05 ` Robert Beckett
2022-06-17 19:05 ` [PATCH v6 09/10] drm/i915/ttm: add buffer pin on alloc flag Robert Beckett
2022-06-17 19:05 ` [Intel-gfx] " Robert Beckett
2022-06-17 19:05 ` Robert Beckett
2022-06-17 19:05 ` [PATCH v6 10/10] drm/i915: stolen memory use ttm backend Robert Beckett
2022-06-17 19:05 ` [Intel-gfx] " Robert Beckett
2022-06-17 19:05 ` Robert Beckett
2022-06-17 20:20 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: ttm for stolen (rev2) Patchwork
2022-06-17 20:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-06-18 10:40 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220617190516.2805572-5-bob.beckett@collabora.com \
--to=bob.beckett@collabora.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.auld@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.