From: Jean Delvare <jdelvare@suse.de>
To: linux-watchdog@vger.kernel.org
Cc: Terry Bowman <terry.bowman@amd.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH] watchdog: sp5100_tco: Fix a memory leak of EFCH MMIO resource
Date: Tue, 21 Jun 2022 15:28:40 +0200 [thread overview]
Message-ID: <20220621152840.420a0f4c@endymion.delvare> (raw)
Unlike release_mem_region(), a call to release_resource() does not
free the resource, so it has to be freed explicitly to avoid a memory
leak.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: 0578fff4aae5 ("Watchdog: sp5100_tco: Add initialization using EFCH MMIO")
Cc: Terry Bowman <terry.bowman@amd.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: Guenter Roeck <linux@roeck-us.net>
---
drivers/watchdog/sp5100_tco.c | 1 +
1 file changed, 1 insertion(+)
--- linux-5.18.orig/drivers/watchdog/sp5100_tco.c 2022-05-22 21:52:31.000000000 +0200
+++ linux-5.18/drivers/watchdog/sp5100_tco.c 2022-06-21 15:07:31.868814828 +0200
@@ -402,6 +402,7 @@ static int sp5100_tco_setupdevice_mmio(s
iounmap(addr);
release_resource(res);
+ kfree(res);
return ret;
}
--
Jean Delvare
SUSE L3 Support
next reply other threads:[~2022-06-21 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 13:28 Jean Delvare [this message]
2022-06-21 14:08 ` [PATCH] watchdog: sp5100_tco: Fix a memory leak of EFCH MMIO resource Guenter Roeck
2022-06-21 14:10 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220621152840.420a0f4c@endymion.delvare \
--to=jdelvare@suse.de \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=terry.bowman@amd.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.