From: Tomer Maimon <tmaimon77@gmail.com> To: <avifishman70@gmail.com>, <tali.perry1@gmail.com>, <joel@jms.id.au>, <venture@google.com>, <yuenn@google.com>, <benjaminfair@google.com>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <mturquette@baylibre.com>, <sboyd@kernel.org>, <p.zabel@pengutronix.de>, <gregkh@linuxfoundation.org>, <daniel.lezcano@linaro.org>, <tglx@linutronix.de>, <wim@linux-watchdog.org>, <linux@roeck-us.net>, <catalin.marinas@arm.com>, <will@kernel.org>, <arnd@arndb.de>, <olof@lixom.net>, <jirislaby@kernel.org>, <shawnguo@kernel.org>, <bjorn.andersson@linaro.org>, <geert+renesas@glider.be>, <marcel.ziswiler@toradex.com>, <vkoul@kernel.org>, <biju.das.jz@bp.renesas.com>, <nobuhiro1.iwamatsu@toshiba.co.jp>, <robert.hancock@calian.com>, <j.neuschaefer@gmx.net>, <lkundrak@v3.sk> Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>, <linux-serial@vger.kernel.org>, <linux-watchdog@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, Tomer Maimon <tmaimon77@gmail.com> Subject: [PATCH v5 09/18] reset: npcm: using syscon instead of device data Date: Wed, 22 Jun 2022 16:22:53 +0300 [thread overview] Message-ID: <20220622132302.267010-10-tmaimon77@gmail.com> (raw) In-Reply-To: <20220622132302.267010-1-tmaimon77@gmail.com> Using syscon device tree property instead of device data to handle the NPCM general control registers. In case the syscon not found the code still search for nuvoton,npcm750-gcr to support DTS backward compatibility. Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> --- drivers/reset/reset-npcm.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/reset/reset-npcm.c b/drivers/reset/reset-npcm.c index 2ea4d3136e15..431ff2b602c5 100644 --- a/drivers/reset/reset-npcm.c +++ b/drivers/reset/reset-npcm.c @@ -138,8 +138,7 @@ static int npcm_reset_xlate(struct reset_controller_dev *rcdev, } static const struct of_device_id npcm_rc_match[] = { - { .compatible = "nuvoton,npcm750-reset", - .data = (void *)"nuvoton,npcm750-gcr" }, + { .compatible = "nuvoton,npcm750-reset"}, { } }; @@ -155,15 +154,15 @@ static int npcm_usb_reset(struct platform_device *pdev, struct npcm_rc_data *rc) u32 ipsrst1_bits = 0; u32 ipsrst2_bits = NPCM_IPSRST2_USB_HOST; u32 ipsrst3_bits = 0; - const char *gcr_dt; - gcr_dt = (const char *) - of_match_device(dev->driver->of_match_table, dev)->data; - - gcr_regmap = syscon_regmap_lookup_by_compatible(gcr_dt); + gcr_regmap = syscon_regmap_lookup_by_phandle(dev->of_node, "nuvoton,sysgcr"); if (IS_ERR(gcr_regmap)) { - dev_err(&pdev->dev, "Failed to find %s\n", gcr_dt); - return PTR_ERR(gcr_regmap); + dev_warn(&pdev->dev, "Failed to find nuvoton,sysgcr search for nuvoton,npcm750-gcr for Poleg backward compatibility"); + gcr_regmap = syscon_regmap_lookup_by_compatible("nuvoton,npcm750-gcr"); + if (IS_ERR(gcr_regmap)) { + dev_err(&pdev->dev, "Failed to find nuvoton,npcm750-gcr"); + return PTR_ERR(gcr_regmap); + } } /* checking which USB device is enabled */ -- 2.33.0
WARNING: multiple messages have this Message-ID (diff)
From: Tomer Maimon <tmaimon77@gmail.com> To: <avifishman70@gmail.com>, <tali.perry1@gmail.com>, <joel@jms.id.au>, <venture@google.com>, <yuenn@google.com>, <benjaminfair@google.com>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <mturquette@baylibre.com>, <sboyd@kernel.org>, <p.zabel@pengutronix.de>, <gregkh@linuxfoundation.org>, <daniel.lezcano@linaro.org>, <tglx@linutronix.de>, <wim@linux-watchdog.org>, <linux@roeck-us.net>, <catalin.marinas@arm.com>, <will@kernel.org>, <arnd@arndb.de>, <olof@lixom.net>, <jirislaby@kernel.org>, <shawnguo@kernel.org>, <bjorn.andersson@linaro.org>, <geert+renesas@glider.be>, <marcel.ziswiler@toradex.com>, <vkoul@kernel.org>, <biju.das.jz@bp.renesas.com>, <nobuhiro1.iwamatsu@toshiba.co.jp>, <robert.hancock@calian.com>, <j.neuschaefer@gmx.net>, <lkundrak@v3.sk> Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>, <linux-serial@vger.kernel.org>, <linux-watchdog@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, Tomer Maimon <tmaimon77@gmail.com> Subject: [PATCH v5 09/18] reset: npcm: using syscon instead of device data Date: Wed, 22 Jun 2022 16:22:53 +0300 [thread overview] Message-ID: <20220622132302.267010-10-tmaimon77@gmail.com> (raw) In-Reply-To: <20220622132302.267010-1-tmaimon77@gmail.com> Using syscon device tree property instead of device data to handle the NPCM general control registers. In case the syscon not found the code still search for nuvoton,npcm750-gcr to support DTS backward compatibility. Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> --- drivers/reset/reset-npcm.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/reset/reset-npcm.c b/drivers/reset/reset-npcm.c index 2ea4d3136e15..431ff2b602c5 100644 --- a/drivers/reset/reset-npcm.c +++ b/drivers/reset/reset-npcm.c @@ -138,8 +138,7 @@ static int npcm_reset_xlate(struct reset_controller_dev *rcdev, } static const struct of_device_id npcm_rc_match[] = { - { .compatible = "nuvoton,npcm750-reset", - .data = (void *)"nuvoton,npcm750-gcr" }, + { .compatible = "nuvoton,npcm750-reset"}, { } }; @@ -155,15 +154,15 @@ static int npcm_usb_reset(struct platform_device *pdev, struct npcm_rc_data *rc) u32 ipsrst1_bits = 0; u32 ipsrst2_bits = NPCM_IPSRST2_USB_HOST; u32 ipsrst3_bits = 0; - const char *gcr_dt; - gcr_dt = (const char *) - of_match_device(dev->driver->of_match_table, dev)->data; - - gcr_regmap = syscon_regmap_lookup_by_compatible(gcr_dt); + gcr_regmap = syscon_regmap_lookup_by_phandle(dev->of_node, "nuvoton,sysgcr"); if (IS_ERR(gcr_regmap)) { - dev_err(&pdev->dev, "Failed to find %s\n", gcr_dt); - return PTR_ERR(gcr_regmap); + dev_warn(&pdev->dev, "Failed to find nuvoton,sysgcr search for nuvoton,npcm750-gcr for Poleg backward compatibility"); + gcr_regmap = syscon_regmap_lookup_by_compatible("nuvoton,npcm750-gcr"); + if (IS_ERR(gcr_regmap)) { + dev_err(&pdev->dev, "Failed to find nuvoton,npcm750-gcr"); + return PTR_ERR(gcr_regmap); + } } /* checking which USB device is enabled */ -- 2.33.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-22 13:24 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-22 13:22 [PATCH v5 00/18] Introduce Nuvoton Arbel NPCM8XX BMC SoC Tomer Maimon 2022-06-22 13:22 ` Tomer Maimon 2022-06-22 13:22 ` [PATCH v5 01/18] dt-bindings: timer: npcm: Add npcm845 compatible string Tomer Maimon 2022-06-22 13:22 ` Tomer Maimon 2022-06-22 13:22 ` [PATCH v5 02/18] clocksource: timer-npcm7xx: Add NPCM845 timer support Tomer Maimon 2022-06-22 13:22 ` Tomer Maimon 2022-06-23 14:10 ` Arnd Bergmann 2022-06-23 14:10 ` Arnd Bergmann 2022-06-22 13:22 ` [PATCH v5 03/18] dt-bindings: serial: 8250: Add npcm845 compatible string Tomer Maimon 2022-06-22 13:22 ` Tomer Maimon 2022-06-22 13:22 ` [PATCH v5 04/18] dt-bindings: watchdog: npcm: " Tomer Maimon 2022-06-22 13:22 ` Tomer Maimon 2022-06-22 13:22 ` [PATCH v5 05/18] dt-binding: clk: npcm845: Add binding for Nuvoton NPCM8XX Clock Tomer Maimon 2022-06-22 13:22 ` Tomer Maimon 2022-06-23 8:24 ` Krzysztof Kozlowski 2022-06-23 8:24 ` Krzysztof Kozlowski 2022-06-22 13:22 ` [PATCH v5 06/18] clk: npcm8xx: add clock controller Tomer Maimon 2022-06-22 13:22 ` Tomer Maimon 2022-06-22 13:22 ` [PATCH v5 07/18] dt-bindings: reset: npcm: add GCR syscon property Tomer Maimon 2022-06-22 13:22 ` Tomer Maimon 2022-06-22 13:22 ` [PATCH v5 08/18] ARM: dts: nuvoton: add reset " Tomer Maimon 2022-06-22 13:22 ` Tomer Maimon 2022-06-22 13:22 ` Tomer Maimon [this message] 2022-06-22 13:22 ` [PATCH v5 09/18] reset: npcm: using syscon instead of device data Tomer Maimon 2022-06-22 13:22 ` [PATCH v5 10/18] dt-bindings: reset: npcm: Add support for NPCM8XX Tomer Maimon 2022-06-22 13:22 ` Tomer Maimon 2022-06-22 13:22 ` [PATCH v5 11/18] reset: npcm: Add NPCM8XX support Tomer Maimon 2022-06-22 13:22 ` Tomer Maimon 2022-06-22 13:22 ` [PATCH v5 12/18] dt-bindings: arm: npcm: Add maintainer Tomer Maimon 2022-06-22 13:22 ` Tomer Maimon 2022-06-22 13:22 ` [PATCH v5 13/18] dt-bindings: arm: npcm: Add nuvoton,npcm845 compatible string Tomer Maimon 2022-06-22 13:22 ` Tomer Maimon 2022-06-22 13:22 ` [PATCH v5 14/18] dt-bindings: arm: npcm: Add nuvoton,npcm845 GCR " Tomer Maimon 2022-06-22 13:22 ` Tomer Maimon 2022-06-22 13:22 ` [PATCH v5 15/18] arm64: npcm: Add support for Nuvoton NPCM8XX BMC SoC Tomer Maimon 2022-06-22 13:22 ` Tomer Maimon 2022-06-22 13:23 ` [PATCH v5 16/18] arm64: dts: nuvoton: Add initial NPCM8XX device tree Tomer Maimon 2022-06-22 13:23 ` Tomer Maimon 2022-06-22 13:23 ` [PATCH v5 17/18] arm64: dts: nuvoton: Add initial NPCM845 EVB " Tomer Maimon 2022-06-22 13:23 ` Tomer Maimon 2022-06-22 13:23 ` [PATCH v5 18/18] arm64: defconfig: Add Nuvoton NPCM family support Tomer Maimon 2022-06-22 13:23 ` Tomer Maimon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220622132302.267010-10-tmaimon77@gmail.com \ --to=tmaimon77@gmail.com \ --cc=arnd@arndb.de \ --cc=avifishman70@gmail.com \ --cc=benjaminfair@google.com \ --cc=biju.das.jz@bp.renesas.com \ --cc=bjorn.andersson@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=geert+renesas@glider.be \ --cc=gregkh@linuxfoundation.org \ --cc=j.neuschaefer@gmx.net \ --cc=jirislaby@kernel.org \ --cc=joel@jms.id.au \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=lkundrak@v3.sk \ --cc=marcel.ziswiler@toradex.com \ --cc=mturquette@baylibre.com \ --cc=nobuhiro1.iwamatsu@toshiba.co.jp \ --cc=olof@lixom.net \ --cc=p.zabel@pengutronix.de \ --cc=robert.hancock@calian.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=shawnguo@kernel.org \ --cc=tali.perry1@gmail.com \ --cc=tglx@linutronix.de \ --cc=venture@google.com \ --cc=vkoul@kernel.org \ --cc=will@kernel.org \ --cc=wim@linux-watchdog.org \ --cc=yuenn@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.