All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guo Mengqi <guomengqi3@huawei.com>
To: <masahisa.kojima@linaro.org>, <jaswinder.singh@linaro.org>,
	<broonie@kernel.org>, <linux-spi@vger.kernel.org>
Cc: <xuqiang36@huawei.com>, <guomengqi3@huawei.com>
Subject: [PATCH-next] drivers/spi: Add missing clk_disable_unprepare()
Date: Fri, 24 Jun 2022 08:56:14 +0800	[thread overview]
Message-ID: <20220624005614.49434-1-guomengqi3@huawei.com> (raw)

Add missing clk_disable_unprepare() in synquacer_spi_resume().

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Guo Mengqi <guomengqi3@huawei.com>
---
 drivers/spi/spi-synquacer.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-synquacer.c b/drivers/spi/spi-synquacer.c
index ea706d9629cb..47cbe73137c2 100644
--- a/drivers/spi/spi-synquacer.c
+++ b/drivers/spi/spi-synquacer.c
@@ -783,6 +783,7 @@ static int __maybe_unused synquacer_spi_resume(struct device *dev)
 
 		ret = synquacer_spi_enable(master);
 		if (ret) {
+			clk_disable_unprepare(sspi->clk);
 			dev_err(dev, "failed to enable spi (%d)\n", ret);
 			return ret;
 		}
-- 
2.17.1


             reply	other threads:[~2022-06-24  1:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24  0:56 Guo Mengqi [this message]
2022-06-27 12:45 ` [PATCH-next] drivers/spi: Add missing clk_disable_unprepare() Mark Brown
2022-06-28 10:31 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220624005614.49434-1-guomengqi3@huawei.com \
    --to=guomengqi3@huawei.com \
    --cc=broonie@kernel.org \
    --cc=jaswinder.singh@linaro.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=masahisa.kojima@linaro.org \
    --cc=xuqiang36@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.