All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
To: unlisted-recipients:; (no To-header on input)
Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com,
	quentin.schulz@theobroma-systems.com,
	Tommaso Merciai <tommaso.merciai@amarulasolutions.com>,
	Daniel Scally <djrscally@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/7] media: ov5693: count num_supplies using array_size
Date: Sat, 25 Jun 2022 01:03:01 +0200	[thread overview]
Message-ID: <20220624230307.3066530-2-tommaso.merciai@amarulasolutions.com> (raw)
In-Reply-To: <20220624230307.3066530-1-tommaso.merciai@amarulasolutions.com>

Instead of hardcode OV5693_NUM_SUPPLIES in a define is better use
ARRAY_SIZE function to count the number of supplies from
ov5693_supply_names array

Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
---
 drivers/media/i2c/ov5693.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c
index 117ff5403312..f410333c4c67 100644
--- a/drivers/media/i2c/ov5693.c
+++ b/drivers/media/i2c/ov5693.c
@@ -127,11 +127,15 @@
 #define OV5693_LINK_FREQ_419_2MHZ		419200000
 #define OV5693_PIXEL_RATE			167680000
 
-/* Miscellaneous */
-#define OV5693_NUM_SUPPLIES			2
-
 #define to_ov5693_sensor(x) container_of(x, struct ov5693_device, sd)
 
+static const char * const ov5693_supply_names[] = {
+	"avdd",		/* Analog power */
+	"dovdd",	/* Digital I/O power */
+};
+
+#define OV5693_NUM_SUPPLIES	ARRAY_SIZE(ov5693_supply_names)
+
 struct ov5693_reg {
 	u32 reg;
 	u8 val;
@@ -352,11 +356,6 @@ static const s64 link_freq_menu_items[] = {
 	OV5693_LINK_FREQ_419_2MHZ
 };
 
-static const char * const ov5693_supply_names[] = {
-	"avdd",
-	"dovdd",
-};
-
 static const char * const ov5693_test_pattern_menu[] = {
 	"Disabled",
 	"Random Data",
-- 
2.25.1


  reply	other threads:[~2022-06-24 23:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24 23:03 [PATCH 0/7] media: ov5693: cleanup code and add dts support Tommaso Merciai
2022-06-24 23:03 ` Tommaso Merciai [this message]
2022-06-24 23:03 ` [PATCH 2/7] media: ov5693: add dvdd into ov5693_supply_names array Tommaso Merciai
2022-06-24 23:03 ` [PATCH 3/7] media: ov5693: rename clk into xvclk Tommaso Merciai
2022-06-24 23:03 ` [PATCH 4/7] media: ov5693: move hw cfg functions into ov5693_check_hwcfg Tommaso Merciai
2022-06-24 23:03 ` [PATCH 5/7] media: ov5693: rename ov5693_check_hwcfg into ov5693_get_hwcfg Tommaso Merciai
2022-06-24 23:03 ` [PATCH 6/7] media: ov5693: add ov5693_of_match, dts support Tommaso Merciai
2022-06-24 23:03 ` [PATCH 7/7] media: dt-bindings: ov5693: document YAML binding Tommaso Merciai
2022-06-25 20:35   ` Krzysztof Kozlowski
2022-06-27  8:02     ` Tommaso Merciai
2022-06-27 13:31   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220624230307.3066530-2-tommaso.merciai@amarulasolutions.com \
    --to=tommaso.merciai@amarulasolutions.com \
    --cc=djrscally@gmail.com \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linuxfancy@googlegroups.com \
    --cc=mchehab@kernel.org \
    --cc=quentin.schulz@theobroma-systems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.