All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: linux-fbdev@vger.kernel.org, daniel.vetter@ffwll.ch,
	dri-devel@lists.freedesktop.org, deller@gmx.de
Subject: [PATCH v2 4/4] fbmem: Catch possible driver bugs regarding too small virtual screen size
Date: Sat, 25 Jun 2022 14:25:02 +0200	[thread overview]
Message-ID: <20220625122502.68095-5-deller@gmx.de> (raw)
In-Reply-To: <20220625122502.68095-1-deller@gmx.de>

Make sure that we catch, report and fix up fbdev and drm graphic drivers which
got the virtual screen resolution smaller than the physical screen resolution.

Signed-off-by: Helge Deller <deller@gmx.de>
Cc: stable@vger.kernel.org # v5.4+
---
 drivers/video/fbdev/core/fbmem.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
index 50fb66b954d6..6d262e341023 100644
--- a/drivers/video/fbdev/core/fbmem.c
+++ b/drivers/video/fbdev/core/fbmem.c
@@ -1006,6 +1006,12 @@ fb_set_var(struct fb_info *info, struct fb_var_screeninfo *var)
 	if (var->xres < 8 || var->yres < 8)
 		return -EINVAL;

+	/* make sure virtual resolution >= physical resolution */
+	if (WARN_ON(var->xres_virtual < var->xres))
+		var->xres_virtual = var->xres;
+	if (WARN_ON(var->yres_virtual < var->yres))
+		var->yres_virtual = var->yres;
+
 	/* Too huge resolution causes multiplication overflow. */
 	if (check_mul_overflow(var->xres, var->yres, &unused) ||
 	    check_mul_overflow(var->xres_virtual, var->yres_virtual, &unused))
--
2.35.3


  parent reply	other threads:[~2022-06-25 12:25 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-25 12:24 [PATCH v2 0/4] fbcon: Fixes for screen resolution changes Helge Deller
2022-06-25 12:24 ` [PATCH v2 1/4] fbcon: Disallow setting font bigger than screen size Helge Deller
2022-06-25 12:45   ` Daniel Vetter
2022-06-25 12:45     ` Daniel Vetter
2022-06-25 14:53     ` Helge Deller
2022-06-25 14:53       ` Helge Deller
2022-06-25 22:27       ` Daniel Vetter
2022-06-25 22:27         ` Daniel Vetter
2022-06-25 22:32         ` Daniel Vetter
2022-06-25 22:32           ` Daniel Vetter
2022-06-25 12:25 ` [PATCH v2 2/4] fbcon: Add fbcon_modechange_possible() check Helge Deller
2022-06-25 12:55   ` Daniel Vetter
2022-06-25 12:55     ` Daniel Vetter
2022-06-25 15:14     ` Helge Deller
2022-06-25 15:14       ` Helge Deller
2022-06-25 22:31       ` Daniel Vetter
2022-06-25 22:31         ` Daniel Vetter
2022-06-25 12:25 ` [PATCH v2 3/4] fbmem: Fix input parameter checks for user-provided screen resolution changes Helge Deller
2022-06-25 12:56   ` Daniel Vetter
2022-06-25 12:56     ` Daniel Vetter
2022-06-25 13:00     ` Daniel Vetter
2022-06-25 13:00       ` Daniel Vetter
2022-06-25 15:36       ` Helge Deller
2022-06-25 15:36         ` Helge Deller
2022-06-25 15:19     ` Helge Deller
2022-06-25 15:19       ` Helge Deller
2022-06-25 12:25 ` Helge Deller [this message]
2022-06-25 13:03   ` [PATCH v2 4/4] fbmem: Catch possible driver bugs regarding too small virtual screen size Daniel Vetter
2022-06-25 13:03     ` Daniel Vetter
2022-06-25 15:38     ` Helge Deller
2022-06-25 15:38       ` Helge Deller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220625122502.68095-5-deller@gmx.de \
    --to=deller@gmx.de \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.