All of lore.kernel.org
 help / color / mirror / Atom feed
From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: borntraeger@de.ibm.com, frankja@linux.ibm.com, thuth@redhat.com,
	pasic@linux.ibm.com, david@redhat.com,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	scgl@linux.ibm.com, mimu@linux.ibm.com, nrb@linux.ibm.com
Subject: [PATCH v12 06/18] KVM: s390: pv: add export before import
Date: Tue, 28 Jun 2022 15:56:07 +0200	[thread overview]
Message-ID: <20220628135619.32410-7-imbrenda@linux.ibm.com> (raw)
In-Reply-To: <20220628135619.32410-1-imbrenda@linux.ibm.com>

Due to upcoming changes, it will be possible to temporarily have
multiple protected VMs in the same address space, although only one
will be actually active.

In that scenario, it is necessary to perform an export of every page
that is to be imported, since the hardware does not allow a page
belonging to a protected guest to be imported into a different
protected guest.

This also applies to pages that are shared, and thus accessible by the
host.

Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
---
 arch/s390/kernel/uv.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c
index ce14fd0b573c..87b176008785 100644
--- a/arch/s390/kernel/uv.c
+++ b/arch/s390/kernel/uv.c
@@ -234,6 +234,32 @@ static int make_secure_pte(pte_t *ptep, unsigned long addr,
 	return uvcb->rc == 0x10a ? -ENXIO : -EINVAL;
 }
 
+/**
+ * should_export_before_import - Determine whether an export is needed
+ * before an import-like operation
+ * @uvcb: the Ultravisor control block of the UVC to be performed
+ * @mm: the mm of the process
+ *
+ * Returns whether an export is needed before every import-like operation.
+ * This is needed for shared pages, which don't trigger a secure storage
+ * exception when accessed from a different guest.
+ *
+ * Although considered as one, the Unpin Page UVC is not an actual import,
+ * so it is not affected.
+ *
+ * No export is needed also when there is only one protected VM, because the
+ * page cannot belong to the wrong VM in that case (there is no "other VM"
+ * it can belong to).
+ *
+ * Return: true if an export is needed before every import, otherwise false.
+ */
+static bool should_export_before_import(struct uv_cb_header *uvcb, struct mm_struct *mm)
+{
+	if (uvcb->cmd == UVC_CMD_UNPIN_PAGE_SHARED)
+		return false;
+	return atomic_read(&mm->context.protected_count) > 1;
+}
+
 /*
  * Requests the Ultravisor to make a page accessible to a guest.
  * If it's brought in the first time, it will be cleared. If
@@ -277,6 +303,8 @@ int gmap_make_secure(struct gmap *gmap, unsigned long gaddr, void *uvcb)
 
 	lock_page(page);
 	ptep = get_locked_pte(gmap->mm, uaddr, &ptelock);
+	if (should_export_before_import(uvcb, gmap->mm))
+		uv_convert_from_secure(page_to_phys(page));
 	rc = make_secure_pte(ptep, uaddr, page, uvcb);
 	pte_unmap_unlock(ptep, ptelock);
 	unlock_page(page);
-- 
2.36.1


  parent reply	other threads:[~2022-06-28 13:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-28 13:56 [PATCH v12 00/18] KVM: s390: pv: implement lazy destroy for reboot Claudio Imbrenda
2022-06-28 13:56 ` [PATCH v12 01/18] KVM: s390: pv: leak the topmost page table when destroy fails Claudio Imbrenda
2022-06-28 13:56 ` [PATCH v12 02/18] KVM: s390: pv: handle secure storage violations for protected guests Claudio Imbrenda
2022-06-28 13:56 ` [PATCH v12 03/18] KVM: s390: pv: handle secure storage exceptions for normal guests Claudio Imbrenda
2022-06-28 13:56 ` [PATCH v12 04/18] KVM: s390: pv: refactor s390_reset_acc Claudio Imbrenda
2022-06-28 13:56 ` [PATCH v12 05/18] KVM: s390: pv: usage counter instead of flag Claudio Imbrenda
2022-06-28 13:56 ` Claudio Imbrenda [this message]
2022-06-28 13:56 ` [PATCH v12 07/18] KVM: s390: pv: clear the state without memset Claudio Imbrenda
2022-06-28 13:56 ` [PATCH v12 08/18] KVM: s390: pv: Add kvm_s390_cpus_from_pv to kvm-s390.h and add documentation Claudio Imbrenda
2022-06-28 13:56 ` [PATCH v12 09/18] KVM: s390: pv: add mmu_notifier Claudio Imbrenda
2022-06-28 13:56 ` [PATCH v12 10/18] s390/mm: KVM: pv: when tearing down, try to destroy protected pages Claudio Imbrenda
2022-06-28 13:56 ` [PATCH v12 11/18] KVM: s390: pv: refactoring of kvm_s390_pv_deinit_vm Claudio Imbrenda
2022-06-28 13:56 ` [PATCH v12 12/18] KVM: s390: pv: destroy the configuration before its memory Claudio Imbrenda
2022-06-28 13:56 ` [PATCH v12 13/18] KVM: s390: pv: asynchronous destroy for reboot Claudio Imbrenda
2022-06-28 13:56 ` [PATCH v12 14/18] KVM: s390: pv: api documentation for asynchronous destroy Claudio Imbrenda
2022-06-28 13:56 ` [PATCH v12 15/18] KVM: s390: pv: add KVM_CAP_S390_PROTECTED_ASYNC_DISABLE Claudio Imbrenda
2022-06-28 13:56 ` [PATCH v12 16/18] KVM: s390: pv: avoid export before import if possible Claudio Imbrenda
2022-06-28 13:56 ` [PATCH v12 17/18] KVM: s390: pv: support for Destroy fast UVC Claudio Imbrenda
2022-06-28 13:56 ` [PATCH v12 18/18] KVM: s390: pv: module parameter to fence asynchronous destroy Claudio Imbrenda
2022-07-14  6:59 ` [PATCH v12 00/18] KVM: s390: pv: implement lazy destroy for reboot Janosch Frank
2022-07-14  9:17   ` Claudio Imbrenda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220628135619.32410-7-imbrenda@linux.ibm.com \
    --to=imbrenda@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mimu@linux.ibm.com \
    --cc=nrb@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=scgl@linux.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.