From: Claudiu Beznea <claudiu.beznea@microchip.com> To: <eugen.hristev@microchip.com>, <jic23@kernel.org>, <lars@metafoo.de>, <nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>, <claudiu.beznea@microchip.com>, <robh+dt@kernel.org>, <krzk+dt@kernel.org> Cc: <linux-iio@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org> Subject: [PATCH v2 05/19] iio: adc: at91-sama5d2_adc: exit from write_raw() when buffers are enabled Date: Tue, 28 Jun 2022 18:16:17 +0300 [thread overview] Message-ID: <20220628151631.3116454-6-claudiu.beznea@microchip.com> (raw) In-Reply-To: <20220628151631.3116454-1-claudiu.beznea@microchip.com> When buffers are enabled conversion may start asynchronously thus allowing changes on actual hardware could lead to bad behavior. Thus do not allow changing oversampling ratio and sample frequency when if iio_device_claim_direct_mode() returns with error. Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> --- drivers/iio/adc/at91-sama5d2_adc.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c index 2c087d52f164..cd2b8190a8da 100644 --- a/drivers/iio/adc/at91-sama5d2_adc.c +++ b/drivers/iio/adc/at91-sama5d2_adc.c @@ -1641,6 +1641,7 @@ static int at91_adc_write_raw(struct iio_dev *indio_dev, int val, int val2, long mask) { struct at91_adc_state *st = iio_priv(indio_dev); + int ret; switch (mask) { case IIO_CHAN_INFO_OVERSAMPLING_RATIO: @@ -1650,20 +1651,29 @@ static int at91_adc_write_raw(struct iio_dev *indio_dev, /* if no change, optimize out */ if (val == st->oversampling_ratio) return 0; + + ret = iio_device_claim_direct_mode(indio_dev); + if (ret) + return ret; mutex_lock(&st->lock); st->oversampling_ratio = val; /* update ratio */ at91_adc_config_emr(st); mutex_unlock(&st->lock); + iio_device_release_direct_mode(indio_dev); return 0; case IIO_CHAN_INFO_SAMP_FREQ: if (val < st->soc_info.min_sample_rate || val > st->soc_info.max_sample_rate) return -EINVAL; + ret = iio_device_claim_direct_mode(indio_dev); + if (ret) + return ret; mutex_lock(&st->lock); at91_adc_setup_samp_freq(indio_dev, val); mutex_unlock(&st->lock); + iio_device_release_direct_mode(indio_dev); return 0; default: return -EINVAL; -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Claudiu Beznea <claudiu.beznea@microchip.com> To: <eugen.hristev@microchip.com>, <jic23@kernel.org>, <lars@metafoo.de>, <nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>, <claudiu.beznea@microchip.com>, <robh+dt@kernel.org>, <krzk+dt@kernel.org> Cc: <linux-iio@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org> Subject: [PATCH v2 05/19] iio: adc: at91-sama5d2_adc: exit from write_raw() when buffers are enabled Date: Tue, 28 Jun 2022 18:16:17 +0300 [thread overview] Message-ID: <20220628151631.3116454-6-claudiu.beznea@microchip.com> (raw) In-Reply-To: <20220628151631.3116454-1-claudiu.beznea@microchip.com> When buffers are enabled conversion may start asynchronously thus allowing changes on actual hardware could lead to bad behavior. Thus do not allow changing oversampling ratio and sample frequency when if iio_device_claim_direct_mode() returns with error. Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> --- drivers/iio/adc/at91-sama5d2_adc.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c index 2c087d52f164..cd2b8190a8da 100644 --- a/drivers/iio/adc/at91-sama5d2_adc.c +++ b/drivers/iio/adc/at91-sama5d2_adc.c @@ -1641,6 +1641,7 @@ static int at91_adc_write_raw(struct iio_dev *indio_dev, int val, int val2, long mask) { struct at91_adc_state *st = iio_priv(indio_dev); + int ret; switch (mask) { case IIO_CHAN_INFO_OVERSAMPLING_RATIO: @@ -1650,20 +1651,29 @@ static int at91_adc_write_raw(struct iio_dev *indio_dev, /* if no change, optimize out */ if (val == st->oversampling_ratio) return 0; + + ret = iio_device_claim_direct_mode(indio_dev); + if (ret) + return ret; mutex_lock(&st->lock); st->oversampling_ratio = val; /* update ratio */ at91_adc_config_emr(st); mutex_unlock(&st->lock); + iio_device_release_direct_mode(indio_dev); return 0; case IIO_CHAN_INFO_SAMP_FREQ: if (val < st->soc_info.min_sample_rate || val > st->soc_info.max_sample_rate) return -EINVAL; + ret = iio_device_claim_direct_mode(indio_dev); + if (ret) + return ret; mutex_lock(&st->lock); at91_adc_setup_samp_freq(indio_dev, val); mutex_unlock(&st->lock); + iio_device_release_direct_mode(indio_dev); return 0; default: return -EINVAL; -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-28 15:15 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-28 15:16 [PATCH v2 00/19] iio: adc: at91-sama5d2_adc: add support for temperature sensor Claudiu Beznea 2022-06-28 15:16 ` Claudiu Beznea 2022-06-28 15:16 ` [PATCH v2 01/19] iio: adc: at91-sama5d2_adc: fix AT91_SAMA5D2_MR_TRACKTIM_MAX Claudiu Beznea 2022-06-28 15:16 ` Claudiu Beznea 2022-06-28 15:16 ` [PATCH v2 02/19] iio: adc: at91-sama5d2_adc: check return status for pressure and touch Claudiu Beznea 2022-06-28 15:16 ` Claudiu Beznea 2022-07-16 16:25 ` Jonathan Cameron 2022-07-16 16:25 ` Jonathan Cameron 2022-07-16 16:26 ` Jonathan Cameron 2022-07-16 16:26 ` Jonathan Cameron 2022-06-28 15:16 ` [PATCH v2 03/19] iio: adc: at91-sama5d2_adc: lock around oversampling and sample freq Claudiu Beznea 2022-06-28 15:16 ` Claudiu Beznea 2022-06-28 15:16 ` [PATCH v2 04/19] iio: adc: at91-sama5d2_adc: disable/prepare buffer on suspend/resume Claudiu Beznea 2022-06-28 15:16 ` Claudiu Beznea 2022-06-28 15:16 ` Claudiu Beznea [this message] 2022-06-28 15:16 ` [PATCH v2 05/19] iio: adc: at91-sama5d2_adc: exit from write_raw() when buffers are enabled Claudiu Beznea 2022-06-28 15:16 ` [PATCH v2 06/19] iio: adc: at91-sama5d2_adc: handle different EMR.OSR for different hw versions Claudiu Beznea 2022-06-28 15:16 ` Claudiu Beznea 2022-06-28 15:16 ` [PATCH v2 07/19] iio: adc: at91-sama5d2_adc: move the check of oversampling in its function Claudiu Beznea 2022-06-28 15:16 ` Claudiu Beznea 2022-06-28 15:16 ` [PATCH v2 08/19] iio: adc: at91-sama5d2_adc: drop AT91_OSR_XSAMPLES defines Claudiu Beznea 2022-06-28 15:16 ` Claudiu Beznea 2022-06-28 15:16 ` [PATCH v2 09/19] iio: adc: at91-sama5d2_adc: add .read_avail() chan_info ops Claudiu Beznea 2022-06-28 15:16 ` Claudiu Beznea 2022-06-28 15:16 ` [PATCH v2 10/19] iio: adc: at91-sama5d2_adc: adjust osr based on specific platform data Claudiu Beznea 2022-06-28 15:16 ` Claudiu Beznea 2022-06-28 15:16 ` [PATCH v2 11/19] iio: adc: at91-sama5d2_adc: add 64 and 256 oversampling ratio Claudiu Beznea 2022-06-28 15:16 ` Claudiu Beznea 2022-06-28 15:16 ` [PATCH v2 12/19] iio: adc: at91-sama5d2_adc: move oversampling storage in its function Claudiu Beznea 2022-06-28 15:16 ` Claudiu Beznea 2022-06-28 15:16 ` [PATCH v2 13/19] iio: adc: at91-sama5d2_adc: update trackx on emr Claudiu Beznea 2022-06-28 15:16 ` Claudiu Beznea 2022-06-28 15:16 ` [PATCH v2 14/19] iio: adc: at91-sama5d2_adc: add startup and tracktim as parameter for at91_adc_setup_samp_freq() Claudiu Beznea 2022-06-28 15:16 ` Claudiu Beznea 2022-06-28 15:16 ` [PATCH v2 15/19] iio: adc: at91-sama5d2_adc: lock around at91_adc_read_info_raw() Claudiu Beznea 2022-06-28 15:16 ` Claudiu Beznea 2022-06-28 15:16 ` [PATCH v2 16/19] dt-bindings: iio: adc: at91-sama5d2_adc: add id for temperature channel Claudiu Beznea 2022-06-28 15:16 ` Claudiu Beznea 2022-06-28 15:16 ` [PATCH v2 17/19] iio: adc: at91-sama5d2_adc: add support for temperature sensor Claudiu Beznea 2022-06-28 15:16 ` Claudiu Beznea 2022-07-16 16:35 ` Jonathan Cameron 2022-07-16 16:35 ` Jonathan Cameron 2022-06-28 15:16 ` [PATCH v2 18/19] iio: adc: at91-sama5d2_adc: add empty line after functions Claudiu Beznea 2022-06-28 15:16 ` Claudiu Beznea 2022-06-28 15:16 ` [PATCH v2 19/19] iio: adc: at91-sama5d2_adc: add runtime pm support Claudiu Beznea 2022-06-28 15:16 ` Claudiu Beznea 2022-07-31 20:11 ` Jonathan Cameron 2022-07-31 20:11 ` Jonathan Cameron 2022-08-01 9:44 ` Claudiu.Beznea 2022-08-01 9:44 ` Claudiu.Beznea 2022-07-16 16:42 ` [PATCH v2 00/19] iio: adc: at91-sama5d2_adc: add support for temperature sensor Jonathan Cameron 2022-07-16 16:42 ` Jonathan Cameron 2022-07-31 20:13 ` Jonathan Cameron 2022-07-31 20:13 ` Jonathan Cameron 2022-08-01 9:46 ` Claudiu.Beznea 2022-08-01 9:46 ` Claudiu.Beznea 2022-08-03 10:30 ` Claudiu.Beznea 2022-08-03 10:30 ` Claudiu.Beznea
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220628151631.3116454-6-claudiu.beznea@microchip.com \ --to=claudiu.beznea@microchip.com \ --cc=alexandre.belloni@bootlin.com \ --cc=devicetree@vger.kernel.org \ --cc=eugen.hristev@microchip.com \ --cc=jic23@kernel.org \ --cc=krzk+dt@kernel.org \ --cc=lars@metafoo.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nicolas.ferre@microchip.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.