All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Eugenio Pérez" <eperezma@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Peter Xu" <peterx@redhat.com>,
	"Laurent Vivier" <laurent@vivier.eu>
Subject: [PULL 03/11] util: Return void on iova_tree_remove
Date: Wed, 29 Jun 2022 11:08:41 +0200	[thread overview]
Message-ID: <20220629090849.1350227-4-laurent@vivier.eu> (raw)
In-Reply-To: <20220629090849.1350227-1-laurent@vivier.eu>

From: Eugenio Pérez <eperezma@redhat.com>

It always returns IOVA_OK so nobody uses it.

Acked-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Message-Id: <20220427154931.3166388-1-eperezma@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 include/qemu/iova-tree.h | 4 +---
 util/iova-tree.c         | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/include/qemu/iova-tree.h b/include/qemu/iova-tree.h
index c938fb07933a..16bbfdf5f8d7 100644
--- a/include/qemu/iova-tree.h
+++ b/include/qemu/iova-tree.h
@@ -72,10 +72,8 @@ int iova_tree_insert(IOVATree *tree, const DMAMap *map);
  * provided.  The range does not need to be exactly what has inserted,
  * all the mappings that are included in the provided range will be
  * removed from the tree.  Here map->translated_addr is meaningless.
- *
- * Return: 0 if succeeded, or <0 if error.
  */
-int iova_tree_remove(IOVATree *tree, const DMAMap *map);
+void iova_tree_remove(IOVATree *tree, const DMAMap *map);
 
 /**
  * iova_tree_find:
diff --git a/util/iova-tree.c b/util/iova-tree.c
index 6dff29c1f62d..fee530a57919 100644
--- a/util/iova-tree.c
+++ b/util/iova-tree.c
@@ -164,15 +164,13 @@ void iova_tree_foreach(IOVATree *tree, iova_tree_iterator iterator)
     g_tree_foreach(tree->tree, iova_tree_traverse, iterator);
 }
 
-int iova_tree_remove(IOVATree *tree, const DMAMap *map)
+void iova_tree_remove(IOVATree *tree, const DMAMap *map)
 {
     const DMAMap *overlap;
 
     while ((overlap = iova_tree_find(tree, map))) {
         g_tree_remove(tree->tree, overlap);
     }
-
-    return IOVA_OK;
 }
 
 /**
-- 
2.36.1



  parent reply	other threads:[~2022-06-29  9:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-29  9:08 [PULL 00/11] Trivial branch for 7.1 patches Laurent Vivier
2022-06-29  9:08 ` [PULL 01/11] vga: avoid crash if no default vga card Laurent Vivier
2022-06-29  9:08 ` [PULL 02/11] qom/object: Remove circular include dependency Laurent Vivier
2022-06-29  9:08 ` Laurent Vivier [this message]
2022-06-29  9:08 ` [PULL 04/11] Trivial: 3 char repeat typos Laurent Vivier
2022-06-29  9:08 ` [PULL 05/11] trivial typos: namesapce Laurent Vivier
2022-06-29  9:08 ` [PULL 06/11] MAINTAINERS: Add softmmu/runstate.c to "Main loop" Laurent Vivier
2022-06-29  9:08 ` [PULL 07/11] hw/pci-host/i440fx: Remove unused parameter from i440fx_init() Laurent Vivier
2022-06-29  9:08 ` [PULL 08/11] common-user: Only compile the common user code if have_user is set Laurent Vivier
2022-06-29  9:08 ` [PULL 09/11] hw/ide/atapi.c: Correct typos (CD-CDROM -> CD-ROM) Laurent Vivier
2022-06-29  9:08 ` [PULL 10/11] hw/i386/xen/xen-hvm: Allow for stubbing xen_set_pci_link_route() Laurent Vivier
2022-06-29  9:08 ` [PULL 11/11] hw/i386/xen/xen-hvm: Inline xen_piix_pci_write_config_client() and remove it Laurent Vivier
2022-06-30  0:53 ` [PULL 00/11] Trivial branch for 7.1 patches Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220629090849.1350227-4-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.