All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Maxime Ripard <maxime@cerno.tech>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>
Cc: Sam Ravnborg <sam@ravnborg.org>, dri-devel@lists.freedesktop.org
Subject: [PATCH v3 11/71] drm/bridge: panel: Introduce drmm_of_get_bridge
Date: Wed, 29 Jun 2022 14:34:10 +0200	[thread overview]
Message-ID: <20220629123510.1915022-12-maxime@cerno.tech> (raw)
In-Reply-To: <20220629123510.1915022-1-maxime@cerno.tech>

Unlike what can be found for other DRM entities, we don't have a
DRM-managed function equivalent to devm_drm_of_get_bridge().

Let's create it.

Acked-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 drivers/gpu/drm/bridge/panel.c | 35 ++++++++++++++++++++++++++++++++++
 include/drm/drm_bridge.h       |  2 ++
 2 files changed, 37 insertions(+)

diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index 56ac51b257b9..ec5304e9fb17 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -459,4 +459,39 @@ struct drm_bridge *devm_drm_of_get_bridge(struct device *dev,
 	return bridge;
 }
 EXPORT_SYMBOL(devm_drm_of_get_bridge);
+
+/**
+ * drmm_of_get_bridge - Return next bridge in the chain
+ * @dev: device to tie the bridge lifetime to
+ * @np: device tree node containing encoder output ports
+ * @port: port in the device tree node
+ * @endpoint: endpoint in the device tree node
+ *
+ * Given a DT node's port and endpoint number, finds the connected node
+ * and returns the associated bridge if any, or creates and returns a
+ * drm panel bridge instance if a panel is connected.
+ *
+ * Returns a drmm managed pointer to the bridge if successful, or an error
+ * pointer otherwise.
+ */
+struct drm_bridge *drmm_of_get_bridge(struct drm_device *drm,
+					  struct device_node *np,
+					  u32 port, u32 endpoint)
+{
+	struct drm_bridge *bridge;
+	struct drm_panel *panel;
+	int ret;
+
+	ret = drm_of_find_panel_or_bridge(np, port, endpoint,
+					  &panel, &bridge);
+	if (ret)
+		return ERR_PTR(ret);
+
+	if (panel)
+		bridge = drmm_panel_bridge_add(drm, panel);
+
+	return bridge;
+}
+EXPORT_SYMBOL(drmm_of_get_bridge);
+
 #endif
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
index e37a419ac2b4..dba5d81e3b4a 100644
--- a/include/drm/drm_bridge.h
+++ b/include/drm/drm_bridge.h
@@ -949,6 +949,8 @@ static inline int drm_panel_bridge_set_orientation(struct drm_connector *connect
 #if defined(CONFIG_OF) && defined(CONFIG_DRM_PANEL_BRIDGE)
 struct drm_bridge *devm_drm_of_get_bridge(struct device *dev, struct device_node *node,
 					  u32 port, u32 endpoint);
+struct drm_bridge *drmm_of_get_bridge(struct drm_device *drm, struct device_node *node,
+					  u32 port, u32 endpoint);
 #else
 static inline struct drm_bridge *devm_drm_of_get_bridge(struct device *dev,
 							struct device_node *node,
-- 
2.36.1


  parent reply	other threads:[~2022-06-29 12:35 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-29 12:33 [PATCH v3 00/71] drm/vc4: Fix hotplug for vc4 Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 01/71] drm/mipi-dsi: Detach devices when removing the host Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 02/71] drm/crtc: Introduce drmm_crtc_init_with_planes Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 03/71] drm/encoder: Introduce drmm_encoder_init Maxime Ripard
2022-06-29 13:32   ` Philipp Zabel
2022-06-29 14:41     ` Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 04/71] drm/connector: Reorder headers Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 05/71] drm/connector: Mention the cleanup after drm_connector_init Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 06/71] drm/connector: Clarify when drm_connector_unregister is needed Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 07/71] drm/connector: Consolidate Connector Initialization Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 08/71] drm/connector: Check for destroy implementation Maxime Ripard
2022-06-29 13:04   ` Jani Nikula
2022-06-29 12:34 ` [PATCH v3 09/71] drm/connector: Introduce drmm_connector_init Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 10/71] drm/bridge: panel: Introduce drmm_panel_bridge_add Maxime Ripard
2022-06-29 12:34 ` Maxime Ripard [this message]
2022-06-29 12:34 ` [PATCH v3 12/71] drm/vc4: drv: Call component_unbind_all() Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 13/71] drm/vc4: drv: Use drm_dev_unplug Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 14/71] drm/vc4: crtc: Create vblank reporting function Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 15/71] drm/vc4: hvs: Protect device resources after removal Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 16/71] drm/vc4: hvs: Remove planes currently allocated before taking down Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 17/71] drm/vc4: plane: Take possible_crtcs as an argument Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 18/71] drm/vc4: crtc: Remove manual plane removal on error Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 19/71] drm/vc4: plane: Switch to drmm_universal_plane_alloc() Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 20/71] drm/vc4: crtc: Move debugfs_name to crtc_data Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 21/71] drm/vc4: crtc: Switch to drmm_kzalloc Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 22/71] drm/vc4: crtc: Switch to DRM-managed CRTC initialization Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 23/71] drm/vc4: dpi: Remove vc4_dev dpi pointer Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 24/71] drm/vc4: dpi: Embed DRM structures into the private structure Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 25/71] drm/vc4: dpi: Switch to drmm_kzalloc Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 26/71] drm/vc4: dpi: Return an error if we can't enable our clock Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 27/71] drm/vc4: dpi: Remove unnecessary drm_of_panel_bridge_remove call Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 28/71] drm/vc4: dpi: Add action to disable the clock Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 29/71] drm/vc4: dpi: Switch to DRM-managed encoder initialization Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 30/71] drm/vc4: dpi: Switch to drmm_of_get_bridge Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 31/71] drm/vc4: dpi: Protect device resources Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 32/71] drm/vc4: dsi: Embed DRM structures into the private structure Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 33/71] drm/vc4: dsi: Switch to DRM-managed encoder initialization Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 34/71] drm/vc4: dsi: Switch to drmm_of_get_bridge Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 35/71] drm/vc4: dsi: Fix the driver structure lifetime Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 36/71] drm/vc4: dsi: Switch to devm_pm_runtime_enable Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 37/71] drm/vc4: hdmi: Depends on CONFIG_PM Maxime Ripard
2022-07-08  9:42   ` (subset) " Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 38/71] drm/vc4: hdmi: Rework power up Maxime Ripard
2022-07-08  9:42   ` (subset) " Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 39/71] drm/vc4: hdmi: Switch to drmm_kzalloc Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 40/71] drm/vc4: hdmi: Remove call to drm_connector_unregister() Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 41/71] drm/vc4: hdmi: Switch to DRM-managed encoder initialization Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 42/71] drm/vc4: hdmi: Switch to DRM-managed connector initialization Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 43/71] drm/vc4: hdmi: Switch to device-managed ALSA initialization Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 44/71] drm/vc4: hdmi: Switch to device-managed CEC initialization Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 45/71] drm/vc4: hdmi: Use a device-managed action for DDC Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 46/71] drm/vc4: hdmi: Switch to DRM-managed kfree to build regsets Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 47/71] drm/vc4: hdmi: Use devm to register hotplug interrupts Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 48/71] drm/vc4: hdmi: Move audio structure offset checks Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 49/71] drm/vc4: hdmi: Protect device resources after removal Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 50/71] drm/vc4: hdmi: Switch to devm_pm_runtime_enable Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 51/71] drm/vc4: txp: Remove vc4_dev txp pointer Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 52/71] drm/vc4: txp: Remove duplicate regset Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 53/71] drm/vc4: txp: Switch to drmm_kzalloc Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 54/71] drm/vc4: txp: Remove call to drm_connector_unregister() Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 55/71] drm/vc4: txp: Protect device resources Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 56/71] drm/vc4: vec: Remove vc4_dev vec pointer Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 57/71] drm/vc4: vec: Embed DRM structures into the private structure Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 58/71] drm/vc4: vec: Switch to drmm_kzalloc Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 59/71] drm/vc4: vec: Remove call to drm_connector_unregister() Maxime Ripard
2022-06-29 12:34 ` [PATCH v3 60/71] drm/vc4: vec: Switch to DRM-managed encoder initialization Maxime Ripard
2022-06-29 12:35 ` [PATCH v3 61/71] drm/vc4: vec: Switch to DRM-managed connector initialization Maxime Ripard
2022-06-29 12:35 ` [PATCH v3 62/71] drm/vc4: vec: Protect device resources after removal Maxime Ripard
2022-06-29 12:35 ` [PATCH v3 63/71] drm/vc4: vec: Switch to devm_pm_runtime_enable Maxime Ripard
2022-06-29 12:35 ` [PATCH v3 64/71] drm/vc4: debugfs: Protect device resources Maxime Ripard
2022-06-29 12:35 ` [PATCH v3 65/71] drm/vc4: debugfs: Return an error on failure Maxime Ripard
2022-06-29 12:35 ` [PATCH v3 66/71] drm/vc4: debugfs: Simplify debugfs registration Maxime Ripard
2022-06-29 12:35 ` [PATCH v3 67/71] drm/vc4: Switch to drmm_mutex_init Maxime Ripard
2022-06-29 12:35 ` [PATCH v3 68/71] drm/vc4: perfmon: Add missing mutex_destroy Maxime Ripard
2022-06-29 12:35 ` [PATCH v3 69/71] drm/vc4: v3d: Stop disabling interrupts Maxime Ripard
2022-06-29 12:35 ` [PATCH v3 70/71] drm/vc4: v3d: Rework the runtime_pm setup Maxime Ripard
2022-06-29 12:35 ` [PATCH v3 71/71] drm/vc4: v3d: Switch to devm_pm_runtime_enable Maxime Ripard
2022-07-07  6:48 ` [PATCH v3 00/71] drm/vc4: Fix hotplug for vc4 Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220629123510.1915022-12-maxime@cerno.tech \
    --to=maxime@cerno.tech \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=sam@ravnborg.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.