All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, clg@kaod.org,
	Daniel Henrique Barboza <danielhb413@gmail.com>
Subject: [PATCH 4/9] target/ppc: use g_autofree in kvmppc_read_int_cpu_dt()
Date: Thu, 30 Jun 2022 16:42:44 -0300	[thread overview]
Message-ID: <20220630194249.886747-5-danielhb413@gmail.com> (raw)
In-Reply-To: <20220630194249.886747-1-danielhb413@gmail.com>

This spares us a g_free() call. Let's also not use 'val' and return the
value of kvmppc_read_int_dt() directly.

Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
 target/ppc/kvm.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
index 7611e9ccf6..c218380eb7 100644
--- a/target/ppc/kvm.c
+++ b/target/ppc/kvm.c
@@ -1932,8 +1932,8 @@ static uint64_t kvmppc_read_int_dt(const char *filename, Error **errp)
  */
 static uint64_t kvmppc_read_int_cpu_dt(const char *propname, Error **errp)
 {
-    char buf[PATH_MAX], *tmp;
-    uint64_t val;
+    g_autofree char *tmp = NULL;
+    char buf[PATH_MAX];
 
     if (kvmppc_find_cpu_dt(buf, sizeof(buf))) {
         error_setg(errp, "Failed to read CPU property %s", propname);
@@ -1941,10 +1941,8 @@ static uint64_t kvmppc_read_int_cpu_dt(const char *propname, Error **errp)
     }
 
     tmp = g_strdup_printf("%s/%s", buf, propname);
-    val = kvmppc_read_int_dt(tmp, errp);
-    g_free(tmp);
 
-    return val;
+    return kvmppc_read_int_dt(tmp, errp);
 }
 
 uint64_t kvmppc_get_clockfreq(void)
-- 
2.36.1



  parent reply	other threads:[~2022-06-30 19:51 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-30 19:42 [PATCH 0/9] cleanup error handling in kvmppc_read_int_cpu_dt() Daniel Henrique Barboza
2022-06-30 19:42 ` [PATCH 1/9] target/ppc/kvm.c: do not return -1 on uint64_t return Daniel Henrique Barboza
2022-06-30 19:42 ` [PATCH 2/9] target/ppc: add errp to kvmppc_read_int_cpu_dt() Daniel Henrique Barboza
2022-07-02  6:24   ` Cédric Le Goater
2022-07-02 13:34     ` Daniel Henrique Barboza
2022-07-04 17:34       ` Cédric Le Goater
2022-07-04 23:19         ` Daniel Henrique Barboza
2022-07-05  6:51         ` Mark Cave-Ayland
2022-07-05  6:57           ` Cédric Le Goater
2022-07-06  7:45             ` Cédric Le Goater
2022-07-11  7:37               ` Mark Cave-Ayland
2022-07-11  7:42                 ` Cédric Le Goater
2022-07-12 12:11                   ` Mark Cave-Ayland
2022-07-12 14:54                     ` BALATON Zoltan
2022-07-13 20:30                       ` Mark Cave-Ayland
2022-07-11 12:05                 ` BALATON Zoltan
2022-07-05  9:39           ` Daniel Henrique Barboza
2022-07-05  9:44             ` Mark Cave-Ayland
2022-07-05  9:51               ` Daniel Henrique Barboza
2022-07-05  9:44             ` Cédric Le Goater
2022-06-30 19:42 ` [PATCH 3/9] target/ppc: Add error reporting when opening file fails Daniel Henrique Barboza
2022-07-02  6:24   ` Cédric Le Goater
2022-06-30 19:42 ` Daniel Henrique Barboza [this message]
2022-07-02  6:20   ` [PATCH 4/9] target/ppc: use g_autofree in kvmppc_read_int_cpu_dt() Cédric Le Goater
2022-07-06 17:10     ` Daniel Henrique Barboza
2022-06-30 19:42 ` [PATCH 5/9] target/ppc: use Error pointer in kvmppc_get_clockfreq() Daniel Henrique Barboza
2022-07-02  6:22   ` Cédric Le Goater
2022-06-30 19:42 ` [PATCH 6/9] ppc440_bamboo.c: handle clock freq read error in load_device_tree Daniel Henrique Barboza
2022-07-02  6:23   ` Cédric Le Goater
2022-06-30 19:42 ` [PATCH 7/9] sam460ex.c: use CPU_FREQ if unable to read DT clock Daniel Henrique Barboza
2022-06-30 19:42 ` [PATCH 8/9] e500.c: use PLATFORM_CLK_FREQ_HZ if unable to read clock freq from DT Daniel Henrique Barboza
2022-06-30 19:42 ` [PATCH 9/9] spapr.c: handle clock freq read errors in spapr_dt_cpu() Daniel Henrique Barboza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220630194249.886747-5-danielhb413@gmail.com \
    --to=danielhb413@gmail.com \
    --cc=clg@kaod.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.