All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Farman <farman@linux.ibm.com>
To: Matthew Rosato <mjrosato@linux.ibm.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Halil Pasic <pasic@linux.ibm.com>,
	kvm@vger.kernel.org, linux-s390@vger.kernel.org,
	Eric Farman <farman@linux.ibm.com>
Subject: [PATCH v3 07/11] vfio/ccw: Update trace data for not operational event
Date: Thu, 30 Jun 2022 22:36:43 +0200	[thread overview]
Message-ID: <20220630203647.2529815-8-farman@linux.ibm.com> (raw)
In-Reply-To: <20220630203647.2529815-1-farman@linux.ibm.com>

We currently cut a very basic trace whenever the FSM directs
control to the not operational routine.

Convert this to a message, so it's alongside the other configuration
related traces (create, remove, etc.), and record both the event
that brought us here and the current state of the device.
This will provide some better footprints if things go bad.

Suggested-by: Matthew Rosato <mjrosato@linux.ibm.com>
Signed-off-by: Eric Farman <farman@linux.ibm.com>
---
 drivers/s390/cio/vfio_ccw_fsm.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/s390/cio/vfio_ccw_fsm.c b/drivers/s390/cio/vfio_ccw_fsm.c
index bbcc5b486749..88e529a2e184 100644
--- a/drivers/s390/cio/vfio_ccw_fsm.c
+++ b/drivers/s390/cio/vfio_ccw_fsm.c
@@ -160,8 +160,12 @@ static void fsm_notoper(struct vfio_ccw_private *private,
 {
 	struct subchannel *sch = private->sch;
 
-	VFIO_CCW_TRACE_EVENT(2, "notoper");
-	VFIO_CCW_TRACE_EVENT(2, dev_name(&sch->dev));
+	VFIO_CCW_MSG_EVENT(2, "sch %x.%x.%04x: notoper event %x state %x\n",
+			   sch->schid.cssid,
+			   sch->schid.ssid,
+			   sch->schid.sch_no,
+			   event,
+			   private->state);
 
 	/*
 	 * TODO:
-- 
2.32.0


  parent reply	other threads:[~2022-06-30 20:37 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-30 20:36 [PATCH v3 00/11] s390/vfio-ccw rework Eric Farman
2022-06-30 20:36 ` [PATCH v3 01/11] vfio/ccw: Remove UUID from s390 debug log Eric Farman
2022-06-30 20:36 ` [PATCH v3 02/11] vfio/ccw: Fix FSM state if mdev probe fails Eric Farman
2022-06-30 20:36 ` [PATCH v3 03/11] vfio/ccw: Do not change FSM state in subchannel event Eric Farman
2022-06-30 20:36 ` [PATCH v3 04/11] vfio/ccw: Remove private->mdev Eric Farman
2022-06-30 20:36 ` [PATCH v3 05/11] vfio/ccw: Pass enum to FSM event jumptable Eric Farman
2022-06-30 20:36 ` [PATCH v3 06/11] vfio/ccw: Flatten MDEV device (un)register Eric Farman
2022-06-30 20:36 ` Eric Farman [this message]
2022-07-05 19:29   ` [PATCH v3 07/11] vfio/ccw: Update trace data for not operational event Matthew Rosato
2022-06-30 20:36 ` [PATCH v3 08/11] vfio/ccw: Create an OPEN FSM Event Eric Farman
2022-07-05 19:29   ` Matthew Rosato
2022-06-30 20:36 ` [PATCH v3 09/11] vfio/ccw: Create a CLOSE FSM event Eric Farman
2022-07-05 19:29   ` Matthew Rosato
2022-06-30 20:36 ` [PATCH v3 10/11] vfio/ccw: Refactor vfio_ccw_mdev_reset Eric Farman
2022-07-05 19:29   ` Matthew Rosato
2022-06-30 20:36 ` [PATCH v3 11/11] vfio/ccw: Move FSM open/close to MDEV open/close Eric Farman
2022-07-05 20:17   ` Matthew Rosato
2022-06-30 23:44 ` [PATCH v3 00/11] s390/vfio-ccw rework Jason Gunthorpe
2022-07-01 12:40   ` Eric Farman
2022-07-01 12:48     ` Christian Borntraeger
2022-07-04 11:25       ` Jason Gunthorpe
2022-07-07  9:06         ` Christian Borntraeger
2022-07-07 12:34           ` Matthew Rosato
2022-07-07 13:04             ` Christian Borntraeger
2022-07-07 13:11               ` Matthew Rosato
2022-07-04  2:16     ` Yi Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220630203647.2529815-8-farman@linux.ibm.com \
    --to=farman@linux.ibm.com \
    --cc=alex.williamson@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=jgg@nvidia.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mjrosato@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.