All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hu Weiwen <sehuww@mail.scut.edu.cn>
To: Xiubo Li <xiubli@redhat.com>, ceph-devel@vger.kernel.org
Cc: Hu Weiwen <sehuww@mail.scut.edu.cn>
Subject: [RESEND PATCH] ceph: don't truncate file in atomic_open
Date: Fri,  1 Jul 2022 10:52:27 +0800	[thread overview]
Message-ID: <20220701025227.21636-1-sehuww@mail.scut.edu.cn> (raw)
In-Reply-To: <59d7c10f-7419-971b-c13c-71865f897953@redhat.com>

Clear O_TRUNC from the flags sent in the MDS create request.

`atomic_open' is called before permission check. We should not do any
modification to the file here. The caller will do the truncation
afterward.

Fixes: 124e68e74099 ("ceph: file operations")
Signed-off-by: Hu Weiwen <sehuww@mail.scut.edu.cn>
---
rebased onto ceph_client repo testing branch

 fs/ceph/file.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/fs/ceph/file.c b/fs/ceph/file.c
index 296fd1c7ece8..289e66e9cbb0 100644
--- a/fs/ceph/file.c
+++ b/fs/ceph/file.c
@@ -745,6 +745,11 @@ int ceph_atomic_open(struct inode *dir, struct dentry *dentry,
 	err = ceph_wait_on_conflict_unlink(dentry);
 	if (err)
 		return err;
+	/*
+	 * Do not truncate the file, since atomic_open is called before the
+	 * permission check. The caller will do the truncation afterward.
+	 */
+	flags &= ~O_TRUNC;
 
 retry:
 	if (flags & O_CREAT) {
@@ -836,9 +841,7 @@ int ceph_atomic_open(struct inode *dir, struct dentry *dentry,
 	set_bit(CEPH_MDS_R_PARENT_LOCKED, &req->r_req_flags);
 	req->r_new_inode = new_inode;
 	new_inode = NULL;
-	err = ceph_mdsc_do_request(mdsc,
-				   (flags & (O_CREAT|O_TRUNC)) ? dir : NULL,
-				   req);
+	err = ceph_mdsc_do_request(mdsc, (flags & O_CREAT) ? dir : NULL, req);
 	if (err == -ENOENT) {
 		dentry = ceph_handle_snapdir(req, dentry);
 		if (IS_ERR(dentry)) {
-- 
2.25.1


       reply	other threads:[~2022-07-01  2:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <59d7c10f-7419-971b-c13c-71865f897953@redhat.com>
2022-07-01  2:52 ` Hu Weiwen [this message]
2022-07-01  3:21   ` [RESEND PATCH] ceph: don't truncate file in atomic_open Xiubo Li
2022-10-12  1:51   ` Xiubo Li
2022-10-13  3:30     ` Xiubo Li
2022-10-13  9:15       ` Greg KH
2022-10-13  9:12     ` Greg KH
2022-10-13  9:20       ` Xiubo Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220701025227.21636-1-sehuww@mail.scut.edu.cn \
    --to=sehuww@mail.scut.edu.cn \
    --cc=ceph-devel@vger.kernel.org \
    --cc=xiubli@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.