From: Chris Morgan <macroalpha82@gmail.com>
To: linux-input@vger.kernel.org
Cc: devicetree@vger.kernel.org, contact@artur-rojek.eu,
maccraft123mc@gmail.com, heiko@sntech.de,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
dmitry.torokhov@gmail.com, paul@crapouillou.net,
jic23@kernel.org, linux-iio@vger.kernel.org,
Chris Morgan <macroalpha82@gmail.com>
Subject: [PATCH v7 0/3] adc-joystick: Add polled support
Date: Tue, 5 Jul 2022 14:03:51 -0500 [thread overview]
Message-ID: <20220705190354.69263-1-macromorgan@hotmail.com> (raw)
From: Chris Morgan <macroalpha82@gmail.com>
Add support to the existing adc-joystick driver to support polling
rather than relying on triggered buffers. This is useful for devices
that do not offer triggered buffers in hardware. Code adapted from
changes made by Maya Matuszczyk <maccraft123mc@gmail.com>.
Changes from V6:
- Reverted back to "poll-interval" after mailing list discussion.
- Referenced input.yaml for definition of poll-interval in adc-joystick
documentation.
Changes from V5:
- Corrected an error found by yamllint in the documentation.
Changes from V4:
- Added unit property to devicetree attribute making it now
"poll-interval-ms".
- Simplified logic for setting polled value and made variable names
more clear.
Changes from V3:
- After lengthy discussion decided to support with existing attribute
of "poll-interval". If present, the driver will use polling and if
not present, it will use triggered buffers (as the driver does
today).
- Corrected some lines to honor the 80 character line-limit.
- Check return value from polling method and return early if there
is an error reading the data.
Changes from V2:
- Changed parameter from "adc-joystick,polled" to
"adc-joystick,no-hardware-trigger" as it is more representative of
what the driver and hardware are doing.
Changes from V1:
- Removed driver compatible string of "adc-joystick-polled".
- Added new optional boolean value of "adc-joystick,polled".
- Cleaned up if statements regarding polling behavior.
Chris Morgan (3):
dt-bindings: adc-joystick: add poll-interval
Input: adc-joystick - Add polled input device support
arm64: dts: rockchip: Update joystick to polled for OG2
.../bindings/input/adc-joystick.yaml | 5 ++
.../boot/dts/rockchip/rk3326-odroid-go2.dts | 1 +
drivers/input/joystick/adc-joystick.c | 51 +++++++++++++++----
3 files changed, 46 insertions(+), 11 deletions(-)
--
2.34.1
next reply other threads:[~2022-07-05 19:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 19:03 Chris Morgan [this message]
2022-07-05 19:03 ` [PATCH v7 1/3] dt-bindings: adc-joystick: add poll-interval Chris Morgan
2022-07-06 14:37 ` Rob Herring
2022-07-06 20:58 ` Artur Rojek
2022-07-05 19:03 ` [PATCH v7 2/3] Input: adc-joystick - Add polled input device support Chris Morgan
2022-07-06 19:45 ` Artur Rojek
2022-07-16 15:58 ` Jonathan Cameron
2022-07-18 11:32 ` Artur Rojek
2022-07-05 19:03 ` [PATCH v7 3/3] arm64: dts: rockchip: Update joystick to polled for OG2 Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220705190354.69263-1-macromorgan@hotmail.com \
--to=macroalpha82@gmail.com \
--cc=contact@artur-rojek.eu \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=heiko@sntech.de \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=maccraft123mc@gmail.com \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.