From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>,
"Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: [PULL 1/2] m68k: use correct variable name in boot info string macro
Date: Wed, 6 Jul 2022 13:40:12 +0200 [thread overview]
Message-ID: <20220706114013.340537-2-laurent@vivier.eu> (raw)
In-Reply-To: <20220706114013.340537-1-laurent@vivier.eu>
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Every time this macro is used, the caller is passing in
"parameters_base", so this bug wasn't spotted. But the actual macro
variable name is "base", so use that instead.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20220625152318.120849-1-Jason@zx2c4.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
hw/m68k/bootinfo.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/m68k/bootinfo.h b/hw/m68k/bootinfo.h
index adbf0c5521e5..ff4e155a3cc8 100644
--- a/hw/m68k/bootinfo.h
+++ b/hw/m68k/bootinfo.h
@@ -54,6 +54,6 @@
stb_phys(as, base++, string[i]); \
} \
stb_phys(as, base++, 0); \
- base = (parameters_base + 1) & ~1; \
+ base = (base + 1) & ~1; \
} while (0)
#endif
--
2.36.1
next prev parent reply other threads:[~2022-07-06 11:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 11:40 [PULL 0/2] M68k for 7.1 patches Laurent Vivier
2022-07-06 11:40 ` Laurent Vivier [this message]
2022-07-06 11:40 ` [PULL 2/2] m68k: virt: pass RNG seed via bootinfo block Laurent Vivier
2022-07-07 0:50 ` [PULL 0/2] M68k for 7.1 patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706114013.340537-2-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=Jason@zx2c4.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.