From: Stephen Boyd <swboyd@chromium.org> To: Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, Sean Paul <sean@poorly.run>, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Hsin-Yi Wang <hsinyi@chromium.org>, Douglas Anderson <dianders@chromium.org> Subject: [PATCH] drm/msm/dsi: Set panel orientation when directly connected Date: Wed, 6 Jul 2022 12:14:42 -0700 [thread overview] Message-ID: <20220706191442.1150634-1-swboyd@chromium.org> (raw) Set the panel orientation in drm when the panel is directly connected, i.e. we're not using an external bridge. The external bridge case is already handled by the panel bridge code, so we only update the path we take when the panel is directly connected/internal. This silences a warning splat coming from __drm_mode_object_add() on Wormdingler boards. Cc: Hsin-Yi Wang <hsinyi@chromium.org> Cc: Douglas Anderson <dianders@chromium.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- This relies on commit 5e41b01a7808 ("drm/panel: Add an API to allow drm to set orientation from panel") which is in drm-misc drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c index cb84d185d73a..9333f7095acd 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_manager.c +++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c @@ -268,6 +268,8 @@ static int msm_dsi_manager_panel_init(struct drm_connector *conn, u8 id) return PTR_ERR(panel); } + drm_connector_set_orientation_from_panel(conn, panel); + if (!panel || !IS_BONDED_DSI()) goto out; base-commit: 15b9ca1641f0c3cd74885280331e9172c62a125e -- https://chromeos.dev
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org> To: Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Douglas Anderson <dianders@chromium.org>, Sean Paul <sean@poorly.run>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, patches@lists.linux.dev, Hsin-Yi Wang <hsinyi@chromium.org>, freedreno@lists.freedesktop.org Subject: [PATCH] drm/msm/dsi: Set panel orientation when directly connected Date: Wed, 6 Jul 2022 12:14:42 -0700 [thread overview] Message-ID: <20220706191442.1150634-1-swboyd@chromium.org> (raw) Set the panel orientation in drm when the panel is directly connected, i.e. we're not using an external bridge. The external bridge case is already handled by the panel bridge code, so we only update the path we take when the panel is directly connected/internal. This silences a warning splat coming from __drm_mode_object_add() on Wormdingler boards. Cc: Hsin-Yi Wang <hsinyi@chromium.org> Cc: Douglas Anderson <dianders@chromium.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- This relies on commit 5e41b01a7808 ("drm/panel: Add an API to allow drm to set orientation from panel") which is in drm-misc drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c index cb84d185d73a..9333f7095acd 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_manager.c +++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c @@ -268,6 +268,8 @@ static int msm_dsi_manager_panel_init(struct drm_connector *conn, u8 id) return PTR_ERR(panel); } + drm_connector_set_orientation_from_panel(conn, panel); + if (!panel || !IS_BONDED_DSI()) goto out; base-commit: 15b9ca1641f0c3cd74885280331e9172c62a125e -- https://chromeos.dev
next reply other threads:[~2022-07-06 19:14 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-06 19:14 Stephen Boyd [this message] 2022-07-06 19:14 ` [PATCH] drm/msm/dsi: Set panel orientation when directly connected Stephen Boyd 2022-07-07 21:11 ` Abhinav Kumar 2022-07-07 21:11 ` Abhinav Kumar 2022-07-07 21:21 ` Stephen Boyd 2022-07-07 21:21 ` Stephen Boyd 2022-07-07 21:25 ` [Freedreno] " Abhinav Kumar 2022-07-07 21:25 ` Abhinav Kumar 2022-07-08 15:25 ` Doug Anderson 2022-07-08 15:25 ` Doug Anderson 2022-07-08 16:00 ` Abhinav Kumar 2022-07-08 16:00 ` Abhinav Kumar 2022-07-08 19:42 ` Abhinav Kumar 2022-07-08 19:42 ` Abhinav Kumar 2022-07-08 20:58 ` Dmitry Baryshkov 2022-07-08 20:58 ` Dmitry Baryshkov 2022-07-08 21:17 ` Abhinav Kumar 2022-07-08 21:17 ` Abhinav Kumar 2022-07-20 20:46 ` Rob Clark 2022-07-20 20:46 ` Rob Clark 2022-07-20 22:42 ` Doug Anderson 2022-07-20 22:42 ` Doug Anderson 2022-08-17 20:48 ` Doug Anderson 2022-08-17 20:48 ` Doug Anderson 2022-08-18 23:11 ` [Freedreno] " Abhinav Kumar 2022-08-18 23:11 ` Abhinav Kumar 2022-09-01 8:42 ` Dmitry Baryshkov 2022-09-01 8:42 ` Dmitry Baryshkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220706191442.1150634-1-swboyd@chromium.org \ --to=swboyd@chromium.org \ --cc=dianders@chromium.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=hsinyi@chromium.org \ --cc=linux-kernel@vger.kernel.org \ --cc=patches@lists.linux.dev \ --cc=quic_abhinavk@quicinc.com \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.