From: Sumit Garg <sumit.garg@linaro.org>
To: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
vkoul@kernel.org, shawn.guo@linaro.org,
bryan.odonoghue@linaro.org, nicolas.dechesne@linaro.org,
mworsfold@impinj.com, daniel.thompson@linaro.org,
andrey.konovalov@linaro.org, Sumit Garg <sumit.garg@linaro.org>
Subject: [PATCH] arm64: dts: qcom: qcs404: Fix incorrect USB PHYs assignment
Date: Thu, 7 Jul 2022 17:24:44 +0530 [thread overview]
Message-ID: <20220707115444.1431367-1-sumit.garg@linaro.org> (raw)
This was a difficult inconsistency to be caught as both the USB PHYs were
being enabled in the kernel and USB worked fine. But when I was trying to
enable USB support in u-boot with all the required drivers ported, I
couldn't get the same USB storage device enumerated in u-boot which was
being enumerated fine by the kernel.
The root cause of the problem came out that I wasn't enabling USB PHY:
"usb2_phy_prim" in u-boot. Then I realised that via simply disabling the
same USB PHY in the kernel disabled enumeration for USB3 host controller
as well.
So fix this inconsistency by correctly assigning USB PHYs.
Fixes: 9375e7d719b3 ("arm64: dts: qcom: qcs404: Add USB devices and PHYs")
Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
---
arch/arm64/boot/dts/qcom/qcs404.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
index 513bf7343b2c..50edc11a5bb5 100644
--- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
@@ -557,7 +557,7 @@ usb3_dwc3: usb@7580000 {
compatible = "snps,dwc3";
reg = <0x07580000 0xcd00>;
interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
- phys = <&usb2_phy_sec>, <&usb3_phy>;
+ phys = <&usb2_phy_prim>, <&usb3_phy>;
phy-names = "usb2-phy", "usb3-phy";
snps,has-lpm-erratum;
snps,hird-threshold = /bits/ 8 <0x10>;
@@ -586,7 +586,7 @@ usb@78c0000 {
compatible = "snps,dwc3";
reg = <0x078c0000 0xcc00>;
interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
- phys = <&usb2_phy_prim>;
+ phys = <&usb2_phy_sec>;
phy-names = "usb2-phy";
snps,has-lpm-erratum;
snps,hird-threshold = /bits/ 8 <0x10>;
--
2.25.1
next reply other threads:[~2022-07-07 11:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 11:54 Sumit Garg [this message]
2022-07-07 14:22 ` [PATCH] arm64: dts: qcom: qcs404: Fix incorrect USB PHYs assignment Daniel Thompson
2022-07-08 11:16 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220707115444.1431367-1-sumit.garg@linaro.org \
--to=sumit.garg@linaro.org \
--cc=agross@kernel.org \
--cc=andrey.konovalov@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=mworsfold@impinj.com \
--cc=nicolas.dechesne@linaro.org \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.