All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH v2 19/30] dt-bindings: phy: add QMP USB PHY schema
Date: Thu,  7 Jul 2022 15:47:14 +0200	[thread overview]
Message-ID: <20220707134725.3512-20-johan+linaro@kernel.org> (raw)
In-Reply-To: <20220707134725.3512-1-johan+linaro@kernel.org>

The QMP PHY DT schema is getting unwieldy. Break out the USB PHY
binding in a separate file.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 ...com,qmp-phy.yaml => qcom,qmp-usb-phy.yaml} | 69 +++++--------------
 1 file changed, 18 insertions(+), 51 deletions(-)
 rename Documentation/devicetree/bindings/phy/{qcom,qmp-phy.yaml => qcom,qmp-usb-phy.yaml} (82%)

diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml
similarity index 82%
rename from Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
rename to Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml
index 21d6ec875529..66cabf4d5722 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml
@@ -1,11 +1,10 @@
 # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
-
 %YAML 1.2
 ---
-$id: "http://devicetree.org/schemas/phy/qcom,qmp-phy.yaml#"
-$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+$id: http://devicetree.org/schemas/phy/qcom,qmp-usb-phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: Qualcomm QMP PHY controller
+title: Qualcomm QMP PHY controller (USB)
 
 maintainers:
   - Vinod Koul <vkoul@kernel.org>
@@ -51,20 +50,20 @@ properties:
   ranges: true
 
   clocks:
-    minItems: 1
+    minItems: 3
     maxItems: 4
 
   clock-names:
-    minItems: 1
+    minItems: 3
     maxItems: 4
 
   resets:
-    minItems: 1
-    maxItems: 3
+    minItems: 2
+    maxItems: 2
 
   reset-names:
-    minItems: 1
-    maxItems: 3
+    minItems: 2
+    maxItems: 2
 
   vdda-phy-supply: true
 
@@ -75,7 +74,7 @@ properties:
 patternProperties:
   "^phy@[0-9a-f]+$":
     type: object
-    description: one child node per PHY provided by this block
+    description: single PHY-provider child node
 
 required:
   - compatible
@@ -87,6 +86,8 @@ required:
   - clock-names
   - resets
   - reset-names
+  - vdda-phy-supply
+  - vdda-pll-supply
 
 additionalProperties: false
 
@@ -113,34 +114,7 @@ allOf:
           items:
             - const: phy
             - const: common
-      required:
-        - vdda-phy-supply
-        - vdda-pll-supply
-  - if:
-      properties:
-        compatible:
-          contains:
-            enum:
-              - qcom,sdx55-qmp-usb3-uni-phy
-              - qcom,sdx65-qmp-usb3-uni-phy
-    then:
-      properties:
-        clocks:
-          maxItems: 3
-        clock-names:
-          items:
-            - const: aux
-            - const: cfg_ahb
-            - const: ref
-        resets:
-          maxItems: 2
-        reset-names:
-          items:
-            - const: phy
-            - const: common
-      required:
-        - vdda-phy-supply
-        - vdda-pll-supply
+
   - if:
       properties:
         compatible:
@@ -149,6 +123,8 @@ allOf:
               - qcom,ipq8074-qmp-usb3-phy
               - qcom,msm8996-qmp-usb3-phy
               - qcom,msm8998-qmp-usb3-phy
+              - qcom,sdx55-qmp-usb3-uni-phy
+              - qcom,sdx65-qmp-usb3-uni-phy
     then:
       properties:
         clocks:
@@ -164,9 +140,7 @@ allOf:
           items:
             - const: phy
             - const: common
-      required:
-        - vdda-phy-supply
-        - vdda-pll-supply
+
   - if:
       properties:
         compatible:
@@ -192,9 +166,7 @@ allOf:
           items:
             - const: phy
             - const: common
-      required:
-        - vdda-phy-supply
-        - vdda-pll-supply
+
   - if:
       properties:
         compatible:
@@ -217,9 +189,7 @@ allOf:
           items:
             - const: phy
             - const: common
-      required:
-        - vdda-phy-supply
-        - vdda-pll-supply
+
   - if:
       properties:
         compatible:
@@ -241,9 +211,6 @@ allOf:
           items:
             - const: phy_phy
             - const: phy
-      required:
-        - vdda-phy-supply
-        - vdda-pll-supply
 
 examples:
   - |
-- 
2.35.1


WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH v2 19/30] dt-bindings: phy: add QMP USB PHY schema
Date: Thu,  7 Jul 2022 15:47:14 +0200	[thread overview]
Message-ID: <20220707134725.3512-20-johan+linaro@kernel.org> (raw)
In-Reply-To: <20220707134725.3512-1-johan+linaro@kernel.org>

The QMP PHY DT schema is getting unwieldy. Break out the USB PHY
binding in a separate file.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 ...com,qmp-phy.yaml => qcom,qmp-usb-phy.yaml} | 69 +++++--------------
 1 file changed, 18 insertions(+), 51 deletions(-)
 rename Documentation/devicetree/bindings/phy/{qcom,qmp-phy.yaml => qcom,qmp-usb-phy.yaml} (82%)

diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml
similarity index 82%
rename from Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
rename to Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml
index 21d6ec875529..66cabf4d5722 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml
@@ -1,11 +1,10 @@
 # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
-
 %YAML 1.2
 ---
-$id: "http://devicetree.org/schemas/phy/qcom,qmp-phy.yaml#"
-$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+$id: http://devicetree.org/schemas/phy/qcom,qmp-usb-phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: Qualcomm QMP PHY controller
+title: Qualcomm QMP PHY controller (USB)
 
 maintainers:
   - Vinod Koul <vkoul@kernel.org>
@@ -51,20 +50,20 @@ properties:
   ranges: true
 
   clocks:
-    minItems: 1
+    minItems: 3
     maxItems: 4
 
   clock-names:
-    minItems: 1
+    minItems: 3
     maxItems: 4
 
   resets:
-    minItems: 1
-    maxItems: 3
+    minItems: 2
+    maxItems: 2
 
   reset-names:
-    minItems: 1
-    maxItems: 3
+    minItems: 2
+    maxItems: 2
 
   vdda-phy-supply: true
 
@@ -75,7 +74,7 @@ properties:
 patternProperties:
   "^phy@[0-9a-f]+$":
     type: object
-    description: one child node per PHY provided by this block
+    description: single PHY-provider child node
 
 required:
   - compatible
@@ -87,6 +86,8 @@ required:
   - clock-names
   - resets
   - reset-names
+  - vdda-phy-supply
+  - vdda-pll-supply
 
 additionalProperties: false
 
@@ -113,34 +114,7 @@ allOf:
           items:
             - const: phy
             - const: common
-      required:
-        - vdda-phy-supply
-        - vdda-pll-supply
-  - if:
-      properties:
-        compatible:
-          contains:
-            enum:
-              - qcom,sdx55-qmp-usb3-uni-phy
-              - qcom,sdx65-qmp-usb3-uni-phy
-    then:
-      properties:
-        clocks:
-          maxItems: 3
-        clock-names:
-          items:
-            - const: aux
-            - const: cfg_ahb
-            - const: ref
-        resets:
-          maxItems: 2
-        reset-names:
-          items:
-            - const: phy
-            - const: common
-      required:
-        - vdda-phy-supply
-        - vdda-pll-supply
+
   - if:
       properties:
         compatible:
@@ -149,6 +123,8 @@ allOf:
               - qcom,ipq8074-qmp-usb3-phy
               - qcom,msm8996-qmp-usb3-phy
               - qcom,msm8998-qmp-usb3-phy
+              - qcom,sdx55-qmp-usb3-uni-phy
+              - qcom,sdx65-qmp-usb3-uni-phy
     then:
       properties:
         clocks:
@@ -164,9 +140,7 @@ allOf:
           items:
             - const: phy
             - const: common
-      required:
-        - vdda-phy-supply
-        - vdda-pll-supply
+
   - if:
       properties:
         compatible:
@@ -192,9 +166,7 @@ allOf:
           items:
             - const: phy
             - const: common
-      required:
-        - vdda-phy-supply
-        - vdda-pll-supply
+
   - if:
       properties:
         compatible:
@@ -217,9 +189,7 @@ allOf:
           items:
             - const: phy
             - const: common
-      required:
-        - vdda-phy-supply
-        - vdda-pll-supply
+
   - if:
       properties:
         compatible:
@@ -241,9 +211,6 @@ allOf:
           items:
             - const: phy_phy
             - const: phy
-      required:
-        - vdda-phy-supply
-        - vdda-pll-supply
 
 examples:
   - |
-- 
2.35.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  parent reply	other threads:[~2022-07-07 13:48 UTC|newest]

Thread overview: 134+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07 13:46 [PATCH v2 00/30] phy: qcom,qmp: fix dt-bindings and deprecate lane suffix Johan Hovold
2022-07-07 13:46 ` Johan Hovold
2022-07-07 13:46 ` [PATCH v2 01/30] dt-bindings: phy: qcom,qmp: fix bogus clock-cells property Johan Hovold
2022-07-07 13:46   ` Johan Hovold
2022-07-07 13:46 ` [PATCH v2 02/30] dt-bindings: phy: qcom,qmp: sort compatible strings Johan Hovold
2022-07-07 13:46   ` Johan Hovold
2022-07-07 13:46 ` [PATCH v2 03/30] dt-bindings: phy: qcom,qmp: drop redundant descriptions Johan Hovold
2022-07-07 13:46   ` Johan Hovold
2022-07-14  9:07   ` Krzysztof Kozlowski
2022-07-14  9:07     ` Krzysztof Kozlowski
2022-07-14 10:00     ` Johan Hovold
2022-07-14 10:00       ` Johan Hovold
2022-07-14 10:42       ` Krzysztof Kozlowski
2022-07-14 10:42         ` Krzysztof Kozlowski
2022-07-07 13:46 ` [PATCH v2 04/30] dt-bindings: phy: qcom,qmp: fix child node description Johan Hovold
2022-07-07 13:46   ` Johan Hovold
2022-07-14  9:07   ` Krzysztof Kozlowski
2022-07-14  9:07     ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 05/30] dt-bindings: phy: qcom,qmp: clean up descriptions Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:07   ` Krzysztof Kozlowski
2022-07-14  9:07     ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 06/30] dt-bindings: phy: qcom,qmp: clean up example Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-07 13:47 ` [PATCH v2 07/30] dt-bindings: phy: qcom,qmp: drop child-node comment Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-07 13:47 ` [PATCH v2 08/30] dt-bindings: phy: add qcom,msm8996-qmp-pcie-phy schema Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:09   ` Krzysztof Kozlowski
2022-07-14  9:09     ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 09/30] dt-bindings: phy: qcom,msm8996-qmp-pcie: add missing child node schema Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:10   ` Krzysztof Kozlowski
2022-07-14  9:10     ` Krzysztof Kozlowski
2022-07-14  9:21     ` Krzysztof Kozlowski
2022-07-14  9:21       ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 10/30] dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate PIPE clock names Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:13   ` Krzysztof Kozlowski
2022-07-14  9:13     ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 11/30] dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate reset names Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:13   ` Krzysztof Kozlowski
2022-07-14  9:13     ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 12/30] dt-bindings: phy: add QMP PCIe PHY schema Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:15   ` Krzysztof Kozlowski
2022-07-14  9:15     ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 13/30] dt-bindings: phy: qcom,qmp-pcie: add missing child node schema Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:15   ` Krzysztof Kozlowski
2022-07-14  9:15     ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 14/30] dt-bindings: phy: qcom,qmp-pcie: deprecate PIPE clock name Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:18   ` Krzysztof Kozlowski
2022-07-14  9:18     ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 15/30] dt-bindings: phy: add QMP UFS PHY schema Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:19   ` Krzysztof Kozlowski
2022-07-14  9:19     ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 16/30] dt-bindings: phy: qcom,qmp-ufs: add missing SM8450 clock Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:21   ` Krzysztof Kozlowski
2022-07-14  9:21     ` Krzysztof Kozlowski
2022-07-14 10:07     ` Johan Hovold
2022-07-14 10:07       ` Johan Hovold
2022-07-14 10:42       ` Krzysztof Kozlowski
2022-07-14 10:42         ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 17/30] dt-bindings: phy: qcom,qmp-ufs: add missing SM8150 power domain Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:22   ` Krzysztof Kozlowski
2022-07-14  9:22     ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 18/30] dt-bindings: phy: qcom,qmp-ufs: add missing child node schema Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:23   ` Krzysztof Kozlowski
2022-07-14  9:23     ` Krzysztof Kozlowski
2022-07-07 13:47 ` Johan Hovold [this message]
2022-07-07 13:47   ` [PATCH v2 19/30] dt-bindings: phy: add QMP USB PHY schema Johan Hovold
2022-07-14  9:24   ` Krzysztof Kozlowski
2022-07-14  9:24     ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 20/30] dt-bindings: phy: qcom,qmp-usb: add missing child node schema Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:24   ` Krzysztof Kozlowski
2022-07-14  9:24     ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 21/30] dt-bindings: phy: qcom,qmp-usb: deprecate PIPE clock name Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:24   ` Krzysztof Kozlowski
2022-07-14  9:24     ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 22/30] dt-bindings: phy: qcom,qmp-usb: add missing qcom,sc7180-qmp-usb3-phy schema Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:25   ` Krzysztof Kozlowski
2022-07-14  9:25     ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 23/30] dt-bindings: phy: qcom,qmp-usb3-dp: fix bogus clock-cells property Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:27   ` Krzysztof Kozlowski
2022-07-14  9:27     ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 24/30] dt-bindings: phy: qcom,qmp-usb3-dp: deprecate USB PIPE clock name Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:27   ` Krzysztof Kozlowski
2022-07-14  9:27     ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 25/30] phy: qcom-qmp-pcie: drop pipe clock lane suffix Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:28   ` Krzysztof Kozlowski
2022-07-14  9:28     ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 26/30] phy: qcom-qmp-combo: drop unused lane reset Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:29   ` Krzysztof Kozlowski
2022-07-14  9:29     ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 27/30] phy: qcom-qmp-combo: drop pipe clock lane suffix Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:29   ` Krzysztof Kozlowski
2022-07-14  9:29     ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 28/30] phy: qcom-qmp-pcie-msm8996: " Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:29   ` Krzysztof Kozlowski
2022-07-14  9:29     ` Krzysztof Kozlowski
2022-07-14  9:30   ` Krzysztof Kozlowski
2022-07-14  9:30     ` Krzysztof Kozlowski
2022-07-14  9:49     ` Johan Hovold
2022-07-14  9:49       ` Johan Hovold
2022-07-07 13:47 ` [PATCH v2 29/30] phy: qcom-qmp-pcie-msm8996: drop reset " Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:31   ` Krzysztof Kozlowski
2022-07-14  9:31     ` Krzysztof Kozlowski
2022-07-07 13:47 ` [PATCH v2 30/30] phy: qcom-qmp-usb: drop pipe clock " Johan Hovold
2022-07-07 13:47   ` Johan Hovold
2022-07-14  9:31   ` Krzysztof Kozlowski
2022-07-14  9:31     ` Krzysztof Kozlowski
2022-07-14  8:12 ` [PATCH v2 00/30] phy: qcom,qmp: fix dt-bindings and deprecate " Johan Hovold
2022-07-14  8:12   ` Johan Hovold
2022-07-14  9:31   ` Krzysztof Kozlowski
2022-07-14  9:31     ` Krzysztof Kozlowski
2022-07-14  9:44     ` Johan Hovold
2022-07-14  9:44       ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220707134725.3512-20-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=kishon@ti.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.