All of lore.kernel.org
 help / color / mirror / Atom feed
From: Justin Stitt <justinstitt@google.com>
To: justinstitt@google.com
Cc: davem@davemloft.net, dhowells@redhat.com, edumazet@google.com,
	 kuba@kernel.org, linux-afs@lists.infradead.org,
	linux-kernel@vger.kernel.org,  llvm@lists.linux.dev,
	marc.dionne@auristor.com, nathan@kernel.org,
	 ndesaulniers@google.com, netdev@vger.kernel.org,
	pabeni@redhat.com,  trix@redhat.com
Subject: [PATCH v2] net: rxrpc: fix clang -Wformat warning
Date: Thu,  7 Jul 2022 11:20:52 -0700	[thread overview]
Message-ID: <20220707182052.769989-1-justinstitt@google.com> (raw)
In-Reply-To: <20220706235648.594609-1-justinstitt@google.com>

When building with Clang we encounter this warning:
| net/rxrpc/rxkad.c:434:33: error: format specifies type 'unsigned short'
| but the argument has type 'u32' (aka 'unsigned int') [-Werror,-Wformat]
| _leave(" = %d [set %hx]", ret, y);

y is a u32 but the format specifier is `%hx`. Going from unsigned int to
short int results in a loss of data. This is surely not intended
behavior. If it is intended, the warning should be suppressed through
other means.

This patch should get us closer to the goal of enabling the -Wformat
flag for Clang builds.

Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Justin Stitt <justinstitt@google.com>
---
diff from v1 -> v2: 
* Change format specifier from %u to %x to properly represent hexadecimal.

 net/rxrpc/rxkad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c
index 08aab5c01437..258917a714c8 100644
--- a/net/rxrpc/rxkad.c
+++ b/net/rxrpc/rxkad.c
@@ -431,7 +431,7 @@ static int rxkad_secure_packet(struct rxrpc_call *call,
 		break;
 	}
 
-	_leave(" = %d [set %hx]", ret, y);
+	_leave(" = %d [set %x]", ret, y);
 	return ret;
 }
 
-- 
2.37.0.rc0.161.g10f37bed90-goog


  parent reply	other threads:[~2022-07-07 18:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06 23:56 [PATCH] net: rxrpc: fix clang -Wformat warning Justin Stitt
2022-07-07 17:58 ` Nathan Chancellor
2022-07-07 18:20 ` Justin Stitt [this message]
2022-07-07 18:24   ` [PATCH v2] " Nathan Chancellor
2022-07-09  3:20   ` patchwork-bot+netdevbpf
2022-07-07 23:10 ` [PATCH] " Joe Perches
2022-07-08  9:39 ` [PATCH v2] " David Howells
2022-07-08  9:39 ` [PATCH] " David Howells
2022-07-08  9:40 ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220707182052.769989-1-justinstitt@google.com \
    --to=justinstitt@google.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=marc.dionne@auristor.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.