From: Akhil P Oommen <quic_akhilpo@quicinc.com> To: freedreno <freedreno@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>, <linux-arm-msm@vger.kernel.org>, Rob Clark <robdclark@gmail.com>, Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Jonathan Marek <jonathan@marek.ca>, Akhil P Oommen <quic_akhilpo@quicinc.com>, linux-kernel@vger.kernel.org, Abhinav Kumar <quic_abhinavk@quicinc.com>, Douglas Anderson <dianders@chromium.org>, David Airlie <airlied@linux.ie>, Matthias Kaehlcke <mka@chromium.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Jordan Crouse <jordan@cosmicpenguin.net>, Sean Paul <sean@poorly.run> Subject: [PATCH 1/7] drm/msm: Remove unnecessary pm_runtime_get/put Date: Thu, 7 Jul 2022 21:40:56 +0530 [thread overview] Message-ID: <20220707213950.1.Icf1e8f0c9b3e7e9933c3b48c70477d0582f3243f@changeid> (raw) In-Reply-To: <1657210262-17166-1-git-send-email-quic_akhilpo@quicinc.com> We already enable gpu power from msm_gpu_submit(), so avoid a duplicate pm_runtime_get/put from msm_job_run(). Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com> --- drivers/gpu/drm/msm/msm_ringbuffer.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_ringbuffer.c b/drivers/gpu/drm/msm/msm_ringbuffer.c index 4306632..82bee84 100644 --- a/drivers/gpu/drm/msm/msm_ringbuffer.c +++ b/drivers/gpu/drm/msm/msm_ringbuffer.c @@ -29,8 +29,6 @@ static struct dma_fence *msm_job_run(struct drm_sched_job *job) msm_gem_unlock(obj); } - pm_runtime_get_sync(&gpu->pdev->dev); - /* TODO move submit path over to using a per-ring lock.. */ mutex_lock(&gpu->lock); @@ -38,8 +36,6 @@ static struct dma_fence *msm_job_run(struct drm_sched_job *job) mutex_unlock(&gpu->lock); - pm_runtime_put(&gpu->pdev->dev); - return dma_fence_get(submit->hw_fence); } -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Akhil P Oommen <quic_akhilpo@quicinc.com> To: freedreno <freedreno@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>, <linux-arm-msm@vger.kernel.org>, Rob Clark <robdclark@gmail.com>, Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Jordan Crouse <jordan@cosmicpenguin.net>, Douglas Anderson <dianders@chromium.org>, Matthias Kaehlcke <mka@chromium.org>, Jonathan Marek <jonathan@marek.ca>, Akhil P Oommen <quic_akhilpo@quicinc.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Sean Paul <sean@poorly.run>, <linux-kernel@vger.kernel.org> Subject: [PATCH 1/7] drm/msm: Remove unnecessary pm_runtime_get/put Date: Thu, 7 Jul 2022 21:40:56 +0530 [thread overview] Message-ID: <20220707213950.1.Icf1e8f0c9b3e7e9933c3b48c70477d0582f3243f@changeid> (raw) In-Reply-To: <1657210262-17166-1-git-send-email-quic_akhilpo@quicinc.com> We already enable gpu power from msm_gpu_submit(), so avoid a duplicate pm_runtime_get/put from msm_job_run(). Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com> --- drivers/gpu/drm/msm/msm_ringbuffer.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_ringbuffer.c b/drivers/gpu/drm/msm/msm_ringbuffer.c index 4306632..82bee84 100644 --- a/drivers/gpu/drm/msm/msm_ringbuffer.c +++ b/drivers/gpu/drm/msm/msm_ringbuffer.c @@ -29,8 +29,6 @@ static struct dma_fence *msm_job_run(struct drm_sched_job *job) msm_gem_unlock(obj); } - pm_runtime_get_sync(&gpu->pdev->dev); - /* TODO move submit path over to using a per-ring lock.. */ mutex_lock(&gpu->lock); @@ -38,8 +36,6 @@ static struct dma_fence *msm_job_run(struct drm_sched_job *job) mutex_unlock(&gpu->lock); - pm_runtime_put(&gpu->pdev->dev); - return dma_fence_get(submit->hw_fence); } -- 2.7.4
next prev parent reply other threads:[~2022-07-07 16:11 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-07 16:10 [PATCH 0/7] Improve GPU Recovery Akhil P Oommen 2022-07-07 16:10 ` Akhil P Oommen 2022-07-07 16:10 ` Akhil P Oommen [this message] 2022-07-07 16:10 ` [PATCH 1/7] drm/msm: Remove unnecessary pm_runtime_get/put Akhil P Oommen 2022-07-07 16:10 ` [PATCH 2/7] drm/msm: Correct pm_runtime votes in recover worker Akhil P Oommen 2022-07-07 16:10 ` Akhil P Oommen 2022-07-07 16:10 ` [PATCH 3/7] drm/msm: Fix cx collapse issue during recovery Akhil P Oommen 2022-07-07 16:10 ` Akhil P Oommen 2022-07-07 17:10 ` Rob Clark 2022-07-07 17:10 ` Rob Clark 2022-07-07 16:10 ` [PATCH 4/7] drm/msm: Ensure cx gdsc collapse " Akhil P Oommen 2022-07-07 16:10 ` Akhil P Oommen 2022-07-07 16:11 ` [PATCH 5/7] arm64: dts: qcom: sc7280: Update gpu register list Akhil P Oommen 2022-07-07 16:11 ` Akhil P Oommen 2022-07-07 16:11 ` [PATCH 6/7] drm/msm/a6xx: Improve gpu recovery sequence Akhil P Oommen 2022-07-07 16:11 ` Akhil P Oommen 2022-07-07 16:11 ` [PATCH 7/7] drm/msm/a6xx: Handle GMU prepare-slumber hfi failure Akhil P Oommen 2022-07-07 16:11 ` Akhil P Oommen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220707213950.1.Icf1e8f0c9b3e7e9933c3b48c70477d0582f3243f@changeid \ --to=quic_akhilpo@quicinc.com \ --cc=airlied@linux.ie \ --cc=bjorn.andersson@linaro.org \ --cc=dianders@chromium.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=jonathan@marek.ca \ --cc=jordan@cosmicpenguin.net \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mka@chromium.org \ --cc=quic_abhinavk@quicinc.com \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.