All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Bob Peterson <rpeterso@redhat.com>,
	Andreas Gruenbacher <agruenba@redhat.com>,
	"Darrick J. Wong" <djwong@kernel.org>,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>,
	Naohiro Aota <naohiro.aota@wdc.com>
Cc: Johannes Thumshirn <jth@kernel.org>,
	cluster-devel@redhat.com, linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: [PATCH 1/4] gfs2: stop using generic_writepages in gfs2_ail1_start_one
Date: Mon, 11 Jul 2022 06:14:56 +0200	[thread overview]
Message-ID: <20220711041459.1062583-2-hch@lst.de> (raw)
In-Reply-To: <20220711041459.1062583-1-hch@lst.de>

Use filemap_fdatawrite_wbc instead of generic_writepages in
gfs2_ail1_start_one so that the functin can also cope with address_space
operations that only implement ->writepages and to properly account
for cgroup writeback.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/gfs2/log.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c
index f0ee3ff6f9a87..624dffc96136b 100644
--- a/fs/gfs2/log.c
+++ b/fs/gfs2/log.c
@@ -131,7 +131,7 @@ __acquires(&sdp->sd_ail_lock)
 		if (!mapping)
 			continue;
 		spin_unlock(&sdp->sd_ail_lock);
-		ret = generic_writepages(mapping, wbc);
+		ret = filemap_fdatawrite_wbc(mapping, wbc);
 		if (need_resched()) {
 			blk_finish_plug(plug);
 			cond_resched();
-- 
2.30.2


WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/4] gfs2: stop using generic_writepages in gfs2_ail1_start_one
Date: Mon, 11 Jul 2022 06:14:56 +0200	[thread overview]
Message-ID: <20220711041459.1062583-2-hch@lst.de> (raw)
In-Reply-To: <20220711041459.1062583-1-hch@lst.de>

Use filemap_fdatawrite_wbc instead of generic_writepages in
gfs2_ail1_start_one so that the functin can also cope with address_space
operations that only implement ->writepages and to properly account
for cgroup writeback.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/gfs2/log.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c
index f0ee3ff6f9a87..624dffc96136b 100644
--- a/fs/gfs2/log.c
+++ b/fs/gfs2/log.c
@@ -131,7 +131,7 @@ __acquires(&sdp->sd_ail_lock)
 		if (!mapping)
 			continue;
 		spin_unlock(&sdp->sd_ail_lock);
-		ret = generic_writepages(mapping, wbc);
+		ret = filemap_fdatawrite_wbc(mapping, wbc);
 		if (need_resched()) {
 			blk_finish_plug(plug);
 			cond_resched();
-- 
2.30.2


  reply	other threads:[~2022-07-11  4:15 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-11  4:14 remove iomap_writepage Christoph Hellwig
2022-07-11  4:14 ` [Cluster-devel] " Christoph Hellwig
2022-07-11  4:14 ` Christoph Hellwig [this message]
2022-07-11  4:14   ` [Cluster-devel] [PATCH 1/4] gfs2: stop using generic_writepages in gfs2_ail1_start_one Christoph Hellwig
2022-07-11 10:27   ` Andreas Gruenbacher
2022-07-11 10:27     ` [Cluster-devel] " Andreas Gruenbacher
2022-07-11 14:30     ` Christoph Hellwig
2022-07-11 14:30       ` [Cluster-devel] " Christoph Hellwig
2022-07-11  4:14 ` [PATCH 2/4] gfs2: remove ->writepage Christoph Hellwig
2022-07-11  4:14   ` [Cluster-devel] " Christoph Hellwig
2022-07-11 23:22   ` Andreas Grünbacher
2022-07-11 23:22     ` [Cluster-devel] " Andreas Grünbacher
2022-07-12  4:57     ` Christoph Hellwig
2022-07-12  4:57       ` [Cluster-devel] " Christoph Hellwig
2022-07-11  4:14 ` [PATCH 3/4] zonefs: " Christoph Hellwig
2022-07-11  4:14   ` [Cluster-devel] " Christoph Hellwig
2022-07-11  4:47   ` Damien Le Moal
2022-07-11  4:47     ` [Cluster-devel] " Damien Le Moal
2022-07-11  9:12   ` Johannes Thumshirn
2022-07-11  9:12     ` [Cluster-devel] " Johannes Thumshirn
2022-07-11  4:14 ` [PATCH 4/4] iomap: remove iomap_writepage Christoph Hellwig
2022-07-11  4:14   ` [Cluster-devel] " Christoph Hellwig
2022-07-11  4:48   ` Damien Le Moal
2022-07-11  4:48     ` [Cluster-devel] " Damien Le Moal
2022-07-19  4:13 remove iomap_writepage v2 Christoph Hellwig
2022-07-19  4:13 ` [PATCH 1/4] gfs2: stop using generic_writepages in gfs2_ail1_start_one Christoph Hellwig
2023-01-18 21:22   ` Andreas Gruenbacher
2023-01-19  6:22     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220711041459.1062583-2-hch@lst.de \
    --to=hch@lst.de \
    --cc=agruenba@redhat.com \
    --cc=cluster-devel@redhat.com \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=djwong@kernel.org \
    --cc=jth@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=naohiro.aota@wdc.com \
    --cc=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.