From: "Nuno Sá" <nuno.sa@analog.com> To: <linux-arm-msm@vger.kernel.org>, <openbmc@lists.ozlabs.org>, <linux-renesas-soc@vger.kernel.org>, <linux-mediatek@lists.infradead.org>, <linux-imx@nxp.com>, <linux-mips@vger.kernel.org>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>, <linux-iio@vger.kernel.org>, <chrome-platform@lists.linux.dev>, <linux-arm-kernel@lists.infradead.org>, <linux-stm32@st-md-mailman.stormreply.com> Cc: Andy Gross <agross@kernel.org>, Nicolas Ferre <nicolas.ferre@microchip.com>, Benson Leung <bleung@chromium.org>, Matthias Brugger <matthias.bgg@gmail.com>, Tomer Maimon <tmaimon77@gmail.com>, Zhang Rui <rui.zhang@intel.com>, "Rafael J. Wysocki" <rafael@kernel.org>, Eugen Hristev <eugen.hristev@microchip.com>, Sascha Hauer <s.hauer@pengutronix.de>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Benjamin Fair <benjaminfair@google.com>, Nancy Yuen <yuenn@google.com>, Fabrice Gasnier <fabrice.gasnier@foss.st.com>, Jishnu Prakash <quic_jprakash@quicinc.com>, Christophe Branchereau <cbranchereau@gmail.com>, Avi Fishman <avifishman70@gmail.com>, Tali Perry <tali.perry1@gmail.com>, Michael Hennerich <Michael.Hennerich@analog.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Claudiu Beznea <claudiu.beznea@microchip.com>, Lars-Peter Clausen <lars@metafoo.de>, Thara Gopinath <thara.gopinath@linaro.org>, Cai Huoqing <cai.huoqing@linux.dev>, Fabio Estevam <festevam@gmail.com>, Olivier Moysan <olivier.moysan@foss.st.com>, Shawn Guo <shawnguo@kernel.org>, Haibo Chen <haibo.chen@nxp.com>, Arnd Bergmann <arnd@arndb.de>, Daniel Lezcano <daniel.lezcano@linaro.org>, Patrick Venture <venture@google.com>, Amit Kucheria <amitk@kernel.org>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Lorenzo Bianconi <lorenzo@kernel.org>, Paul Cercueil <paul@crapouillou.net>, Andy Shevchenko <andy.shevchenko@gmail.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, Gwendal Grignou <gwendal@chromium.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Saravanan Sekar <sravanhome@gmail.com>, Guenter Roeck <groeck@chromium.org>, Jonathan Cameron <jic23@kernel.org>, Pengutronix Kernel Team <kernel@pengutronix.de>, Linus Walleij <linus.walleij@linaro.org> Subject: [PATCH v2 00/15] make iio inkern interface firmware agnostic Date: Mon, 11 Jul 2022 14:38:20 +0200 [thread overview] Message-ID: <20220711123835.811358-1-nuno.sa@analog.com> (raw) First version of the series can be found here: https://lore.kernel.org/linux-iio/20220610084545.547700-1-nuno.sa@analog.com/ v2 changes: [1/15] * Fix typo and added more description in the commit message. [3/15] * Remove superfluous code; * Commit message spell fixes and added more details; * Improved error handling (this is the most significant change in this version. More details on the commit message). [4/15] * Drop the 'ugly' parent_lookup flag. With the new error handling, we can use -ENODEV to infer if we should proceed or not with the lookup. [5/15]: * Moved some local declarations up so long lines first; * Use 'bus_find_device_by_fwnode()'; * Proper ordering in includes. * Adapted error handling in '__fwnode_iio_channel_get_by_name()' taking ACPI into account and when 'name' is given but index < 0. It seems that ACPI code can actually return -ENOENT with index < 0 for which case we should continue the search. Not sure if a check in ACPI ('if (index < 0) return -EINVAL;) like is done in OF would make sense... [12/15]: * Use 'device_property_count_u64()' to get the number of diff channels. So no need for 'magic' divisions by 2 (no idea why I haven't done like this in the first place). [15/15] * Fix wrong conversion of 'if (ptr != NULL)' to 'if (!ptr)'. Special note for patch 3/15 where -ENODEV is still used despite some talks about using -ENOENT and hence, be more in line with firmware code. The reason I kept it was to be consistent with the rest of the file. I'd say that if we want to move to -ENOENT we should do it in a separate patch and for the complete file. Nuno Sá (15): iio: inkern: only release the device node when done with it iio: inkern: fix return value in devm_of_iio_channel_get_by_name() iio: inkern: only return error codes in iio_channel_get_*() APIs iio: inkern: split of_iio_channel_get_by_name() iio: inkern: move to fwnode properties thermal: qcom: qcom-spmi-adc-tm5: convert to IIO fwnode API iio: adc: ingenic-adc: convert to IIO fwnode interface iio: adc: ab8500-gpadc: convert to device properties iio: adc: at91-sama5d2_adc: convert to device properties iio: adc: qcom-pm8xxx-xoadc: convert to device properties iio: adc: qcom-spmi-vadc: convert to device properties iio: adc: qcom-spmi-adc5: convert to device properties iio: adc: stm32-adc: convert to device properties iio: inkern: remove OF dependencies iio: inkern: fix coding style warnings drivers/iio/adc/ab8500-gpadc.c | 27 +-- drivers/iio/adc/at91-sama5d2_adc.c | 30 +-- drivers/iio/adc/ingenic-adc.c | 8 +- drivers/iio/adc/qcom-pm8xxx-xoadc.c | 58 +++-- drivers/iio/adc/qcom-spmi-adc5.c | 63 +++--- drivers/iio/adc/qcom-spmi-vadc.c | 44 ++-- drivers/iio/adc/stm32-adc.c | 121 +++++----- drivers/iio/inkern.c | 271 +++++++++++++---------- drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 3 +- include/linux/iio/consumer.h | 28 +-- include/linux/iio/iio.h | 8 +- 11 files changed, 347 insertions(+), 314 deletions(-) -- 2.37.0
WARNING: multiple messages have this Message-ID (diff)
From: "Nuno Sá" <nuno.sa@analog.com> To: <linux-arm-msm@vger.kernel.org>, <openbmc@lists.ozlabs.org>, <linux-renesas-soc@vger.kernel.org>, <linux-mediatek@lists.infradead.org>, <linux-imx@nxp.com>, <linux-mips@vger.kernel.org>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>, <linux-iio@vger.kernel.org>, <chrome-platform@lists.linux.dev>, <linux-arm-kernel@lists.infradead.org>, <linux-stm32@st-md-mailman.stormreply.com> Cc: Andy Gross <agross@kernel.org>, Nicolas Ferre <nicolas.ferre@microchip.com>, Benson Leung <bleung@chromium.org>, Matthias Brugger <matthias.bgg@gmail.com>, Tomer Maimon <tmaimon77@gmail.com>, Zhang Rui <rui.zhang@intel.com>, "Rafael J. Wysocki" <rafael@kernel.org>, Eugen Hristev <eugen.hristev@microchip.com>, Sascha Hauer <s.hauer@pengutronix.de>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Benjamin Fair <benjaminfair@google.com>, Nancy Yuen <yuenn@google.com>, Fabrice Gasnier <fabrice.gasnier@foss.st.com>, Jishnu Prakash <quic_jprakash@quicinc.com>, Christophe Branchereau <cbranchereau@gmail.com>, Avi Fishman <avifishman70@gmail.com>, Tali Perry <tali.perry1@gmail.com>, Michael Hennerich <Michael.Hennerich@analog.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Claudiu Beznea <claudiu.beznea@microchip.com>, Lars-Peter Clausen <lars@metafoo.de>, Thara Gopinath <thara.gopinath@linaro.org>, Cai Huoqing <cai.huoqing@linux.dev>, Fabio Estevam <festevam@gmail.com>, Olivier Moysan <olivier.moysan@foss.st.com>, Shawn Guo <shawnguo@kernel.org>, Haibo Chen <haibo.chen@nxp.com>, Arnd Bergmann <arnd@arndb.de>, Daniel Lezcano <daniel.lezcano@linaro.org>, Patrick Venture <venture@google.com>, Amit Kucheria <amitk@kernel.org>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Lorenzo Bianconi <lorenzo@kernel.org>, Paul Cercueil <paul@crapouillou.net>, Andy Shevchenko <andy.shevchenko@gmail.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, Gwendal Grignou <gwendal@chromium.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Saravanan Sekar <sravanhome@gmail.com>, Guenter Roeck <groeck@chromium.org>, Jonathan Cameron <jic23@kernel.org>, Pengutronix Kernel Team <kernel@pengutronix.de>, Linus Walleij <linus.walleij@linaro.org> Subject: [PATCH v2 00/15] make iio inkern interface firmware agnostic Date: Mon, 11 Jul 2022 14:38:20 +0200 [thread overview] Message-ID: <20220711123835.811358-1-nuno.sa@analog.com> (raw) First version of the series can be found here: https://lore.kernel.org/linux-iio/20220610084545.547700-1-nuno.sa@analog.com/ v2 changes: [1/15] * Fix typo and added more description in the commit message. [3/15] * Remove superfluous code; * Commit message spell fixes and added more details; * Improved error handling (this is the most significant change in this version. More details on the commit message). [4/15] * Drop the 'ugly' parent_lookup flag. With the new error handling, we can use -ENODEV to infer if we should proceed or not with the lookup. [5/15]: * Moved some local declarations up so long lines first; * Use 'bus_find_device_by_fwnode()'; * Proper ordering in includes. * Adapted error handling in '__fwnode_iio_channel_get_by_name()' taking ACPI into account and when 'name' is given but index < 0. It seems that ACPI code can actually return -ENOENT with index < 0 for which case we should continue the search. Not sure if a check in ACPI ('if (index < 0) return -EINVAL;) like is done in OF would make sense... [12/15]: * Use 'device_property_count_u64()' to get the number of diff channels. So no need for 'magic' divisions by 2 (no idea why I haven't done like this in the first place). [15/15] * Fix wrong conversion of 'if (ptr != NULL)' to 'if (!ptr)'. Special note for patch 3/15 where -ENODEV is still used despite some talks about using -ENOENT and hence, be more in line with firmware code. The reason I kept it was to be consistent with the rest of the file. I'd say that if we want to move to -ENOENT we should do it in a separate patch and for the complete file. Nuno Sá (15): iio: inkern: only release the device node when done with it iio: inkern: fix return value in devm_of_iio_channel_get_by_name() iio: inkern: only return error codes in iio_channel_get_*() APIs iio: inkern: split of_iio_channel_get_by_name() iio: inkern: move to fwnode properties thermal: qcom: qcom-spmi-adc-tm5: convert to IIO fwnode API iio: adc: ingenic-adc: convert to IIO fwnode interface iio: adc: ab8500-gpadc: convert to device properties iio: adc: at91-sama5d2_adc: convert to device properties iio: adc: qcom-pm8xxx-xoadc: convert to device properties iio: adc: qcom-spmi-vadc: convert to device properties iio: adc: qcom-spmi-adc5: convert to device properties iio: adc: stm32-adc: convert to device properties iio: inkern: remove OF dependencies iio: inkern: fix coding style warnings drivers/iio/adc/ab8500-gpadc.c | 27 +-- drivers/iio/adc/at91-sama5d2_adc.c | 30 +-- drivers/iio/adc/ingenic-adc.c | 8 +- drivers/iio/adc/qcom-pm8xxx-xoadc.c | 58 +++-- drivers/iio/adc/qcom-spmi-adc5.c | 63 +++--- drivers/iio/adc/qcom-spmi-vadc.c | 44 ++-- drivers/iio/adc/stm32-adc.c | 121 +++++----- drivers/iio/inkern.c | 271 +++++++++++++---------- drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 3 +- include/linux/iio/consumer.h | 28 +-- include/linux/iio/iio.h | 8 +- 11 files changed, 347 insertions(+), 314 deletions(-) -- 2.37.0
next reply other threads:[~2022-07-11 12:40 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-11 12:38 Nuno Sá [this message] 2022-07-11 12:38 ` [PATCH v2 00/15] make iio inkern interface firmware agnostic Nuno Sá 2022-07-11 12:38 ` [PATCH v2 01/15] iio: inkern: only release the device node when done with it Nuno Sá 2022-07-11 13:09 ` Andy Shevchenko 2022-07-11 12:38 ` [PATCH v2 02/15] iio: inkern: fix return value in devm_of_iio_channel_get_by_name() Nuno Sá 2022-07-11 12:38 ` [PATCH v2 03/15] iio: inkern: only return error codes in iio_channel_get_*() APIs Nuno Sá 2022-07-11 13:29 ` Andy Shevchenko 2022-07-11 14:06 ` Nuno Sá 2022-07-11 12:38 ` [PATCH v2 04/15] iio: inkern: split of_iio_channel_get_by_name() Nuno Sá 2022-07-11 12:38 ` [PATCH v2 05/15] iio: inkern: move to fwnode properties Nuno Sá 2022-07-11 12:38 ` [PATCH v2 06/15] thermal: qcom: qcom-spmi-adc-tm5: convert to IIO fwnode API Nuno Sá 2022-07-11 12:38 ` [PATCH v2 07/15] iio: adc: ingenic-adc: convert to IIO fwnode interface Nuno Sá 2022-07-11 12:38 ` [PATCH v2 08/15] iio: adc: ab8500-gpadc: convert to device properties Nuno Sá 2022-07-11 12:38 ` [PATCH v2 09/15] iio: adc: at91-sama5d2_adc: " Nuno Sá 2022-07-11 12:38 ` [PATCH v2 10/15] iio: adc: qcom-pm8xxx-xoadc: " Nuno Sá 2022-07-11 12:38 ` [PATCH v2 11/15] iio: adc: qcom-spmi-vadc: " Nuno Sá 2022-07-11 12:38 ` [PATCH v2 12/15] iio: adc: qcom-spmi-adc5: " Nuno Sá 2022-07-11 12:38 ` [PATCH v2 13/15] iio: adc: stm32-adc: " Nuno Sá 2022-07-11 14:04 ` Fabrice Gasnier 2022-07-12 10:33 ` Nuno Sá 2022-07-13 15:48 ` Fabrice Gasnier 2022-07-15 11:22 ` Nuno Sá 2022-07-11 12:38 ` [PATCH v2 14/15] iio: inkern: remove OF dependencies Nuno Sá 2022-07-11 12:38 ` [PATCH v2 15/15] iio: inkern: fix coding style warnings Nuno Sá 2022-07-11 13:15 ` Andy Shevchenko 2022-07-11 13:28 ` Biju Das 2022-07-11 13:32 ` Andy Shevchenko 2022-07-11 13:37 ` Biju Das 2022-07-11 14:05 ` Nuno Sá 2022-07-11 13:22 ` [PATCH v2 00/15] make iio inkern interface firmware agnostic Andy Shevchenko 2022-07-11 14:04 ` Nuno Sá
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220711123835.811358-1-nuno.sa@analog.com \ --to=nuno.sa@analog.com \ --cc=Michael.Hennerich@analog.com \ --cc=agross@kernel.org \ --cc=alexandre.belloni@bootlin.com \ --cc=alexandre.torgue@foss.st.com \ --cc=amitk@kernel.org \ --cc=andy.shevchenko@gmail.com \ --cc=arnd@arndb.de \ --cc=avifishman70@gmail.com \ --cc=benjaminfair@google.com \ --cc=bjorn.andersson@linaro.org \ --cc=bleung@chromium.org \ --cc=cai.huoqing@linux.dev \ --cc=cbranchereau@gmail.com \ --cc=chrome-platform@lists.linux.dev \ --cc=claudiu.beznea@microchip.com \ --cc=daniel.lezcano@linaro.org \ --cc=eugen.hristev@microchip.com \ --cc=fabrice.gasnier@foss.st.com \ --cc=festevam@gmail.com \ --cc=groeck@chromium.org \ --cc=gwendal@chromium.org \ --cc=haibo.chen@nxp.com \ --cc=jic23@kernel.org \ --cc=kernel@pengutronix.de \ --cc=lars@metafoo.de \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-mips@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=lorenzo@kernel.org \ --cc=matthias.bgg@gmail.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=miquel.raynal@bootlin.com \ --cc=nicolas.ferre@microchip.com \ --cc=olivier.moysan@foss.st.com \ --cc=openbmc@lists.ozlabs.org \ --cc=paul@crapouillou.net \ --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \ --cc=quic_jprakash@quicinc.com \ --cc=rafael@kernel.org \ --cc=rui.zhang@intel.com \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=sravanhome@gmail.com \ --cc=tali.perry1@gmail.com \ --cc=thara.gopinath@linaro.org \ --cc=tmaimon77@gmail.com \ --cc=venture@google.com \ --cc=yuenn@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.