All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Cc: Sven Schnelle <svens@linux.ibm.com>,
	Tzvetomir Stoyanov <tz.stoyanov@gmail.com>,
	linux-s390@vger.kernel.org
Subject: [PATCH] trace-cmd: Fix writing of uncompressed size
Date: Mon, 11 Jul 2022 14:21:04 -0400	[thread overview]
Message-ID: <20220711142104.090b9030@gandalf.local.home> (raw)

From: Sven Schnelle <svens@linux.ibm.com>

pointer in struct tracecmd_compression is 'unsigned long', which is 8 byte
in size on most platforms, but the tep_read_number() call in the next line
treats it as a 4 byte value. As there's no need for unsigned long change
the type to unsigned int.

Link: https://lore.kernel.org/all/20220711074418.858843-1-svens@linux.ibm.com/
Link: https://lore.kernel.org/all/20220711094340.2829115-1-svens@linux.ibm.com/

Fixes: 3f8447b1 ("trace-cmd library: Add support for compression algorithms")
Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 lib/trace-cmd/trace-compress.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/trace-cmd/trace-compress.c b/lib/trace-cmd/trace-compress.c
index a63295e..461de8d 100644
--- a/lib/trace-cmd/trace-compress.c
+++ b/lib/trace-cmd/trace-compress.c
@@ -32,7 +32,7 @@ struct tracecmd_compression {
 	int				fd;
 	unsigned int			capacity;
 	unsigned int			capacity_read;
-	unsigned long			pointer;
+	unsigned int			pointer;
 	char				*buffer;
 	struct compress_proto		*proto;
 	struct tep_handle		*tep;
-- 
2.36.1

             reply	other threads:[~2022-07-11 18:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-11 18:21 Steven Rostedt [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-07-11  7:44 [PATCH] trace-cmd: fix writing of uncompressed size Sven Schnelle
2022-07-11  8:55 ` Tzvetomir Stoyanov
2022-07-11  9:06   ` Sven Schnelle
2022-07-11  9:14   ` Sven Schnelle
2022-07-11  9:25     ` Tzvetomir Stoyanov
2022-07-11  9:34       ` Sven Schnelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220711142104.090b9030@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=svens@linux.ibm.com \
    --cc=tz.stoyanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.