All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Dooks <ben.dooks@sifive.com>
To: linux-riscv@lists.infradead.org
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Sudip Mukherjee <sudip.mukherjee@sifive.com>,
	Jude Onyenegecha <jude.onyenegecha@sifive.com>,
	Ben Dooks <ben.dooks@sifive.com>
Subject: [PATCH] riscv/vdso: fix missing vdso_data declaration
Date: Wed, 13 Jul 2022 23:06:45 +0100	[thread overview]
Message-ID: <20220713220645.105138-1-ben.dooks@sifive.com> (raw)

The vdso_data is defined by has no declaration as the
arch/riscv/kernel/vdso.c does not include asm/vdso/vsyscall.h
for the definition. Fix the following sparse warning by
adding in the asm/vdso/vsyscall.h

arch/riscv/kernel/vdso.c:42:18: warning: symbol 'vdso_data' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@sifive.com>
---
 arch/riscv/kernel/vdso.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/riscv/kernel/vdso.c b/arch/riscv/kernel/vdso.c
index 69b05b6c181b..7564f0208957 100644
--- a/arch/riscv/kernel/vdso.c
+++ b/arch/riscv/kernel/vdso.c
@@ -13,6 +13,7 @@
 #include <linux/err.h>
 #include <asm/page.h>
 #include <asm/vdso.h>
+#include <asm/vdso/vsyscall.h>
 #include <linux/time_namespace.h>
 
 #ifdef CONFIG_GENERIC_TIME_VSYSCALL
-- 
2.35.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

             reply	other threads:[~2022-07-13 22:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13 22:06 Ben Dooks [this message]
2022-07-14  6:34 ` [PATCH] riscv/vdso: fix missing vdso_data declaration Conor.Dooley
2022-08-11 21:06   ` Palmer Dabbelt
2022-08-11 21:26     ` Conor.Dooley
2022-08-14 16:10       ` Conor.Dooley
2022-08-18 23:01         ` Palmer Dabbelt
2022-08-19  7:08           ` Conor.Dooley
2022-09-15 18:51             ` Conor.Dooley
2022-10-05 14:13               ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220713220645.105138-1-ben.dooks@sifive.com \
    --to=ben.dooks@sifive.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=jude.onyenegecha@sifive.com \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=sudip.mukherjee@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.