All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anusha Srivatsa <anusha.srivatsa@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH] drm/i915/display: Cleanup intel_phy_is_combo()
Date: Mon, 18 Jul 2022 12:12:12 -0700	[thread overview]
Message-ID: <20220718191212.166141-1-anusha.srivatsa@intel.com> (raw)

No functional change. Cleanup the intel_phy_is_combo
to accomodate for cases where combo phy is not available.

Cc: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index a0f84cbe974f..b69208cf9a5e 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -2082,20 +2082,13 @@ bool intel_phy_is_combo(struct drm_i915_private *dev_priv, enum phy phy)
 {
 	if (phy == PHY_NONE)
 		return false;
-	else if (IS_DG2(dev_priv))
-		/*
-		 * DG2 outputs labelled as "combo PHY" in the bspec use
-		 * SNPS PHYs with completely different programming,
-		 * hence we always return false here.
-		 */
-		return false;
 	else if (IS_ALDERLAKE_S(dev_priv))
 		return phy <= PHY_E;
 	else if (IS_DG1(dev_priv) || IS_ROCKETLAKE(dev_priv))
 		return phy <= PHY_D;
 	else if (IS_JSL_EHL(dev_priv))
 		return phy <= PHY_C;
-	else if (DISPLAY_VER(dev_priv) >= 11)
+	else if (IS_ALDERLAKE_P(dev_priv) || IS_DISPLAY_VER(dev_priv, 11, 12))
 		return phy <= PHY_B;
 	else
 		return false;
-- 
2.25.1


             reply	other threads:[~2022-07-18 19:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18 19:12 Anusha Srivatsa [this message]
2022-07-18 20:11 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Cleanup intel_phy_is_combo() Patchwork
2022-07-18 20:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-07-19  1:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-07-19  3:31 ` [Intel-gfx] [PATCH] " Murthy, Arun R
2022-07-19 17:37   ` Srivatsa, Anusha
2022-07-20  2:34     ` Murthy, Arun R
2022-07-20 16:43       ` Srivatsa, Anusha
2022-07-21  3:39         ` Murthy, Arun R
2022-07-21 20:17 Anusha Srivatsa
2022-07-21 20:49 ` Matt Roper
2022-07-25 16:45   ` Srivatsa, Anusha
2022-07-25 20:40     ` Matt Roper
2022-07-24 12:30 ` Murthy, Arun R
2022-07-25 22:50 Anusha Srivatsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220718191212.166141-1-anusha.srivatsa@intel.com \
    --to=anusha.srivatsa@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.