From: Liang He <windhl@126.com>
To: rric@kernel.org, ulf.hansson@linaro.org,
linux-mmc@vger.kernel.org, windhl@126.com
Subject: [PATCH 1/2] mmc: cavium-octeon: Add of_node_put() when breaking out of loop
Date: Tue, 19 Jul 2022 17:52:15 +0800 [thread overview]
Message-ID: <20220719095216.1241601-1-windhl@126.com> (raw)
In octeon_mmc_probe(), we should call of_node_put() when breaking
out of for_each_child_of_node() which has increased and decreased
the refcount during each iteration.
Fixes: 01d95843335c ("mmc: cavium: Add MMC support for Octeon SOCs.")
Signed-off-by: Liang He <windhl@126.com>
---
drivers/mmc/host/cavium-octeon.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/cavium-octeon.c b/drivers/mmc/host/cavium-octeon.c
index 2c4b2df52adb..12dca91a8ef6 100644
--- a/drivers/mmc/host/cavium-octeon.c
+++ b/drivers/mmc/host/cavium-octeon.c
@@ -277,6 +277,7 @@ static int octeon_mmc_probe(struct platform_device *pdev)
if (ret) {
dev_err(&pdev->dev, "Error populating slots\n");
octeon_mmc_set_shared_power(host, 0);
+ of_node_put(cn);
goto error;
}
i++;
--
2.25.1
next reply other threads:[~2022-07-19 9:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 9:52 Liang He [this message]
2022-07-19 9:52 ` [PATCH 2/2] mmc: cavium-thunderx: Add of_node_put() when breaking out of loop Liang He
2022-07-20 11:35 ` Robert Richter
2022-07-21 16:13 ` Ulf Hansson
2022-07-20 11:35 ` [PATCH 1/2] mmc: cavium-octeon: " Robert Richter
2022-07-21 16:13 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719095216.1241601-1-windhl@126.com \
--to=windhl@126.com \
--cc=linux-mmc@vger.kernel.org \
--cc=rric@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.