From: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> To: intel-gfx@lists.freedesktop.org Cc: thomas.hellstrom@linux.intel.com, jani.nikula@intel.com, dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, airlied@linux.ie, matthew.auld@intel.com, mchehab@kernel.org, nirmoy.das@intel.com Subject: [Intel-gfx] [PATCH v4 6/7] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large Date: Tue, 19 Jul 2022 17:04:23 +0300 [thread overview] Message-ID: <20220719140424.430572-7-gwan-gyeong.mun@intel.com> (raw) In-Reply-To: <20220719140424.430572-1-gwan-gyeong.mun@intel.com> The ttm_bo_init_reserved() functions returns -ENOSPC if the size is too big to add vma. The direct function that returns -ENOSPC is drm_mm_insert_node_in_range(). To handle the same error as other code returning -E2BIG when the size is too large, it converts return value to -E2BIG. Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Matthew Auld <matthew.auld@intel.com> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> Reviewed-by: Nirmoy Das <nirmoy.das@intel.com> Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org> --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c index 88f2887627dc..4d478bf325be 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c @@ -1249,6 +1249,17 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem, ret = ttm_bo_init_reserved(&i915->bdev, i915_gem_to_ttm(obj), bo_type, &i915_sys_placement, page_size >> PAGE_SHIFT, &ctx, NULL, NULL, i915_ttm_bo_destroy); + + /* + * XXX: The ttm_bo_init_reserved() functions returns -ENOSPC if the size + * is too big to add vma. The direct function that returns -ENOSPC is + * drm_mm_insert_node_in_range(). To handle the same error as other code + * that returns -E2BIG when the size is too large, it converts -ENOSPC to + * -E2BIG. + */ + if (size >> PAGE_SHIFT > INT_MAX && ret == -ENOSPC) + ret = -E2BIG; + if (ret) return i915_ttm_err_to_gem(ret); -- 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> To: intel-gfx@lists.freedesktop.org Cc: thomas.hellstrom@linux.intel.com, jani.nikula@intel.com, dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, airlied@linux.ie, matthew.auld@intel.com, mchehab@kernel.org, nirmoy.das@intel.com Subject: [PATCH v4 6/7] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large Date: Tue, 19 Jul 2022 17:04:23 +0300 [thread overview] Message-ID: <20220719140424.430572-7-gwan-gyeong.mun@intel.com> (raw) In-Reply-To: <20220719140424.430572-1-gwan-gyeong.mun@intel.com> The ttm_bo_init_reserved() functions returns -ENOSPC if the size is too big to add vma. The direct function that returns -ENOSPC is drm_mm_insert_node_in_range(). To handle the same error as other code returning -E2BIG when the size is too large, it converts return value to -E2BIG. Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Matthew Auld <matthew.auld@intel.com> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> Reviewed-by: Nirmoy Das <nirmoy.das@intel.com> Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org> --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c index 88f2887627dc..4d478bf325be 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c @@ -1249,6 +1249,17 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem, ret = ttm_bo_init_reserved(&i915->bdev, i915_gem_to_ttm(obj), bo_type, &i915_sys_placement, page_size >> PAGE_SHIFT, &ctx, NULL, NULL, i915_ttm_bo_destroy); + + /* + * XXX: The ttm_bo_init_reserved() functions returns -ENOSPC if the size + * is too big to add vma. The direct function that returns -ENOSPC is + * drm_mm_insert_node_in_range(). To handle the same error as other code + * that returns -E2BIG when the size is too large, it converts -ENOSPC to + * -E2BIG. + */ + if (size >> PAGE_SHIFT > INT_MAX && ret == -ENOSPC) + ret = -E2BIG; + if (ret) return i915_ttm_err_to_gem(ret); -- 2.34.1
next prev parent reply other threads:[~2022-07-19 14:06 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-19 14:04 [PATCH v4 0/7] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation Gwan-gyeong Mun 2022-07-19 14:04 ` [Intel-gfx] " Gwan-gyeong Mun 2022-07-19 14:04 ` [PATCH v4 1/7] drm: Move and add a few utility macros into drm util header Gwan-gyeong Mun 2022-07-19 14:04 ` [Intel-gfx] " Gwan-gyeong Mun 2022-08-11 16:29 ` Daniel Vetter 2022-08-11 16:29 ` [Intel-gfx] " Daniel Vetter 2022-08-11 19:12 ` Jani Nikula 2022-08-11 19:12 ` Jani Nikula 2022-07-19 14:04 ` [PATCH v4 2/7] drm/i915/gem: Typecheck page lookups Gwan-gyeong Mun 2022-07-19 14:04 ` [Intel-gfx] " Gwan-gyeong Mun 2022-07-19 14:04 ` [PATCH v4 3/7] drm/i915: Check for integer truncation on scatterlist creation Gwan-gyeong Mun 2022-07-19 14:04 ` [Intel-gfx] " Gwan-gyeong Mun 2022-07-19 14:04 ` [Intel-gfx] [PATCH v4 4/7] drm/i915: Check for integer truncation on the configuration of ttm place Gwan-gyeong Mun 2022-07-19 14:04 ` Gwan-gyeong Mun 2022-07-19 14:04 ` [PATCH v4 5/7] drm/i915: Check if the size is too big while creating shmem file Gwan-gyeong Mun 2022-07-19 14:04 ` [Intel-gfx] " Gwan-gyeong Mun 2022-07-19 14:04 ` Gwan-gyeong Mun [this message] 2022-07-19 14:04 ` [PATCH v4 6/7] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large Gwan-gyeong Mun 2022-07-19 14:04 ` [Intel-gfx] [PATCH v4 7/7] drm/i915: Remove truncation warning for large objects Gwan-gyeong Mun 2022-07-19 14:04 ` Gwan-gyeong Mun 2022-07-19 16:04 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation (rev6) Patchwork 2022-07-19 16:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2022-07-20 2:01 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2022-07-20 5:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation (rev7) Patchwork 2022-07-20 5:32 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2022-07-20 5:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2022-07-20 17:03 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2022-07-21 14:38 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation (rev8) Patchwork 2022-07-21 14:38 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2022-07-21 15:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2022-07-21 21:47 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2022-07-22 7:40 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation (rev9) Patchwork 2022-07-22 7:40 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2022-07-22 8:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2022-07-22 9:53 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220719140424.430572-7-gwan-gyeong.mun@intel.com \ --to=gwan-gyeong.mun@intel.com \ --cc=airlied@linux.ie \ --cc=chris@chris-wilson.co.uk \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@intel.com \ --cc=matthew.auld@intel.com \ --cc=mchehab@kernel.org \ --cc=nirmoy.das@intel.com \ --cc=thomas.hellstrom@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.