All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	broonie@kernel.org,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	Yong Zhi <yong.zhi@intel.com>
Subject: [PATCH 10/10] ASoC: Intel: sof_nau8825: Move quirk check to the front in late probe
Date: Mon, 25 Jul 2022 14:49:09 -0500	[thread overview]
Message-ID: <20220725194909.145418-11-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20220725194909.145418-1-pierre-louis.bossart@linux.intel.com>

From: Yong Zhi <yong.zhi@intel.com>

The sof_rt5682_quirk check was placed in the middle of
hdmi handling code, move it to the front to be consistent
with sof_rt5682.c/sof_card_late_probe().

Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Yong Zhi <yong.zhi@intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/intel/boards/sof_nau8825.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/sound/soc/intel/boards/sof_nau8825.c b/sound/soc/intel/boards/sof_nau8825.c
index f49700eb721b..8d7e5ba9e516 100644
--- a/sound/soc/intel/boards/sof_nau8825.c
+++ b/sound/soc/intel/boards/sof_nau8825.c
@@ -190,11 +190,6 @@ static int sof_card_late_probe(struct snd_soc_card *card)
 	struct sof_hdmi_pcm *pcm;
 	int err;
 
-	if (list_empty(&ctx->hdmi_pcm_list))
-		return -EINVAL;
-
-	pcm = list_first_entry(&ctx->hdmi_pcm_list, struct sof_hdmi_pcm, head);
-
 	if (sof_nau8825_quirk & SOF_MAX98373_SPEAKER_AMP_PRESENT) {
 		/* Disable Left and Right Spk pin after boot */
 		snd_soc_dapm_disable_pin(dapm, "Left Spk");
@@ -204,6 +199,11 @@ static int sof_card_late_probe(struct snd_soc_card *card)
 			return err;
 	}
 
+	if (list_empty(&ctx->hdmi_pcm_list))
+		return -EINVAL;
+
+	pcm = list_first_entry(&ctx->hdmi_pcm_list, struct sof_hdmi_pcm, head);
+
 	return hda_dsp_hdmi_build_controls(card, pcm->codec_dai->component);
 }
 
-- 
2.34.1


  parent reply	other threads:[~2022-07-25 19:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-25 19:48 [PATCH 00/10] ASoC: Intel: machine driver updates for 5.20 Pierre-Louis Bossart
2022-07-25 19:49 ` [PATCH 01/10] ASoC: Intel: sof_sdw: add support for Dell SKU 0AF0 Pierre-Louis Bossart
2022-07-25 19:49 ` [PATCH 02/10] ASoC: Intel: soc-acpi: Add entry for sof_es8336 in ADL match table Pierre-Louis Bossart
2022-07-25 19:49 ` [PATCH 03/10] ASoC: Intel: sof_es8336: Fix GPIO quirks set via module option Pierre-Louis Bossart
2022-07-25 19:49 ` [PATCH 04/10] ASoC: Intel: sof_es8336: ignore GpioInt when looking for speaker/headset GPIO lines Pierre-Louis Bossart
2022-07-25 19:49 ` [PATCH 05/10] ASoC: Intel: sof_es8336: add support for HDMI_In capture Pierre-Louis Bossart
2022-07-25 19:49 ` [PATCH 06/10] ASoC: Intel: sof_es8336: reset the num_links during probe Pierre-Louis Bossart
2022-07-25 19:49 ` [PATCH 07/10] ASoC: Intel: sof_es8336: remove hard-coded SSP selection Pierre-Louis Bossart
2022-07-25 19:49 ` [PATCH 08/10] ASoC: Intel: sof_rt5682: Add support for mtl_mx98357_rt5682 Pierre-Louis Bossart
2022-07-25 19:49 ` [PATCH 09/10] ASoC: Intel: sof_rt5682: Perform quirk check first in card late probe Pierre-Louis Bossart
2022-07-25 19:49 ` Pierre-Louis Bossart [this message]
2022-07-26 11:30 ` [PATCH 00/10] ASoC: Intel: machine driver updates for 5.20 Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220725194909.145418-11-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=yong.zhi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.