From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com, "Alex Bennée" <alex.bennee@linaro.org>,
"Jason Wang" <jasowang@redhat.com>
Subject: [PATCH v2 4/4] hw/virtio: fix vhost_user_read tracepoint
Date: Thu, 28 Jul 2022 14:55:03 +0100 [thread overview]
Message-ID: <20220728135503.1060062-5-alex.bennee@linaro.org> (raw)
In-Reply-To: <20220728135503.1060062-1-alex.bennee@linaro.org>
As reads happen in the callback we were never seeing them. We only
really care about the header so move the tracepoint to when the header
is complete.
Fixes: 6ca6d8ee9d (hw/virtio: add vhost_user_[read|write] trace points)
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Acked-by: Jason Wang <jasowang@redhat.com>
Message-Id: <20220726192150.2435175-10-alex.bennee@linaro.org>
---
hw/virtio/vhost-user.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index 1936a44e82..c0b50deaf2 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -295,6 +295,8 @@ static int vhost_user_read_header(struct vhost_dev *dev, VhostUserMsg *msg)
return -EPROTO;
}
+ trace_vhost_user_read(msg->hdr.request, msg->hdr.flags);
+
return 0;
}
@@ -544,8 +546,6 @@ static int vhost_user_set_log_base(struct vhost_dev *dev, uint64_t base,
}
}
- trace_vhost_user_read(msg.hdr.request, msg.hdr.flags);
-
return 0;
}
--
2.30.2
prev parent reply other threads:[~2022-07-28 14:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 13:54 [PATCH for 7.1 v2 0/4] virtio fixes (split from virtio-gpio series) Alex Bennée
2022-07-28 13:55 ` [PATCH v2 1/4] hw/virtio: incorporate backend features in features Alex Bennée
2022-08-17 11:00 ` Michael S. Tsirkin
2022-10-26 6:11 ` Yajun Wu
2022-10-26 7:41 ` Alex Bennée
2022-11-10 10:35 ` Yajun Wu
2022-07-28 13:55 ` [PATCH v2 2/4] hw/virtio: gracefully handle unset vhost_dev vdev Alex Bennée
2022-08-17 11:01 ` Michael S. Tsirkin
2022-08-18 6:35 ` Alex Bennée
2022-07-28 13:55 ` [PATCH v2 3/4] hw/virtio: handle un-configured shutdown in virtio-pci Alex Bennée
2022-07-28 13:55 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220728135503.1060062-5-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.