From: Ricardo Koller <ricarkol@google.com> To: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, andrew.jones@linux.dev Cc: maz@kernel.org, alexandru.elisei@arm.com, eric.auger@redhat.com, oliver.upton@linux.dev, reijiw@google.com, Ricardo Koller <ricarkol@google.com> Subject: [kvm-unit-tests PATCH v2 0/3] arm: pmu: Fixes for bare metal Date: Wed, 3 Aug 2022 11:23:25 -0700 [thread overview] Message-ID: <20220803182328.2438598-1-ricarkol@google.com> (raw) There are some tests that fail when running on bare metal (including a passthrough prototype). There are three issues with the tests. The first one is that there are some missing isb()'s between enabling event counting and the actual counting. This wasn't an issue on KVM as trapping on registers served as context synchronization events. The second issue is that some tests assume that registers reset to 0. And finally, the third issue is that overflowing the low counter of a chained event sets the overflow flag in PMVOS and some tests fail by checking for it not being set. Addressed all comments from the previous version: - added some isb()'s as suggested by Alexandru. - fixed a couple of confusing comments (Alexandru). - check for overflow in the low counter in the interrupt_overflow test (Marc). Thanks! Ricardo Ricardo Koller (3): arm: pmu: Add missing isb()'s after sys register writing arm: pmu: Reset the pmu registers before starting some tests arm: pmu: Check for overflow in the low counter in chained counters tests arm/pmu.c | 55 ++++++++++++++++++++++++++++++++++++++----------------- 1 file changed, 38 insertions(+), 17 deletions(-) -- 2.37.1.455.g008518b4e5-goog
WARNING: multiple messages have this Message-ID (diff)
From: Ricardo Koller <ricarkol@google.com> To: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, andrew.jones@linux.dev Cc: maz@kernel.org Subject: [kvm-unit-tests PATCH v2 0/3] arm: pmu: Fixes for bare metal Date: Wed, 3 Aug 2022 11:23:25 -0700 [thread overview] Message-ID: <20220803182328.2438598-1-ricarkol@google.com> (raw) There are some tests that fail when running on bare metal (including a passthrough prototype). There are three issues with the tests. The first one is that there are some missing isb()'s between enabling event counting and the actual counting. This wasn't an issue on KVM as trapping on registers served as context synchronization events. The second issue is that some tests assume that registers reset to 0. And finally, the third issue is that overflowing the low counter of a chained event sets the overflow flag in PMVOS and some tests fail by checking for it not being set. Addressed all comments from the previous version: - added some isb()'s as suggested by Alexandru. - fixed a couple of confusing comments (Alexandru). - check for overflow in the low counter in the interrupt_overflow test (Marc). Thanks! Ricardo Ricardo Koller (3): arm: pmu: Add missing isb()'s after sys register writing arm: pmu: Reset the pmu registers before starting some tests arm: pmu: Check for overflow in the low counter in chained counters tests arm/pmu.c | 55 ++++++++++++++++++++++++++++++++++++++----------------- 1 file changed, 38 insertions(+), 17 deletions(-) -- 2.37.1.455.g008518b4e5-goog _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next reply other threads:[~2022-08-03 18:23 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-03 18:23 Ricardo Koller [this message] 2022-08-03 18:23 ` [kvm-unit-tests PATCH v2 0/3] arm: pmu: Fixes for bare metal Ricardo Koller 2022-08-03 18:23 ` [kvm-unit-tests PATCH v2 1/3] arm: pmu: Add missing isb()'s after sys register writing Ricardo Koller 2022-08-03 18:23 ` Ricardo Koller 2022-08-04 8:55 ` Alexandru Elisei 2022-08-04 8:55 ` Alexandru Elisei 2022-08-05 0:42 ` Ricardo Koller 2022-08-05 0:42 ` Ricardo Koller 2022-08-03 18:23 ` [kvm-unit-tests PATCH v2 2/3] arm: pmu: Reset the pmu registers before starting some tests Ricardo Koller 2022-08-03 18:23 ` Ricardo Koller 2022-08-04 18:21 ` Eric Auger 2022-08-04 18:21 ` Eric Auger 2022-08-03 18:23 ` [kvm-unit-tests PATCH v2 3/3] arm: pmu: Check for overflow in the low counter in chained counters tests Ricardo Koller 2022-08-03 18:23 ` Ricardo Koller 2022-08-04 8:18 ` Andrew Jones 2022-08-04 8:18 ` Andrew Jones 2022-08-05 0:43 ` Ricardo Koller 2022-08-05 0:43 ` Ricardo Koller 2022-08-04 18:21 ` Eric Auger 2022-08-04 18:21 ` Eric Auger 2022-08-08 10:40 ` Marc Zyngier 2022-08-08 10:40 ` Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220803182328.2438598-1-ricarkol@google.com \ --to=ricarkol@google.com \ --cc=alexandru.elisei@arm.com \ --cc=andrew.jones@linux.dev \ --cc=eric.auger@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=maz@kernel.org \ --cc=oliver.upton@linux.dev \ --cc=reijiw@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.