From: Bo Liu <liubo03@inspur.com>
To: <dan.j.williams@intel.com>, <vishal.l.verma@intel.com>,
<dave.jiang@intel.com>
Cc: <nvdimm@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
Bo Liu <liubo03@inspur.com>
Subject: [PATCH] dax: Check dev_set_name() return value
Date: Fri, 5 Aug 2022 01:33:19 -0400 [thread overview]
Message-ID: <20220805053319.3865-1-liubo03@inspur.com> (raw)
It's possible that dev_set_name() returns -ENOMEM, catch and handle this.
Signed-off-by: Bo Liu <liubo03@inspur.com>
---
drivers/dax/bus.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
index 1dad813ee4a6..36cf245ee467 100644
--- a/drivers/dax/bus.c
+++ b/drivers/dax/bus.c
@@ -765,7 +765,12 @@ static int devm_register_dax_mapping(struct dev_dax *dev_dax, int range_id)
device_initialize(dev);
dev->parent = &dev_dax->dev;
dev->type = &dax_mapping_type;
- dev_set_name(dev, "mapping%d", mapping->id);
+ rc = dev_set_name(dev, "mapping%d", mapping->id);
+ if (rc) {
+ kfree(mapping);
+ return rc;
+ }
+
rc = device_add(dev);
if (rc) {
put_device(dev);
@@ -1334,7 +1339,9 @@ struct dev_dax *devm_create_dev_dax(struct dev_dax_data *data)
dev_dax->region = dax_region;
dev = &dev_dax->dev;
device_initialize(dev);
- dev_set_name(dev, "dax%d.%d", dax_region->id, dev_dax->id);
+ rc = dev_set_name(dev, "dax%d.%d", dax_region->id, dev_dax->id);
+ if (rc)
+ goto err_range;
rc = alloc_dev_dax_range(dev_dax, dax_region->res.start, data->size);
if (rc)
--
2.27.0
next reply other threads:[~2022-08-05 5:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 5:33 Bo Liu [this message]
2022-08-05 18:31 ` [PATCH] dax: Check dev_set_name() return value Ira Weiny
2022-09-20 17:38 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220805053319.3865-1-liubo03@inspur.com \
--to=liubo03@inspur.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.