All of lore.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <mail@conchuod.ie>
To: Palmer Dabbelt <palmer@dabbelt.com>,
	Alistair Francis <alistair.francis@wdc.com>,
	Bin Meng <bin.meng@windriver.com>
Cc: Rob Herring <robh@kernel.org>,
	Conor Dooley <conor.dooley@microchip.com>,
	qemu-riscv@nongnu.org, qemu-devel@nongnu.org,
	linux-riscv@lists.infradead.org
Subject: [PATCH 5/5] hw/core: fix platform bus node name
Date: Fri,  5 Aug 2022 16:54:05 +0100	[thread overview]
Message-ID: <20220805155405.1504081-6-mail@conchuod.ie> (raw)
In-Reply-To: <20220805155405.1504081-1-mail@conchuod.ie>

From: Conor Dooley <conor.dooley@microchip.com>

"platform" is not a valid name for a bus node in dt-schema, so warnings
can be see in dt-validate on a dump of the riscv virt dtb:

/stuff/qemu/qemu.dtb: platform@4000000: $nodename:0: 'platform@4000000' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
        From schema: /home/conor/.local/lib/python3.9/site-packages/dtschema/schemas/simple-bus.yaml
"platform-bus" is a valid name, so use that instead.

CC: Rob Herring <robh@kernel.org>
Fixes: 11d306b9df ("hw/arm/sysbus-fdt: helpers for platform bus nodes addition")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
 hw/core/sysbus-fdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/core/sysbus-fdt.c b/hw/core/sysbus-fdt.c
index 19d22cbe73..edb0c49b19 100644
--- a/hw/core/sysbus-fdt.c
+++ b/hw/core/sysbus-fdt.c
@@ -539,7 +539,7 @@ void platform_bus_add_all_fdt_nodes(void *fdt, const char *intc, hwaddr addr,
 
     assert(fdt);
 
-    node = g_strdup_printf("/platform@%"PRIx64, addr);
+    node = g_strdup_printf("/platform-bus@%"PRIx64, addr);
 
     /* Create a /platform node that we can put all devices into */
     qemu_fdt_add_subnode(fdt, node);
-- 
2.37.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <mail@conchuod.ie>
To: Palmer Dabbelt <palmer@dabbelt.com>,
	Alistair Francis <alistair.francis@wdc.com>,
	Bin Meng <bin.meng@windriver.com>
Cc: Rob Herring <robh@kernel.org>,
	Conor Dooley <conor.dooley@microchip.com>,
	qemu-riscv@nongnu.org, qemu-devel@nongnu.org,
	linux-riscv@lists.infradead.org
Subject: [PATCH 5/5] hw/core: fix platform bus node name
Date: Fri,  5 Aug 2022 16:54:05 +0100	[thread overview]
Message-ID: <20220805155405.1504081-6-mail@conchuod.ie> (raw)
In-Reply-To: <20220805155405.1504081-1-mail@conchuod.ie>

From: Conor Dooley <conor.dooley@microchip.com>

"platform" is not a valid name for a bus node in dt-schema, so warnings
can be see in dt-validate on a dump of the riscv virt dtb:

/stuff/qemu/qemu.dtb: platform@4000000: $nodename:0: 'platform@4000000' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
        From schema: /home/conor/.local/lib/python3.9/site-packages/dtschema/schemas/simple-bus.yaml
"platform-bus" is a valid name, so use that instead.

CC: Rob Herring <robh@kernel.org>
Fixes: 11d306b9df ("hw/arm/sysbus-fdt: helpers for platform bus nodes addition")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
 hw/core/sysbus-fdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/core/sysbus-fdt.c b/hw/core/sysbus-fdt.c
index 19d22cbe73..edb0c49b19 100644
--- a/hw/core/sysbus-fdt.c
+++ b/hw/core/sysbus-fdt.c
@@ -539,7 +539,7 @@ void platform_bus_add_all_fdt_nodes(void *fdt, const char *intc, hwaddr addr,
 
     assert(fdt);
 
-    node = g_strdup_printf("/platform@%"PRIx64, addr);
+    node = g_strdup_printf("/platform-bus@%"PRIx64, addr);
 
     /* Create a /platform node that we can put all devices into */
     qemu_fdt_add_subnode(fdt, node);
-- 
2.37.1



  parent reply	other threads:[~2022-08-05 16:02 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05 15:54 [PATCH 0/5] QEMU: Fix RISC-V virt & spike machines' dtbs Conor Dooley
2022-08-05 15:54 ` Conor Dooley
2022-08-05 15:54 ` [PATCH 1/5] target/riscv: Ignore the S and U letters when formatting ISA strings Conor Dooley
2022-08-05 15:54   ` Conor Dooley
2022-08-07 22:53   ` Alistair Francis
2022-08-07 22:53     ` Alistair Francis
2022-08-08  6:25     ` Conor.Dooley
2022-08-08  6:25       ` Conor.Dooley
2022-08-08 15:03   ` Tsukasa OI
2022-08-08 15:03     ` Tsukasa OI
2022-08-08 16:14     ` Conor.Dooley
2022-08-08 16:14       ` Conor.Dooley
2022-08-08 20:51       ` Alistair Francis
2022-08-08 20:51         ` Alistair Francis
2022-08-08 20:53         ` Conor.Dooley
2022-08-08 20:53           ` Conor.Dooley
2022-08-05 15:54 ` [PATCH 2/5] hw/riscv: virt: fix uart node name Conor Dooley
2022-08-05 15:54   ` Conor Dooley
2022-08-07 22:55   ` Alistair Francis
2022-08-07 22:55     ` Alistair Francis
2022-08-05 15:54 ` [PATCH 3/5] hw/riscv: virt: Fix the plic's address cells Conor Dooley
2022-08-05 15:54   ` Conor Dooley
2022-08-07 22:55   ` Alistair Francis
2022-08-07 22:55     ` Alistair Francis
2022-08-05 15:54 ` [PATCH 4/5] hw/riscv: virt: fix syscon subnode paths Conor Dooley
2022-08-05 15:54   ` Conor Dooley
2022-08-07 22:56   ` Alistair Francis
2022-08-07 22:56     ` Alistair Francis
2022-08-05 15:54 ` Conor Dooley [this message]
2022-08-05 15:54   ` [PATCH 5/5] hw/core: fix platform bus node name Conor Dooley
2022-08-07 22:57   ` Alistair Francis
2022-08-07 22:57     ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220805155405.1504081-6-mail@conchuod.ie \
    --to=mail@conchuod.ie \
    --cc=alistair.francis@wdc.com \
    --cc=bin.meng@windriver.com \
    --cc=conor.dooley@microchip.com \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.