All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, den@virtuozzo.com, stefanha@redhat.com,
	vsementsov@yandex-team.ru, kwolf@redhat.com, hreitz@redhat.com
Subject: [PATCH 9/9] parallels: Merge parallels_check_fragmentation to parallels_collect_statistics
Date: Mon,  8 Aug 2022 14:07:34 +0200	[thread overview]
Message-ID: <20220808120734.1168314-10-alexander.ivanov@virtuozzo.com> (raw)
In-Reply-To: <20220808120734.1168314-1-alexander.ivanov@virtuozzo.com>

Frgamentation is a part of statistics so it is better to count the statistics
in one function.

Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
 block/parallels.c | 31 ++++++++-----------------------
 1 file changed, 8 insertions(+), 23 deletions(-)

diff --git a/block/parallels.c b/block/parallels.c
index 38b1482e81..11597c5dc4 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -530,13 +530,16 @@ static int parallels_check_leak(BlockDriverState *bs,
     return 0;
 }
 
-static void parallels_check_fragmentation(BlockDriverState *bs,
-                                          BdrvCheckResult *res,
-                                          BdrvCheckMode fix)
+static void parallels_collect_statistics(BlockDriverState *bs,
+                                         BdrvCheckResult *res,
+                                         BdrvCheckMode fix)
 {
     BDRVParallelsState *s = bs->opaque;
-    uint32_t i;
     int64_t off, prev_off;
+    uint32_t i;
+
+    res->bfi.total_clusters = s->bat_size;
+    res->bfi.compressed_clusters = 0; /* compression is not supported */
 
     prev_off = 0;
     for (i = 0; i < s->bat_size; i++) {
@@ -549,24 +552,8 @@ static void parallels_check_fragmentation(BlockDriverState *bs,
             res->bfi.fragmented_clusters++;
         }
         prev_off = off;
-    }
 
-}
-
-static void parallels_collect_statistics(BlockDriverState *bs,
-                                         BdrvCheckResult *res,
-                                         BdrvCheckMode fix)
-{
-    BDRVParallelsState *s = bs->opaque;
-    uint32_t i;
-
-    res->bfi.total_clusters = s->bat_size;
-    res->bfi.compressed_clusters = 0; /* compression is not supported */
-
-    for (i = 0; i < s->bat_size; i++) {
-        if (bat2sect(s, i) != 0) {
-            res->bfi.allocated_clusters++;
-        }
+        res->bfi.allocated_clusters++;
     }
 }
 
@@ -591,8 +578,6 @@ static int coroutine_fn parallels_co_check(BlockDriverState *bs,
         return ret;
     }
 
-    parallels_check_fragmentation(bs, res, fix);
-
     parallels_collect_statistics(bs, res, fix);
 
     return 0;
-- 
2.34.1



  parent reply	other threads:[~2022-08-08 12:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 12:07 [PATCH 0/9] parallels: Refactor the code of images checks and fix a bug Alexander Ivanov
2022-08-08 12:07 ` [PATCH 1/9] parallels: Move check of unclean image to a separate function Alexander Ivanov
2022-08-08 12:32   ` Denis V. Lunev
2022-08-08 12:07 ` [PATCH 2/9] parallels: Move check of cluster outside " Alexander Ivanov
2022-08-08 12:19   ` Denis V. Lunev
2022-08-08 12:31     ` Denis V. Lunev
2022-08-08 12:07 ` [PATCH 3/9] parallels: Move check of leaks " Alexander Ivanov
2022-08-08 12:07 ` [PATCH 4/9] parallels: Move check of fragmentation " Alexander Ivanov
2022-08-08 12:07 ` [PATCH 5/9] parallels: Move statistic collection " Alexander Ivanov
2022-08-08 12:18   ` Denis V. Lunev
2022-08-08 12:07 ` [PATCH 6/9] parallels: Replace qemu_co_mutex_lock by WITH_QEMU_LOCK_GUARD Alexander Ivanov
2022-08-08 12:07 ` [PATCH 7/9] parallels: Out of image offset in BAT leads to image inflation Alexander Ivanov
2022-08-08 12:43   ` Denis V. Lunev
2022-08-08 12:07 ` [PATCH 8/9] parallels: Replace bdrv_co_pwrite_sync by bdrv_co_flush for BAT flushing Alexander Ivanov
2022-08-08 12:24   ` Denis V. Lunev
2022-08-08 12:07 ` Alexander Ivanov [this message]
2022-08-08 12:26   ` [PATCH 9/9] parallels: Merge parallels_check_fragmentation to parallels_collect_statistics Denis V. Lunev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220808120734.1168314-10-alexander.ivanov@virtuozzo.com \
    --to=alexander.ivanov@virtuozzo.com \
    --cc=den@virtuozzo.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.