All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin Povišer" <povik+lin@cutebit.org>
To: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, "Stephen Kitt" <steve@sk2.org>,
	linux-kernel@vger.kernel.org,
	"Frank Shi" <shifu0704@thundersoft.com>,
	asahi@lists.linux.dev, "Martin Povišer" <povik+lin@cutebit.org>
Subject: [PATCH 2/4] ASoC: tas2770: Allow mono streams
Date: Mon,  8 Aug 2022 16:12:44 +0200	[thread overview]
Message-ID: <20220808141246.5749-3-povik+lin@cutebit.org> (raw)
In-Reply-To: <20220808141246.5749-1-povik+lin@cutebit.org>

The part is a mono speaker amp, but it can do downmix and switch between
left and right channel, so the right channel range is 1 to 2.

Fixes: 1a476abc723e ("tas2770: add tas2770 smart PA kernel driver")
Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
---
 sound/soc/codecs/tas2770.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/tas2770.c b/sound/soc/codecs/tas2770.c
index 10b64d5ba756..db446db88df5 100644
--- a/sound/soc/codecs/tas2770.c
+++ b/sound/soc/codecs/tas2770.c
@@ -507,7 +507,7 @@ static struct snd_soc_dai_driver tas2770_dai_driver[] = {
 		.id = 0,
 		.playback = {
 			.stream_name    = "ASI1 Playback",
-			.channels_min   = 2,
+			.channels_min   = 1,
 			.channels_max   = 2,
 			.rates      = TAS2770_RATES,
 			.formats    = TAS2770_FORMATS,
-- 
2.33.0


WARNING: multiple messages have this Message-ID (diff)
From: "Martin Povišer" <povik+lin@cutebit.org>
To: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>
Cc: "Martin Povišer" <povik+lin@cutebit.org>,
	"Stephen Kitt" <steve@sk2.org>,
	"Frank Shi" <shifu0704@thundersoft.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	asahi@lists.linux.dev
Subject: [PATCH 2/4] ASoC: tas2770: Allow mono streams
Date: Mon,  8 Aug 2022 16:12:44 +0200	[thread overview]
Message-ID: <20220808141246.5749-3-povik+lin@cutebit.org> (raw)
In-Reply-To: <20220808141246.5749-1-povik+lin@cutebit.org>

The part is a mono speaker amp, but it can do downmix and switch between
left and right channel, so the right channel range is 1 to 2.

Fixes: 1a476abc723e ("tas2770: add tas2770 smart PA kernel driver")
Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
---
 sound/soc/codecs/tas2770.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/tas2770.c b/sound/soc/codecs/tas2770.c
index 10b64d5ba756..db446db88df5 100644
--- a/sound/soc/codecs/tas2770.c
+++ b/sound/soc/codecs/tas2770.c
@@ -507,7 +507,7 @@ static struct snd_soc_dai_driver tas2770_dai_driver[] = {
 		.id = 0,
 		.playback = {
 			.stream_name    = "ASI1 Playback",
-			.channels_min   = 2,
+			.channels_min   = 1,
 			.channels_max   = 2,
 			.rates      = TAS2770_RATES,
 			.formats    = TAS2770_FORMATS,
-- 
2.33.0


  parent reply	other threads:[~2022-08-08 14:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 14:12 [PATCH 0/4] TAS2770 fixes Martin Povišer
2022-08-08 14:12 ` Martin Povišer
2022-08-08 14:12 ` [PATCH 1/4] ASoC: tas2770: Set correct FSYNC polarity Martin Povišer
2022-08-08 14:12   ` Martin Povišer
2022-08-08 14:12 ` Martin Povišer [this message]
2022-08-08 14:12   ` [PATCH 2/4] ASoC: tas2770: Allow mono streams Martin Povišer
2022-08-08 14:12 ` [PATCH 3/4] ASoC: tas2770: Drop conflicting set_bias_level power setting Martin Povišer
2022-08-08 14:12   ` Martin Povišer
2022-08-08 14:12 ` [PATCH 4/4] ASoC: tas2770: Fix handling of mute/unmute Martin Povišer
2022-08-08 14:12   ` Martin Povišer
2022-08-08 16:23   ` Martin Povišer
2022-08-08 16:23     ` Martin Povišer
2022-08-10 12:44 ` [PATCH 0/4] TAS2770 fixes Mark Brown
2022-08-10 12:44   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220808141246.5749-3-povik+lin@cutebit.org \
    --to=povik+lin@cutebit.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=asahi@lists.linux.dev \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=shifu0704@thundersoft.com \
    --cc=steve@sk2.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.