All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: Mike Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-clk@vger.kernel.org
Cc: Jerome Brunet <jbrunet@baylibre.com>,
	Naresh Kamboju <naresh.kamboju@linaro.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Alexander Stein <alexander.stein@ew.tq-group.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Yassine Oudjana <y.oudjana@protonmail.com>,
	Tony Lindgren <tony@atomide.com>,
	Maxime Ripard <maxime@cerno.tech>
Subject: [PATCH v9 16/25] clk: Introduce clk_hw_init_rate_request()
Date: Tue, 16 Aug 2022 13:25:21 +0200	[thread overview]
Message-ID: <20220816112530.1837489-17-maxime@cerno.tech> (raw)
In-Reply-To: <20220816112530.1837489-1-maxime@cerno.tech>

clk-divider instantiates clk_rate_request internally for its round_rate
implementations to share the code with its determine_rate
implementations.

However, it's missing a few fields (min_rate, max_rate) that would be
initialized properly if it was using clk_core_init_rate_req().

Let's create the clk_hw_init_rate_request() function for clock providers
to be able to share the code to instation clk_rate_requests with the
framework. This will also be useful for some tests introduced in later
patches.

Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com> # imx8mp
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> # exynos4210, meson g12b
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 drivers/clk/clk-divider.c    | 20 ++++++++++----------
 drivers/clk/clk.c            | 20 ++++++++++++++++++++
 include/linux/clk-provider.h |  6 ++++++
 3 files changed, 36 insertions(+), 10 deletions(-)

diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c
index f6b2bf558486..a2c2b5203b0a 100644
--- a/drivers/clk/clk-divider.c
+++ b/drivers/clk/clk-divider.c
@@ -386,13 +386,13 @@ long divider_round_rate_parent(struct clk_hw *hw, struct clk_hw *parent,
 			       const struct clk_div_table *table,
 			       u8 width, unsigned long flags)
 {
-	struct clk_rate_request req = {
-		.rate = rate,
-		.best_parent_rate = *prate,
-		.best_parent_hw = parent,
-	};
+	struct clk_rate_request req;
 	int ret;
 
+	clk_hw_init_rate_request(hw, &req, rate);
+	req.best_parent_rate = *prate;
+	req.best_parent_hw = parent;
+
 	ret = divider_determine_rate(hw, &req, table, width, flags);
 	if (ret)
 		return ret;
@@ -408,13 +408,13 @@ long divider_ro_round_rate_parent(struct clk_hw *hw, struct clk_hw *parent,
 				  const struct clk_div_table *table, u8 width,
 				  unsigned long flags, unsigned int val)
 {
-	struct clk_rate_request req = {
-		.rate = rate,
-		.best_parent_rate = *prate,
-		.best_parent_hw = parent,
-	};
+	struct clk_rate_request req;
 	int ret;
 
+	clk_hw_init_rate_request(hw, &req, rate);
+	req.best_parent_rate = *prate;
+	req.best_parent_hw = parent;
+
 	ret = divider_ro_determine_rate(hw, &req, table, width, flags, val);
 	if (ret)
 		return ret;
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 553e1e9eb300..96b372ff23c2 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -1400,6 +1400,26 @@ static void clk_core_init_rate_req(struct clk_core * const core,
 	}
 }
 
+/**
+ * clk_hw_init_rate_request - Initializes a clk_rate_request
+ * @hw: the clk for which we want to submit a rate request
+ * @req: the clk_rate_request structure we want to initialise
+ * @rate: the rate which is to be requested
+ *
+ * Initializes a clk_rate_request structure to submit to
+ * __clk_determine_rate() or similar functions.
+ */
+void clk_hw_init_rate_request(const struct clk_hw *hw,
+			      struct clk_rate_request *req,
+			      unsigned long rate)
+{
+	if (WARN_ON(!hw || !req))
+		return;
+
+	clk_core_init_rate_req(hw->core, req, rate);
+}
+EXPORT_SYMBOL_GPL(clk_hw_init_rate_request);
+
 static bool clk_core_can_round(struct clk_core * const core)
 {
 	return core->ops->determine_rate || core->ops->round_rate;
diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
index 9a14cfa0d201..d857717aa386 100644
--- a/include/linux/clk-provider.h
+++ b/include/linux/clk-provider.h
@@ -42,6 +42,8 @@ struct dentry;
  * struct clk_rate_request - Structure encoding the clk constraints that
  * a clock user might require.
  *
+ * Should be initialized by calling clk_hw_init_rate_request().
+ *
  * @rate:		Requested clock rate. This field will be adjusted by
  *			clock drivers according to hardware capabilities.
  * @min_rate:		Minimum rate imposed by clk users.
@@ -60,6 +62,10 @@ struct clk_rate_request {
 	struct clk_hw *best_parent_hw;
 };
 
+void clk_hw_init_rate_request(const struct clk_hw *hw,
+			      struct clk_rate_request *req,
+			      unsigned long rate);
+
 /**
  * struct clk_duty - Struture encoding the duty cycle ratio of a clock
  *
-- 
2.37.1


  parent reply	other threads:[~2022-08-16 11:52 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16 11:25 [PATCH v9 00/25] clk: More clock rate fixes and tests Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 01/25] clk: test: Switch to clk_hw_get_clk Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 02/25] clk: Drop the rate range on clk_put() Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 03/25] clk: Skip clamping when rounding if there's no boundaries Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 04/25] clk: Mention that .recalc_rate can return 0 on error Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 05/25] clk: Clarify clk_get_rate() expectations Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 06/25] clk: tests: Add test suites description Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 07/25] clk: tests: Add reference to the orphan mux bug report Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 08/25] clk: tests: Add tests for uncached clock Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 09/25] clk: tests: Add tests for single parent mux Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 10/25] clk: tests: Add tests for mux with multiple parents Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 11/25] clk: tests: Add some tests for orphan " Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 12/25] clk: Take into account uncached clocks in clk_set_rate_range() Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 13/25] clk: Set req_rate on reparenting Maxime Ripard
2022-10-03  9:59   ` Marek Szyprowski
2022-10-04 20:59     ` Stephen Boyd
2022-10-10  9:56       ` Maxime Ripard
2022-10-10 14:52         ` Maxime Ripard
2022-10-11  1:15           ` Stephen Boyd
2022-08-16 11:25 ` [PATCH v9 14/25] clk: Change clk_core_init_rate_req prototype Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 15/25] clk: Move clk_core_init_rate_req() from clk_core_round_rate_nolock() to its caller Maxime Ripard
2022-08-16 11:25 ` Maxime Ripard [this message]
2022-08-16 11:25 ` [PATCH v9 17/25] clk: Add our request boundaries in clk_core_init_rate_req Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 18/25] clk: Switch from __clk_determine_rate to clk_core_round_rate_nolock Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 19/25] clk: Introduce clk_core_has_parent() Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 20/25] clk: Constify clk_has_parent() Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 21/25] clk: Stop forwarding clk_rate_requests to the parent Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 22/25] clk: Zero the clk_rate_request structure Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 23/25] clk: Introduce the clk_hw_get_rate_range function Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 24/25] clk: qcom: clk-rcg2: Take clock boundaries into consideration for gfx3d Maxime Ripard
2022-08-16 11:25 ` [PATCH v9 25/25] clk: tests: Add missing test case for ranges Maxime Ripard
2022-08-16 14:07 ` [PATCH v9 00/25] clk: More clock rate fixes and tests Alexander Stein
2022-08-18  6:44 ` Naresh Kamboju
2022-09-02 14:53 ` Maxime Ripard
2022-09-17  8:31   ` Stephen Boyd
2022-09-20 12:35     ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220816112530.1837489-17-maxime@cerno.tech \
    --to=maxime@cerno.tech \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=jbrunet@baylibre.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mturquette@baylibre.com \
    --cc=naresh.kamboju@linaro.org \
    --cc=narmstrong@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=tony@atomide.com \
    --cc=y.oudjana@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.