All of lore.kernel.org
 help / color / mirror / Atom feed
From: Prashant Malani <pmalani@chromium.org>
To: linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev
Cc: bleung@chromium.org, Prashant Malani <pmalani@chromium.org>,
	Tzung-Bi Shih <tzungbi@kernel.org>,
	Daisuke Nojiri <dnojiri@chromium.org>,
	"Dustin L. Howett" <dustin@howett.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Guenter Roeck <groeck@chromium.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Lee Jones <lee.jones@linaro.org>,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	Tinghan Shen <tinghan.shen@mediatek.com>
Subject: [PATCH v6 6/7] platform/chrome: cros_ec_typec: Cleanup switch handle return paths
Date: Tue, 16 Aug 2022 21:48:34 +0000	[thread overview]
Message-ID: <20220816214857.2088914-7-pmalani@chromium.org> (raw)
In-Reply-To: <20220816214857.2088914-1-pmalani@chromium.org>

Some of the return paths for the cros_typec_get_switch_handles()
aren't necessary. Clean up the return paths to only undo the handle
get's which succeeded.

Signed-off-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
---

Changes since v5:
- Picked up Reviewed-by tags.

Changes since v4:
- No changes.

Changes since v3:
- No changes.

Changes since v2:
- No changes.

Changes since v1:
- No changes.

 drivers/platform/chrome/cros_ec_typec.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index de6ee0f926a6..ee54add992db 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -158,12 +158,10 @@ static int cros_typec_get_switch_handles(struct cros_typec_port *port,
 	return 0;
 
 role_sw_err:
-	usb_role_switch_put(port->role_sw);
-ori_sw_err:
 	typec_switch_put(port->ori_sw);
-mux_err:
+ori_sw_err:
 	typec_mux_put(port->mux);
-
+mux_err:
 	return -ENODEV;
 }
 
-- 
2.37.1.595.g718a3a8f04-goog


  parent reply	other threads:[~2022-08-16 21:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16 21:48 [PATCH v6 0/7] platform/chrome: Type-C switch driver Prashant Malani
2022-08-16 21:48 ` [PATCH v6 1/7] platform/chrome: Add Type-C mux set command definitions Prashant Malani
2022-08-16 21:48 ` [PATCH v6 2/7] platform/chrome: cros_typec_switch: Add switch driver Prashant Malani
2022-08-17  1:48   ` Tzung-Bi Shih
2022-08-16 21:48 ` [PATCH v6 3/7] platform/chrome: cros_typec_switch: Set EC retimer Prashant Malani
2022-08-17  1:48   ` Tzung-Bi Shih
2022-08-16 21:48 ` [PATCH v6 4/7] platform/chrome: cros_typec_switch: Add event check Prashant Malani
2022-08-17  1:48   ` Tzung-Bi Shih
2022-08-16 21:48 ` [PATCH v6 5/7] platform/chrome: cros_typec_switch: Register mode switches Prashant Malani
2022-08-17  1:49   ` Tzung-Bi Shih
2022-08-16 21:48 ` Prashant Malani [this message]
2022-08-16 21:48 ` [PATCH v6 7/7] platform/chrome: cros_ec_typec: Get retimer handle Prashant Malani
2022-08-18 22:36 ` [PATCH v6 0/7] platform/chrome: Type-C switch driver patchwork-bot+chrome-platform
2022-08-23 21:20 ` patchwork-bot+chrome-platform

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220816214857.2088914-7-pmalani@chromium.org \
    --to=pmalani@chromium.org \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=dnojiri@chromium.org \
    --cc=dustin@howett.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=groeck@chromium.org \
    --cc=gustavoars@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=tinghan.shen@mediatek.com \
    --cc=tzungbi@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.