All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Baluta <daniel.baluta@oss.nxp.com>
To: broonie@kernel.org, alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org, peter.ujfalusi@linux.intel.com,
	yung-chuan.liao@linux.intel.com,
	ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com,
	lgirdwood@gmail.com, pierre-louis.bossart@linux.intel.com,
	daniel.baluta@gmail.com, laurentiu.mihalcea@nxp.com,
	Daniel Baluta <daniel.baluta@nxp.com>,
	Paul Olaru <paul.olaru@oss.nxp.com>
Subject: [PATCH 1/4] ASoC: SOF: compress: Remove byte offset computation
Date: Wed, 17 Aug 2022 11:05:26 +0300	[thread overview]
Message-ID: <20220817080529.10864-2-daniel.baluta@oss.nxp.com> (raw)
In-Reply-To: <20220817080529.10864-1-daniel.baluta@oss.nxp.com>

From: Daniel Baluta <daniel.baluta@nxp.com>

Byte offset is the offset in the ring buffer to the DSP
while posn_offset is an offset inside the stream_box where
we keep position information.

Reviewed-by: Paul Olaru <paul.olaru@oss.nxp.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
---
 sound/soc/sof/compress.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/sof/compress.c b/sound/soc/sof/compress.c
index 67139e15f862..760d6a4a5253 100644
--- a/sound/soc/sof/compress.c
+++ b/sound/soc/sof/compress.c
@@ -237,7 +237,6 @@ static int sof_compr_set_params(struct snd_soc_component *component,
 		goto out;
 	}
 
-	tstamp->byte_offset = sdev->stream_box.offset + ipc_params_reply.posn_offset;
 	tstamp->sampling_rate = params->codec.sample_rate;
 
 	spcm->prepared[cstream->direction] = true;
-- 
2.27.0


WARNING: multiple messages have this Message-ID (diff)
From: Daniel Baluta <daniel.baluta@oss.nxp.com>
To: broonie@kernel.org, alsa-devel@alsa-project.org
Cc: Daniel Baluta <daniel.baluta@nxp.com>,
	pierre-louis.bossart@linux.intel.com, daniel.baluta@gmail.com,
	kai.vehmanen@linux.intel.com, peter.ujfalusi@linux.intel.com,
	lgirdwood@gmail.com, laurentiu.mihalcea@nxp.com,
	linux-kernel@vger.kernel.org, ranjani.sridharan@linux.intel.com,
	Paul Olaru <paul.olaru@oss.nxp.com>,
	yung-chuan.liao@linux.intel.com
Subject: [PATCH 1/4] ASoC: SOF: compress: Remove byte offset computation
Date: Wed, 17 Aug 2022 11:05:26 +0300	[thread overview]
Message-ID: <20220817080529.10864-2-daniel.baluta@oss.nxp.com> (raw)
In-Reply-To: <20220817080529.10864-1-daniel.baluta@oss.nxp.com>

From: Daniel Baluta <daniel.baluta@nxp.com>

Byte offset is the offset in the ring buffer to the DSP
while posn_offset is an offset inside the stream_box where
we keep position information.

Reviewed-by: Paul Olaru <paul.olaru@oss.nxp.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
---
 sound/soc/sof/compress.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/sof/compress.c b/sound/soc/sof/compress.c
index 67139e15f862..760d6a4a5253 100644
--- a/sound/soc/sof/compress.c
+++ b/sound/soc/sof/compress.c
@@ -237,7 +237,6 @@ static int sof_compr_set_params(struct snd_soc_component *component,
 		goto out;
 	}
 
-	tstamp->byte_offset = sdev->stream_box.offset + ipc_params_reply.posn_offset;
 	tstamp->sampling_rate = params->codec.sample_rate;
 
 	spcm->prepared[cstream->direction] = true;
-- 
2.27.0


  reply	other threads:[~2022-08-17  8:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17  8:05 [PATCH 0/4] Enable timestamp support for SOF compress driver Daniel Baluta
2022-08-17  8:05 ` Daniel Baluta
2022-08-17  8:05 ` Daniel Baluta [this message]
2022-08-17  8:05   ` [PATCH 1/4] ASoC: SOF: compress: Remove byte offset computation Daniel Baluta
2022-08-17  8:05 ` [PATCH 2/4] ASoC: SOF: compress: Introduce sof_compr_stream Daniel Baluta
2022-08-17  8:05   ` Daniel Baluta
2022-08-17  8:05 ` [PATCH 3/4] ASoC: SOF: compress: Save channel count and sample bytes Daniel Baluta
2022-08-17  8:05   ` Daniel Baluta
2022-08-17  8:05 ` [PATCH 4/4] ASoC: SOF: compress: Add support for computing timestamps Daniel Baluta
2022-08-17  8:05   ` Daniel Baluta
2022-08-17 14:31 ` [PATCH 0/4] Enable timestamp support for SOF compress driver Mark Brown
2022-08-17 14:31   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220817080529.10864-2-daniel.baluta@oss.nxp.com \
    --to=daniel.baluta@oss.nxp.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=daniel.baluta@gmail.com \
    --cc=daniel.baluta@nxp.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=laurentiu.mihalcea@nxp.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.olaru@oss.nxp.com \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.