All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Ohad Ben-Cohen <ohad@wizery.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Lee Jones <lee@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [RFT PATCH 01/12] dt-bindings: hwlock: qcom-hwspinlock: add support for MMIO on older SoCs
Date: Wed, 17 Aug 2022 16:14:04 +0300	[thread overview]
Message-ID: <20220817131415.714340-2-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20220817131415.714340-1-krzysztof.kozlowski@linaro.org>

Older Qualcomm SoCs have TCSR mutex registers with 0x80 stride, instead
of 0x1000.  Add dedicated compatibles for such case.  Unfortunately the
binding started using a generic "qcom,tcsr-mutex" compatible without
specifying the SoC part, thus it looks now quite inconsistent.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

If anyone ever says "I want a generic compatible because I am sure all
devices are compatible", that's one more argument they are wrong. :)
---
 .../bindings/hwlock/qcom-hwspinlock.yaml          | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml
index 1c7149f7d171..de98b961fb38 100644
--- a/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml
+++ b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml
@@ -15,9 +15,18 @@ description:
 
 properties:
   compatible:
-    enum:
-      - qcom,sfpb-mutex
-      - qcom,tcsr-mutex
+    oneOf:
+      - enum:
+          - qcom,sfpb-mutex
+          - qcom,tcsr-mutex
+      - items:
+          - enum:
+              - qcom,apq8084-tcsr-mutex
+              - qcom,ipq6018-tcsr-mutex
+              - qcom,msm8226-tcsr-mutex
+              - qcom,msm8974-tcsr-mutex
+              - qcom,msm8994-tcsr-mutex
+          - const: qcom,tcsr-mutex
 
   reg:
     maxItems: 1
-- 
2.34.1


  reply	other threads:[~2022-08-17 13:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17 13:14 [RFT PATCH 00/12] ARM/hwlock: qcom: switch TCSR mutex to MMIO Krzysztof Kozlowski
2022-08-17 13:14 ` Krzysztof Kozlowski [this message]
2022-08-17 13:14 ` [RFT PATCH 02/12] dt-bindings: hwlock: qcom-hwspinlock: correct example indentation Krzysztof Kozlowski
2022-08-17 13:14 ` [RFT PATCH 03/12] dt-bindings: mfd: qcom,tcsr: add MSM8974 Krzysztof Kozlowski
2022-08-17 13:37   ` Krzysztof Kozlowski
2022-08-17 13:14 ` [RFT PATCH 04/12] hwspinlock: qcom: correct MMIO max register for newer SoCs Krzysztof Kozlowski
2022-08-17 21:08   ` Konrad Dybcio
2022-08-17 13:14 ` [RFT PATCH 05/12] hwspinlock: qcom: add support for MMIO on older SoCs Krzysztof Kozlowski
2022-08-17 13:14 ` [RFT PATCH 06/12] arm64: dts: qcom: ipq6018: switch TCSR mutex to MMIO Krzysztof Kozlowski
2022-08-17 13:14 ` [RFT PATCH 07/12] arm64: dts: qcom: msm8994: " Krzysztof Kozlowski
2022-08-17 13:14 ` [RFT PATCH 08/12] ARM: dts: qcom: msm8974: add missing TCSR syscon compatible Krzysztof Kozlowski
2022-08-17 13:38   ` Krzysztof Kozlowski
2022-08-17 13:14 ` [RFT PATCH 09/12] ARM: dts: qcom: msm8974: split TCSR halt regs out of mutex Krzysztof Kozlowski
2022-08-17 13:14 ` [RFT PATCH 10/12] ARM: dts: qcom: msm8974: switch TCSR mutex to MMIO Krzysztof Kozlowski
2022-08-17 13:14 ` [RFT PATCH 11/12] ARM: dts: qcom: apq8084: " Krzysztof Kozlowski
2022-08-17 13:14 ` [RFT PATCH 12/12] ARM: dts: qcom: msm8226: " Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220817131415.714340-2-krzysztof.kozlowski@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.