All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Ohad Ben-Cohen <ohad@wizery.com>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Lee Jones <lee@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [RFT PATCH v2 16/17] ARM: dts: qcom: apq8084: switch TCSR mutex to MMIO
Date: Wed, 17 Aug 2022 17:59:00 +0300	[thread overview]
Message-ID: <20220817145901.865977-17-krzysztof.kozlowski@linaro.org> (raw)
In-Reply-To: <20220817145901.865977-1-krzysztof.kozlowski@linaro.org>

The TCSR mutex bindings allow device to be described only with address
space (so it uses MMIO, not syscon regmap).  This seems reasonable as
TCSR mutex is actually a dedicated IO address space and it also fixes DT
schema checks:

  qcom-apq8084-mtp.dtb: hwlock: 'reg' is a required property
  qcom-apq8084-mtp.dtb: hwlock: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom-apq8084.dtsi | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-apq8084.dtsi b/arch/arm/boot/dts/qcom-apq8084.dtsi
index 72f9255855a1..5e07255fe5ea 100644
--- a/arch/arm/boot/dts/qcom-apq8084.dtsi
+++ b/arch/arm/boot/dts/qcom-apq8084.dtsi
@@ -383,14 +383,9 @@ gcc: clock-controller@fc400000 {
 			reg = <0xfc400000 0x4000>;
 		};
 
-		tcsr_mutex_regs: syscon@fd484000 {
-			compatible = "syscon";
-			reg = <0xfd484000 0x2000>;
-		};
-
-		tcsr_mutex: hwlock {
-			compatible = "qcom,tcsr-mutex";
-			syscon = <&tcsr_mutex_regs 0 0x80>;
+		tcsr_mutex: hwlock@fd484000 {
+			compatible = "qcom,apq8084-tcsr-mutex", "qcom,tcsr-mutex";
+			reg = <0xfd484000 0x1000>;
 			#hwlock-cells = <1>;
 		};
 
-- 
2.34.1


  parent reply	other threads:[~2022-08-17 15:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17 14:58 [RFT PATCH v2 00/17] ARM/hwlock: qcom: switch TCSR mutex to MMIO Krzysztof Kozlowski
2022-08-17 14:58 ` [RFT PATCH v2 01/17] dt-bindings: mfd: qcom,tcsr: drop simple-mfd from IPQ6018 Krzysztof Kozlowski
2022-09-08  7:49   ` Lee Jones
2022-08-17 14:58 ` [RFT PATCH v2 02/17] dt-bindings: mfd: qcom,tcsr: add QCS404 Krzysztof Kozlowski
2022-09-08  7:50   ` Lee Jones
2022-09-08  8:15     ` Krzysztof Kozlowski
2022-09-08 15:35       ` Krzysztof Kozlowski
2022-09-09  7:19         ` Lee Jones
2022-09-09  7:17       ` Lee Jones
2022-08-17 14:58 ` [RFT PATCH v2 03/17] dt-bindings: hwlock: qcom-hwspinlock: add support for MMIO on older SoCs Krzysztof Kozlowski
2022-08-17 14:58 ` [RFT PATCH v2 04/17] dt-bindings: hwlock: qcom-hwspinlock: correct example indentation Krzysztof Kozlowski
2022-08-17 14:58 ` [RFT PATCH v2 05/17] hwspinlock: qcom: correct MMIO max register for newer SoCs Krzysztof Kozlowski
2022-08-17 14:58 ` [RFT PATCH v2 06/17] hwspinlock: qcom: add support for MMIO on older SoCs Krzysztof Kozlowski
2022-08-17 14:58 ` [RFT PATCH v2 07/17] arm64: dts: qcom: ipq6018: add missing TCSR syscon compatible Krzysztof Kozlowski
2022-08-17 14:58 ` [RFT PATCH v2 08/17] arm64: dts: qcom: msm8953: " Krzysztof Kozlowski
2022-08-17 14:58 ` [RFT PATCH v2 09/17] arm64: dts: qcom: qcs404: " Krzysztof Kozlowski
2022-08-17 14:58 ` [RFT PATCH v2 10/17] arm64: dts: qcom: msm8996: " Krzysztof Kozlowski
2022-08-17 14:58 ` [RFT PATCH v2 11/17] ARM: dts: qcom: msm8974: " Krzysztof Kozlowski
2022-08-17 14:58 ` [RFT PATCH v2 12/17] ARM: dts: qcom: msm8974: split TCSR halt regs out of mutex Krzysztof Kozlowski
2022-08-17 14:58 ` [RFT PATCH v2 13/17] arm64: dts: qcom: ipq6018: switch TCSR mutex to MMIO Krzysztof Kozlowski
2022-08-17 14:58 ` [RFT PATCH v2 14/17] arm64: dts: qcom: msm8994: " Krzysztof Kozlowski
2022-08-17 14:58 ` [RFT PATCH v2 15/17] ARM: dts: qcom: msm8974: " Krzysztof Kozlowski
2022-08-17 14:59 ` Krzysztof Kozlowski [this message]
2022-08-17 14:59 ` [RFT PATCH v2 17/17] ARM: dts: qcom: msm8226: " Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220817145901.865977-17-krzysztof.kozlowski@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.