All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Rojtberg <rojtberg@gmail.com>
To: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com,
	gregkh@linuxfoundation.org
Cc: Cameron Gutman <aicommander@gmail.com>,
	stable@vger.kernel.org, Pavel Rojtberg <rojtberg@gmail.com>
Subject: [PATCH v2 2/4] Input: xpad - fix wireless 360 controller breaking after suspend
Date: Thu, 18 Aug 2022 17:44:09 +0200	[thread overview]
Message-ID: <20220818154411.510308-3-rojtberg@gmail.com> (raw)
In-Reply-To: <20220818154411.510308-1-rojtberg@gmail.com>

From: Cameron Gutman <aicommander@gmail.com>

Suspending and resuming the system can sometimes cause the out
URB to get hung after a reset_resume. This causes LED setting
and force feedback to break on resume. To avoid this, just drop
the reset_resume callback so the USB core rebinds xpad to the
wireless pads on resume if a reset happened.

A nice side effect of this change is the LED ring on wireless
controllers is now set correctly on system resume.

Cc: stable@vger.kernel.org
Fixes: 4220f7db1e42 ("Input: xpad - workaround dead irq_out after suspend/ resume")
Signed-off-by: Cameron Gutman <aicommander@gmail.com>
Signed-off-by: Pavel Rojtberg <rojtberg@gmail.com>
---
 drivers/input/joystick/xpad.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 629646b..4e01056 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -1991,7 +1991,6 @@ static struct usb_driver xpad_driver = {
 	.disconnect	= xpad_disconnect,
 	.suspend	= xpad_suspend,
 	.resume		= xpad_resume,
-	.reset_resume	= xpad_resume,
 	.id_table	= xpad_table,
 };
 
-- 
2.34.1


  parent reply	other threads:[~2022-08-18 15:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-18 15:44 [PATCH v2 0/4] Input: xpad - sync with github fork Pavel Rojtberg
2022-08-18 15:44 ` [PATCH v2 1/4] Input: xpad - add supported devices as contributed on github Pavel Rojtberg
2022-08-18 15:44 ` Pavel Rojtberg [this message]
2022-08-18 15:44 ` [PATCH v2 3/4] Input: xpad - Poweroff XBOX360W on mode button long press Pavel Rojtberg
2022-08-18 15:44 ` [PATCH v2 4/4] Input: xpad - add support for XBOX One Elite paddles Pavel Rojtberg
2022-08-19  9:34   ` Bastien Nocera
2022-09-02 10:45 ` [PATCH v2 0/4] Input: xpad - sync with github fork Pavel Rojtberg
2022-09-06 12:00 ` Pavel Rojtberg
2022-09-06 18:47 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220818154411.510308-3-rojtberg@gmail.com \
    --to=rojtberg@gmail.com \
    --cc=aicommander@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-input@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.