From: Yang Yingliang <yangyingliang@huawei.com> To: <linux-kernel@vger.kernel.org>, <linux-sunxi@lists.linux.dev>, <linux-arm-kernel@lists.infradead.org>, <linux-clk@vger.kernel.org> Cc: <mturquette@baylibre.com>, <sboyd@kernel.org>, <wens@csie.org>, <jernej.skrabec@gmail.com> Subject: [PATCH -next 3/3] clk: sunxi-ng: ccu-sun9i-a80-usb: Use dev_err_probe() helper Date: Sat, 27 Aug 2022 17:41:51 +0800 [thread overview] Message-ID: <20220827094151.3323450-3-yangyingliang@huawei.com> (raw) In-Reply-To: <20220827094151.3323450-1-yangyingliang@huawei.com> dev_err() can be replace with dev_err_probe() which will check if error code is -EPROBE_DEFER. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c b/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c index 575ae4ccc65f..a0fb0da8f356 100644 --- a/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c +++ b/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c @@ -101,12 +101,9 @@ static int sun9i_a80_usb_clk_probe(struct platform_device *pdev) return PTR_ERR(reg); bus_clk = devm_clk_get(&pdev->dev, "bus"); - if (IS_ERR(bus_clk)) { - ret = PTR_ERR(bus_clk); - if (ret != -EPROBE_DEFER) - dev_err(&pdev->dev, "Couldn't get bus clk: %d\n", ret); - return ret; - } + if (IS_ERR(bus_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(bus_clk), + "Couldn't get bus clk\n"); /* The bus clock needs to be enabled for us to access the registers */ ret = clk_prepare_enable(bus_clk); -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Yang Yingliang <yangyingliang@huawei.com> To: <linux-kernel@vger.kernel.org>, <linux-sunxi@lists.linux.dev>, <linux-arm-kernel@lists.infradead.org>, <linux-clk@vger.kernel.org> Cc: <mturquette@baylibre.com>, <sboyd@kernel.org>, <wens@csie.org>, <jernej.skrabec@gmail.com> Subject: [PATCH -next 3/3] clk: sunxi-ng: ccu-sun9i-a80-usb: Use dev_err_probe() helper Date: Sat, 27 Aug 2022 17:41:51 +0800 [thread overview] Message-ID: <20220827094151.3323450-3-yangyingliang@huawei.com> (raw) In-Reply-To: <20220827094151.3323450-1-yangyingliang@huawei.com> dev_err() can be replace with dev_err_probe() which will check if error code is -EPROBE_DEFER. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c b/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c index 575ae4ccc65f..a0fb0da8f356 100644 --- a/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c +++ b/drivers/clk/sunxi-ng/ccu-sun9i-a80-usb.c @@ -101,12 +101,9 @@ static int sun9i_a80_usb_clk_probe(struct platform_device *pdev) return PTR_ERR(reg); bus_clk = devm_clk_get(&pdev->dev, "bus"); - if (IS_ERR(bus_clk)) { - ret = PTR_ERR(bus_clk); - if (ret != -EPROBE_DEFER) - dev_err(&pdev->dev, "Couldn't get bus clk: %d\n", ret); - return ret; - } + if (IS_ERR(bus_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(bus_clk), + "Couldn't get bus clk\n"); /* The bus clock needs to be enabled for us to access the registers */ ret = clk_prepare_enable(bus_clk); -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-27 9:53 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-27 9:41 [PATCH -next 1/3] clk: sunxi-ng: sun8i-de2: Use dev_err_probe() helper Yang Yingliang 2022-08-27 9:41 ` Yang Yingliang 2022-08-27 9:41 ` [PATCH -next 2/3] clk: sunxi-ng: ccu-sun9i-a80-de: " Yang Yingliang 2022-08-27 9:41 ` Yang Yingliang 2022-08-27 11:07 ` Jernej Škrabec 2022-08-27 11:07 ` Jernej Škrabec 2022-08-27 9:41 ` Yang Yingliang [this message] 2022-08-27 9:41 ` [PATCH -next 3/3] clk: sunxi-ng: ccu-sun9i-a80-usb: " Yang Yingliang 2022-08-27 11:07 ` Jernej Škrabec 2022-08-27 11:07 ` Jernej Škrabec 2022-08-27 11:07 ` [PATCH -next 1/3] clk: sunxi-ng: sun8i-de2: " Jernej Škrabec 2022-08-27 11:07 ` Jernej Škrabec 2022-09-08 19:55 ` Jernej Škrabec 2022-09-08 19:55 ` Jernej Škrabec
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220827094151.3323450-3-yangyingliang@huawei.com \ --to=yangyingliang@huawei.com \ --cc=jernej.skrabec@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=mturquette@baylibre.com \ --cc=sboyd@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.