All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: "Kees Cook" <keescook@chromium.org>,
	linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linaro-mm-sig@lists.linaro.org,
	"Pekka Enberg" <penberg@kernel.org>,
	"David Rientjes" <rientjes@google.com>,
	"Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Alex Elder" <elder@kernel.org>,
	"Josef Bacik" <josef@toxicpanda.com>,
	"David Sterba" <dsterba@suse.com>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Christian König" <christian.koenig@amd.com>,
	"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
	"Daniel Micay" <danielmicay@gmail.com>,
	"Yonghong Song" <yhs@fb.com>, "Marco Elver" <elver@google.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Jacob Shin" <jacob.shin@amd.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	netdev@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
	dev@openvswitch.org, x86@kernel.org,
	linux-wireless@vger.kernel.org, llvm@lists.linux.dev,
	linux-hardening@vger.kernel.org
Subject: [PATCH 05/12] dma-buf: Proactively round up to kmalloc bucket size
Date: Wed, 21 Sep 2022 20:10:06 -0700	[thread overview]
Message-ID: <20220922031013.2150682-6-keescook@chromium.org> (raw)
In-Reply-To: <20220922031013.2150682-1-keescook@chromium.org>

Instead of discovering the kmalloc bucket size _after_ allocation, round
up proactively so the allocation is explicitly made for the full size,
allowing the compiler to correctly reason about the resulting size of
the buffer through the existing __alloc_size() hint.

Cc: linux-media@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linaro-mm-sig@lists.linaro.org
Signed-off-by: Kees Cook <keescook@chromium.org>
---
 drivers/dma-buf/dma-resv.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c
index 205acb2c744d..a20f6db99b8f 100644
--- a/drivers/dma-buf/dma-resv.c
+++ b/drivers/dma-buf/dma-resv.c
@@ -98,12 +98,17 @@ static void dma_resv_list_set(struct dma_resv_list *list,
 static struct dma_resv_list *dma_resv_list_alloc(unsigned int max_fences)
 {
 	struct dma_resv_list *list;
+	size_t size = struct_size(list, table, max_fences);
 
-	list = kmalloc(struct_size(list, table, max_fences), GFP_KERNEL);
+	/* Round up to the next kmalloc bucket size. */
+	size = kmalloc_size_roundup(size);
+
+	list = kmalloc(size, GFP_KERNEL);
 	if (!list)
 		return NULL;
 
-	list->max_fences = (ksize(list) - offsetof(typeof(*list), table)) /
+	/* Given the resulting bucket size, recalculated max_fences. */
+	list->max_fences = (size - offsetof(typeof(*list), table)) /
 		sizeof(*list->table);
 
 	return list;
-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-wireless@vger.kernel.org, "Jacob Shin" <jacob.shin@amd.com>,
	llvm@lists.linux.dev, dri-devel@lists.freedesktop.org,
	linux-mm@kvack.org, "Eric Dumazet" <edumazet@google.com>,
	linux-hardening@vger.kernel.org,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	dev@openvswitch.org, x86@kernel.org,
	"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
	intel-wired-lan@lists.osuosl.org,
	"David Rientjes" <rientjes@google.com>,
	"Miguel Ojeda" <ojeda@kernel.org>, "Yonghong Song" <yhs@fb.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	linux-media@vger.kernel.org, "Marco Elver" <elver@google.com>,
	"Kees Cook" <keescook@chromium.org>,
	"Josef Bacik" <josef@toxicpanda.com>,
	linaro-mm-sig@lists.linaro.org,
	"Jakub Kicinski" <kuba@kernel.org>,
	"David Sterba" <dsterba@suse.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Alex Elder" <elder@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	"Pekka Enberg" <penberg@kernel.org>,
	"Daniel Micay" <danielmicay@gmail.com>,
	netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	"Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
	"Christian König" <christian.koenig@amd.com>,
	linux-btrfs@vger.kernel.org
Subject: [PATCH 05/12] dma-buf: Proactively round up to kmalloc bucket size
Date: Wed, 21 Sep 2022 20:10:06 -0700	[thread overview]
Message-ID: <20220922031013.2150682-6-keescook@chromium.org> (raw)
In-Reply-To: <20220922031013.2150682-1-keescook@chromium.org>

Instead of discovering the kmalloc bucket size _after_ allocation, round
up proactively so the allocation is explicitly made for the full size,
allowing the compiler to correctly reason about the resulting size of
the buffer through the existing __alloc_size() hint.

Cc: linux-media@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linaro-mm-sig@lists.linaro.org
Signed-off-by: Kees Cook <keescook@chromium.org>
---
 drivers/dma-buf/dma-resv.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c
index 205acb2c744d..a20f6db99b8f 100644
--- a/drivers/dma-buf/dma-resv.c
+++ b/drivers/dma-buf/dma-resv.c
@@ -98,12 +98,17 @@ static void dma_resv_list_set(struct dma_resv_list *list,
 static struct dma_resv_list *dma_resv_list_alloc(unsigned int max_fences)
 {
 	struct dma_resv_list *list;
+	size_t size = struct_size(list, table, max_fences);
 
-	list = kmalloc(struct_size(list, table, max_fences), GFP_KERNEL);
+	/* Round up to the next kmalloc bucket size. */
+	size = kmalloc_size_roundup(size);
+
+	list = kmalloc(size, GFP_KERNEL);
 	if (!list)
 		return NULL;
 
-	list->max_fences = (ksize(list) - offsetof(typeof(*list), table)) /
+	/* Given the resulting bucket size, recalculated max_fences. */
+	list->max_fences = (size - offsetof(typeof(*list), table)) /
 		sizeof(*list->table);
 
 	return list;
-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-wireless@vger.kernel.org, "Jacob Shin" <jacob.shin@amd.com>,
	llvm@lists.linux.dev, dri-devel@lists.freedesktop.org,
	linux-mm@kvack.org, "Eric Dumazet" <edumazet@google.com>,
	linux-hardening@vger.kernel.org,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	dev@openvswitch.org, x86@kernel.org,
	intel-wired-lan@lists.osuosl.org,
	"David Rientjes" <rientjes@google.com>,
	"Miguel Ojeda" <ojeda@kernel.org>, "Yonghong Song" <yhs@fb.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	linux-media@vger.kernel.org, "Marco Elver" <elver@google.com>,
	"Kees Cook" <keescook@chromium.org>,
	"Josef Bacik" <josef@toxicpanda.com>,
	linaro-mm-sig@lists.linaro.org,
	"Jakub Kicinski" <kuba@kernel.org>,
	"David Sterba" <dsterba@suse.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Alex Elder" <elder@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	"Pekka Enberg" <penberg@kernel.org>,
	"Daniel Micay" <danielmicay@gmail.com>,
	netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	"Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
	"Christian König" <christian.koenig@amd.com>,
	linux-btrfs@vger.kernel.org
Subject: [Intel-wired-lan] [PATCH 05/12] dma-buf: Proactively round up to kmalloc bucket size
Date: Wed, 21 Sep 2022 20:10:06 -0700	[thread overview]
Message-ID: <20220922031013.2150682-6-keescook@chromium.org> (raw)
In-Reply-To: <20220922031013.2150682-1-keescook@chromium.org>

Instead of discovering the kmalloc bucket size _after_ allocation, round
up proactively so the allocation is explicitly made for the full size,
allowing the compiler to correctly reason about the resulting size of
the buffer through the existing __alloc_size() hint.

Cc: linux-media@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linaro-mm-sig@lists.linaro.org
Signed-off-by: Kees Cook <keescook@chromium.org>
---
 drivers/dma-buf/dma-resv.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c
index 205acb2c744d..a20f6db99b8f 100644
--- a/drivers/dma-buf/dma-resv.c
+++ b/drivers/dma-buf/dma-resv.c
@@ -98,12 +98,17 @@ static void dma_resv_list_set(struct dma_resv_list *list,
 static struct dma_resv_list *dma_resv_list_alloc(unsigned int max_fences)
 {
 	struct dma_resv_list *list;
+	size_t size = struct_size(list, table, max_fences);
 
-	list = kmalloc(struct_size(list, table, max_fences), GFP_KERNEL);
+	/* Round up to the next kmalloc bucket size. */
+	size = kmalloc_size_roundup(size);
+
+	list = kmalloc(size, GFP_KERNEL);
 	if (!list)
 		return NULL;
 
-	list->max_fences = (ksize(list) - offsetof(typeof(*list), table)) /
+	/* Given the resulting bucket size, recalculated max_fences. */
+	list->max_fences = (size - offsetof(typeof(*list), table)) /
 		sizeof(*list->table);
 
 	return list;
-- 
2.34.1

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

  parent reply	other threads:[~2022-09-22  3:10 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22  3:10 [PATCH 00/12] slab: Introduce kmalloc_size_roundup() Kees Cook
2022-09-22  3:10 ` [Intel-wired-lan] " Kees Cook
2022-09-22  3:10 ` Kees Cook
2022-09-22  3:10 ` [PATCH 01/12] " Kees Cook
2022-09-22  3:10   ` [Intel-wired-lan] " Kees Cook
2022-09-22  3:10   ` Kees Cook
2022-09-22 11:12   ` Hyeonggon Yoo
2022-09-22 11:12     ` [Intel-wired-lan] " Hyeonggon Yoo
2022-09-22 11:12     ` Hyeonggon Yoo
2022-09-23  1:17     ` Feng Tang
2022-09-23  1:17       ` [Intel-wired-lan] " Feng Tang
2022-09-23  1:17       ` Feng Tang
2022-09-23 18:50       ` Kees Cook
2022-09-23 18:50         ` [Intel-wired-lan] " Kees Cook
2022-09-23 18:50         ` Kees Cook
2022-09-22  3:10 ` [PATCH 02/12] skbuff: Proactively round up to kmalloc bucket size Kees Cook
2022-09-22  3:10   ` [Intel-wired-lan] " Kees Cook
2022-09-22  3:10   ` Kees Cook
2022-09-22 19:40   ` Jakub Kicinski
2022-09-22 19:40     ` [Intel-wired-lan] " Jakub Kicinski
2022-09-22 19:40     ` Jakub Kicinski
2022-09-22  3:10 ` [PATCH 03/12] net: ipa: " Kees Cook
2022-09-22  3:10   ` [Intel-wired-lan] " Kees Cook
2022-09-22  3:10   ` Kees Cook
2022-09-22 13:45   ` Alex Elder
2022-09-22 13:45     ` [Intel-wired-lan] " Alex Elder
2022-09-22 13:45     ` Alex Elder
2022-09-22 15:57     ` Kees Cook
2022-09-22 15:57       ` Kees Cook
2022-09-22 15:57       ` [Intel-wired-lan] " Kees Cook
2022-09-22  3:10 ` [PATCH 04/12] btrfs: send: " Kees Cook
2022-09-22  3:10   ` [Intel-wired-lan] " Kees Cook
2022-09-22  3:10   ` Kees Cook
2022-09-22 13:30   ` David Sterba
2022-09-22 13:30     ` [Intel-wired-lan] " David Sterba
2022-09-22 13:30     ` David Sterba
2022-09-22  3:10 ` Kees Cook [this message]
2022-09-22  3:10   ` [Intel-wired-lan] [PATCH 05/12] dma-buf: " Kees Cook
2022-09-22  3:10   ` Kees Cook
2022-09-22  3:10 ` [PATCH 06/12] coredump: " Kees Cook
2022-09-22  3:10   ` [Intel-wired-lan] " Kees Cook
2022-09-22  3:10   ` Kees Cook
2022-09-22  3:10 ` [PATCH 07/12] igb: " Kees Cook
2022-09-22  3:10   ` [Intel-wired-lan] " Kees Cook
2022-09-22  3:10   ` Kees Cook
2022-09-22 15:56   ` Ruhl, Michael J
2022-09-22 15:56     ` [Intel-wired-lan] " Ruhl, Michael J
2022-09-22 15:56     ` Ruhl, Michael J
2022-09-22 16:00     ` Kees Cook
2022-09-22 16:00       ` [Intel-wired-lan] " Kees Cook
2022-09-22 16:00       ` Kees Cook
2022-09-22  3:10 ` [PATCH 08/12] openvswitch: " Kees Cook
2022-09-22  3:10   ` Kees Cook
2022-09-22  3:10   ` [Intel-wired-lan] " Kees Cook
2022-09-22  3:10 ` [PATCH 09/12] x86/microcode/AMD: Track patch allocation size explicitly Kees Cook
2022-09-22  3:10   ` [Intel-wired-lan] " Kees Cook
2022-09-22  3:10   ` Kees Cook
2022-09-22  3:10 ` [PATCH 10/12] iwlwifi: Track scan_cmd " Kees Cook
2022-09-22  3:10   ` [Intel-wired-lan] " Kees Cook
2022-09-22  3:10   ` Kees Cook
2022-09-22  4:18   ` Kalle Valo
2022-09-22  4:18     ` [Intel-wired-lan] " Kalle Valo
2022-09-22  4:18     ` Kalle Valo
2022-09-22  5:26     ` Kees Cook
2022-09-22  5:26       ` [Intel-wired-lan] " Kees Cook
2022-09-22  5:26       ` Kees Cook
2022-09-22  3:10 ` [PATCH 11/12] slab: Remove __malloc attribute from realloc functions Kees Cook
2022-09-22  3:10   ` [Intel-wired-lan] " Kees Cook
2022-09-22  3:10   ` Kees Cook
2022-09-22  9:23   ` Miguel Ojeda
2022-09-22  9:23     ` [Intel-wired-lan] " Miguel Ojeda
2022-09-22  9:23     ` Miguel Ojeda
2022-09-22 15:56     ` Kees Cook
2022-09-22 15:56       ` [Intel-wired-lan] " Kees Cook
2022-09-22 15:56       ` Kees Cook
2022-09-22 17:41       ` Miguel Ojeda
2022-09-22 17:41         ` [Intel-wired-lan] " Miguel Ojeda
2022-09-22 17:41         ` Miguel Ojeda
2022-09-22  3:10 ` [PATCH 12/12] slab: Restore __alloc_size attribute to __kmalloc_track_caller Kees Cook
2022-09-22  3:10   ` Kees Cook
2022-09-22  3:10   ` [Intel-wired-lan] " Kees Cook
2022-09-22  7:10 ` [PATCH 00/12] slab: Introduce kmalloc_size_roundup() Christian König
2022-09-22  7:10   ` [Intel-wired-lan] " Christian König
2022-09-22  7:10   ` Christian König
2022-09-22 15:55   ` Kees Cook
2022-09-22 15:55     ` [Intel-wired-lan] " Kees Cook
2022-09-22 15:55     ` Kees Cook
2022-09-22 21:05     ` Vlastimil Babka
2022-09-22 21:05       ` [Intel-wired-lan] " Vlastimil Babka
2022-09-22 21:05       ` Vlastimil Babka
2022-09-22 21:49       ` Kees Cook
2022-09-22 21:49         ` [Intel-wired-lan] " Kees Cook
2022-09-22 21:49         ` Kees Cook
2022-09-23  9:07         ` Vlastimil Babka
2022-09-23  9:07           ` [Intel-wired-lan] " Vlastimil Babka
2022-09-23  9:07           ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220922031013.2150682-6-keescook@chromium.org \
    --to=keescook@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=christian.koenig@amd.com \
    --cc=danielmicay@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dsterba@suse.com \
    --cc=edumazet@google.com \
    --cc=elder@kernel.org \
    --cc=elver@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacob.shin@amd.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=josef@toxicpanda.com \
    --cc=kuba@kernel.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=ndesaulniers@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=pabeni@redhat.com \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=sumit.semwal@linaro.org \
    --cc=vbabka@suse.cz \
    --cc=x86@kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.