From: Nicholas Piggin <npiggin@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Nicholas Piggin <npiggin@gmail.com>
Subject: [PATCH v3 1/7] powerpc/64/interrupt: Fix false warning in context tracking due to idle state
Date: Mon, 26 Sep 2022 15:42:59 +1000 [thread overview]
Message-ID: <20220926054305.2671436-2-npiggin@gmail.com> (raw)
In-Reply-To: <20220926054305.2671436-1-npiggin@gmail.com>
Commit 171476775d32 ("context_tracking: Convert state to atomic_t")
added a CONTEXT_IDLE state which can be encountered by interrupts from
kernel mode in the idle thread, causing a false positive warning.
Fixes: 171476775d32 ("context_tracking: Convert state to atomic_t")
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
arch/powerpc/include/asm/interrupt.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/interrupt.h b/arch/powerpc/include/asm/interrupt.h
index 8069dbc4b8d1..b61555e30c7c 100644
--- a/arch/powerpc/include/asm/interrupt.h
+++ b/arch/powerpc/include/asm/interrupt.h
@@ -195,7 +195,8 @@ static inline void interrupt_enter_prepare(struct pt_regs *regs)
* so avoid recursion.
*/
if (TRAP(regs) != INTERRUPT_PROGRAM) {
- CT_WARN_ON(ct_state() != CONTEXT_KERNEL);
+ CT_WARN_ON(ct_state() != CONTEXT_KERNEL &&
+ ct_state() != CONTEXT_IDLE);
if (IS_ENABLED(CONFIG_PPC_IRQ_SOFT_MASK_DEBUG))
BUG_ON(is_implicit_soft_masked(regs));
}
--
2.37.2
next prev parent reply other threads:[~2022-09-26 5:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 5:42 [PATCH v3 0/7] powerpc/64: interrupt soft-mask and context fixes Nicholas Piggin
2022-09-26 5:42 ` Nicholas Piggin [this message]
2022-09-26 5:43 ` [PATCH v3 2/7] powerpc/64: mark irqs hard disabled in boot paca Nicholas Piggin
2022-09-26 5:43 ` [PATCH v3 3/7] powerpc/64/interrupt: Fix return to masked context after hard-mask irq becomes pending Nicholas Piggin
2022-09-26 5:43 ` [PATCH v3 4/7] powerpc/64s: Fix irq state management in runlatch functions Nicholas Piggin
2022-09-26 5:43 ` [PATCH v3 5/7] powerpc/64s/interrupt: masked handler debug check for previous hard disable Nicholas Piggin
2022-09-26 5:43 ` [PATCH v3 6/7] powerpc/64/interrupt: avoid BUG/WARN recursion in interrupt entry Nicholas Piggin
2022-09-26 5:43 ` [PATCH v3 7/7] powerpc/64/irq: tidy soft-masked irq replay and improve documentation Nicholas Piggin
2022-10-04 13:25 ` [PATCH v3 0/7] powerpc/64: interrupt soft-mask and context fixes Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220926054305.2671436-2-npiggin@gmail.com \
--to=npiggin@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.